pidgin minimize to tray is visually wrong using compiz

[will_in_wi]

Binary package hint: compiz

When I click on the tray icon to minimize pidgin, it uses the window close effect. It should use the minimize effect like rhythmbox does.

Gutsy Beta

[David Portwood (dzportwood)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. However, this compiz package is not from the official Ubuntu repositories, and as such is not supported here. Please report this bug upstream at [WWW] https://bugs.freedesktop.org/enter_bug.cgi?product=xorg . Thanks!

[David Portwood (dzportwood)]

I closed the wrong set of bugs, sorry.

[Danny Baumann (dannybaumann)]

This is not a compiz problem. Pidgin must tell Compiz that it's iconified and not minimized, and it must tell Compiz where it's iconified to.
In rythmbox, this is done in the rb_shell_set_visibility function in shell/rb-shell.c.

[Richard Laager (rlaager)]

I looked at the code in Rhythmbox. I see what it's doing. Every application should not have to duplicate that code. I'll see if that can be implemented in libegg or something.

[Richard Laager (rlaager)]

It seems like we should switch to GtkStatusIcon at some point. Then there could be something like this in GTK+ (based off the code from Rhythmbox):

void gtk_status_icon_iconify_window(GtkStatusIcon *icon, GtkWindow *window)
{
    if (!gtk_status_icon_is_embedded ())
        return;

    // Get the geometry of the tray icon as with gtk_status_icon_get_geometry ()
    // Set the geometry of the window.
    gtk_window_set_skip_taskbar_hint(window, TRUE);
    gtk_window_iconify(window);
    gtk_window_hide(window);

    g_list_prepend(hidden_windows, window);
}

void gtk_status_icon_deiconify_windows(GtkStatusIcon *icon)
{
    // for window in hidden_windows:
        gtk_window_set_skip_taskbar_hint(window, FALSE);
        gtk_window_show(window);
        gtk_window_deiconify(window);

        // remove window from hidden_windows
    // end
}

Obviously, this needs some input from the GTK+ guys. I'm not sure if the icon should automatically de-iconify on click or not. I'm also not sure if you'd want to de-iconify everything in one shot (or if it should even track multiple hidden windows).

[Richard Laager (rlaager)]

This may come up when Rhythmbox ports to GtkStatusIcon: http://bugzilla.gnome.org/show_bug.cgi?id=349280