Ubuntu
compiz package

python-compizconfig needs to be ported to python3

Bug #1310794 reported by Brandon Schaefer
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
High
Unassigned
compiz (Ubuntu)
Fix Released
High
Unassigned

Bug Description

python-compizconfig needs to be ported to python3, otherwise autopilot tests in unity7 will start to fail! We cannot have that.

See original description

Related branches

lp:~muktupavels/compiz/ccsm-python3
Dmitry Shachnev: Approve
Diff: 560 lines (+88/-132)
18 files modified
compizconfig/ccsm/CMakeLists.txt (+7/-11)
compizconfig/ccsm/ccsm (+1/-1)
compizconfig/ccsm/setup.cfg (+2/-0)
compizconfig/ccsm/setup.py (+10/-10)
compizconfig/cmake/exec_setup_py_with_destdir.cmake (+2/-1)
compizconfig/compizconfig-python/CMakeLists.txt (+9/-30)
compizconfig/compizconfig-python/compizconfig-python.pc.in (+0/-13)
compizconfig/compizconfig-python/setup.py (+2/-3)
compizconfig/compizconfig-python/src/compizconfig.pyx (+4/-3)
compizconfig/compizconfig-python/tests/test_backend.py (+9/-9)
compizconfig/compizconfig-python/tests/test_plugin.py (+10/-10)
compizconfig/compizconfig-python/tests/test_setting.py (+14/-14)
debian/compizconfig-settings-manager.install (+1/-2)
debian/control (+14/-14)
debian/python-compizconfig.install (+0/-3)
debian/python-compizconfig.lintian-overrides (+0/-1)
debian/python3-compizconfig.install (+2/-0)
debian/rules (+1/-7)
~muktupavels/unity:master
Marco Trevisan (Treviño): Approve
Dmitry Shachnev: Pending requested
Diff: 891 lines (+59/-104)
47 files modified
debian/control (+10/-11)
debian/rules (+2/-2)
tests/autopilot/unity/emulators/X11.py (+1/-2)
tests/autopilot/unity/emulators/compiz.py (+0/-2)
tests/autopilot/unity/emulators/dash.py (+0/-1)
tests/autopilot/unity/emulators/hud.py (+2/-3)
tests/autopilot/unity/emulators/ibus.py (+1/-2)
tests/autopilot/unity/emulators/icons.py (+0/-1)
tests/autopilot/unity/emulators/launcher.py (+2/-3)
tests/autopilot/unity/emulators/panel.py (+2/-3)
tests/autopilot/unity/emulators/quicklist.py (+0/-1)
tests/autopilot/unity/emulators/screen.py (+0/-1)
tests/autopilot/unity/emulators/shortcut_hint.py (+0/-1)
tests/autopilot/unity/emulators/switcher.py (+1/-2)
tests/autopilot/unity/emulators/tooltip.py (+0/-1)
tests/autopilot/unity/emulators/unity.py (+0/-1)
tests/autopilot/unity/emulators/window_manager.py (+0/-1)
tests/autopilot/unity/emulators/workspace.py (+0/-1)
tests/autopilot/unity/tests/__init__.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_capture.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_icon_behavior.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_keynav.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_reveal.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_scroll.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_shortcut.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_switcher.py (+0/-1)
tests/autopilot/unity/tests/launcher/test_visual.py (+0/-1)
tests/autopilot/unity/tests/test_command_lens.py (+0/-1)
tests/autopilot/unity/tests/test_dash.py (+4/-5)
tests/autopilot/unity/tests/test_gnome_key_grabber.py (+1/-1)
tests/autopilot/unity/tests/test_gobject_introspection.py (+0/-1)
tests/autopilot/unity/tests/test_home_lens.py (+0/-1)
tests/autopilot/unity/tests/test_hud.py (+2/-3)
tests/autopilot/unity/tests/test_ibus.py (+12/-13)
tests/autopilot/unity/tests/test_panel.py (+0/-1)
tests/autopilot/unity/tests/test_quicklist.py (+0/-1)
tests/autopilot/unity/tests/test_search.py (+0/-1)
tests/autopilot/unity/tests/test_shopping_lens.py (+3/-4)
tests/autopilot/unity/tests/test_shortcut_hint.py (+0/-1)
tests/autopilot/unity/tests/test_showdesktop.py (+0/-1)
tests/autopilot/unity/tests/test_spread.py (+0/-1)
tests/autopilot/unity/tests/test_switcher.py (+0/-1)
tests/autopilot/unity/tests/test_unity_logging.py (+0/-2)
tests/autopilot/unity/tests/test_wm_keybindings.py (+0/-1)
tests/autopilot/unity/tests/xim/test_gcin.py (+3/-4)
tools/makebootchart.py (+5/-5)
tools/unity-introspection-visualiser.py (+8/-8)
Brandon Schaefer (brandontschaefer)
Changed in compiz:
status: New → Triaged
importance: Undecided → High
Changed in compiz (Ubuntu):
status: New → Triaged
importance: Undecided → High
Barry Warsaw (barry)
summary: - compizconfig-python needs to be ported to python3
+ python-compizconfig needs to be ported to python3
description: updated
Revision history for this message
Barry Warsaw (barry) wrote :

This is going to suck because of https://bugs.launchpad.net/compiz/+bug/1004592/comments/22

Barry Warsaw (barry)
Changed in compiz (Ubuntu):
status: Triaged → Won't Fix
Revision history for this message
Barry Warsaw (barry) wrote :

After further discussion, I think we won't take this on as it's a big pile of work. I'm happy to consult with the upstream compiz folks if they want to explore options.

What has been discussed is allowing unity7 autopilot tests to continue to depend on Python 2 python-compizconfig. Since unity7 isn't used on touch, this won't block our progress on the Python 3 migration there. We are likely going to split the autopilot source package during u-series, with an autopilot-legacy branch providing python-autopilot and friends (i.e. an unmaintained except for critical fixes, Python 2 support), with the trunk autopilot branch *only* providing Python 3 support. When unity7 is completely replaced by unity8 then everything will fall out naturally.

Dmitry Shachnev (mitya57)
Changed in compiz (Ubuntu):
status: Won't Fix → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.13.1+19.04.20190103-0ubuntu1

---------------
compiz (1:0.9.13.1+19.04.20190103-0ubuntu1) disco; urgency=medium

  [ Alberts Muktupāvels ]
  * Port CCSM to Python 3. (LP: #1004592, #1310794)

 -- Dmitry Shachnev <email address hidden> Thu, 03 Jan 2019 18:56:40 +0000

Changed in compiz (Ubuntu):
status: In Progress → Fix Released
Alberts Muktupāvels (muktupavels)
Changed in compiz:
status: Triaged → Fix Committed
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

@muktupavels

This seems to break unity login from unity-greeter on fresh install. I tried with sudo apt install unity unity-session on vm and it can't login, gives

invalid mit-magic-cookie-1 keycan't open display 0

Can you confirm ?

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Why do you think it’s broken by this change?

At login no Python code should be run, the core part of Compiz and Unity is C++.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Bcz, downgrading only these two packages (unity & compiz) fixes the issue. But I just now had a conversation with @muktupavels....may be unity/libunity needs a rebuild.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

And it doesn't work.

Alberts Muktupāvels (muktupavels)
Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.