[SRU] curl_json plugin is unable to check local files

Bug #615509 reported by Baptiste Mille-Mathias
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
collectd (Ubuntu)
Low
Unassigned
Lucid
Low
Unassigned

Bug Description

Binary package hint: collectd

when trying to access local files with curl based collectd plugins (like json), an error is created and the monitoring cannot be done.
The error in the daemon log is "curl_json plugin: curl_easy_perform failed with response code 0 (file:///var/foo/bar/file.json)"

A fix is available in collectd 4.9, and I think it would be nice to have it in lucid. The fix is http://git.verplant.org/?p=collectd.git;a=commitdiff;h=74ba45134a428c971bc9274b17e8d8bd210156e3

Changed in collectd (Ubuntu):
importance: Undecided → Low
status: New → Confirmed
milestone: none → lucid-updates
Changed in collectd (Ubuntu):
assignee: nobody → Baptiste Mille-Mathias (bmillemathias)
summary: - curl based plugins are unable to check local files
+ curl_json plugin is unable to check local files
Philip Muškovac (yofel)
tags: added: lucid
Revision history for this message
Baptiste Mille-Mathias (bmillemathias) wrote : Re: curl_json plugin is unable to check local files

TEST CASE:
Modify /etc/collectd/collectd.conf and add for instance:
<Plugin curl_json>
  <URL "file:///var/lib/transmission-daemon/info/stats.json">
    Instance "bittorrent"

    <Key "downloaded-bytes">
      Type "bt_bytes"
    </Key>

    <Key "uploaded-bytes">
      Type "bt_bytes"
    </Key>
  </URL>
</Plugin>

restart collectd

You'll see the error "curl_json plugin: curl_easy_perform failed with response code 0 (file:///var/lib/transmission-daemon/info/stats.json)" in the log file daemon.log
========================================

summary: - curl_json plugin is unable to check local files
+ [SRU] curl_json plugin is unable to check local files
Changed in collectd (Ubuntu):
assignee: Baptiste Mille-Mathias (bmillemathias) → nobody
milestone: lucid-updates → none
status: Confirmed → Fix Released
Changed in collectd (Ubuntu Lucid):
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Stefano Rivera (stefanor) wrote :

Baptiste: Can you please provide debdiffs in future, they are easier to read and work with.

> collectd (4.8.2-1ubuntu1) lucid; urgency=low

Can you use the version number scheme outlined here: https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update%20the%20packaging

and target it at lucid-proposed instead of lucid.

Otherwise, looks good.

Changed in collectd (Ubuntu Lucid):
status: Confirmed → Incomplete
Revision history for this message
Baptiste Mille-Mathias (bmillemathias) wrote :
Revision history for this message
Stefano Rivera (stefanor) wrote :

Uploaded to lucid-proposed, pending SRU Team approval

Changed in collectd (Ubuntu Lucid):
status: Incomplete → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted collectd into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Baptiste Mille-Mathias (bmillemathias) wrote :

Hi Martin

I tested the patch myself on a build I did on ppa for 2 weeks without any issue, I asked also on #collectd chan to test.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Lucid:
I have reproduced the problem with collectd 4.8.2-1 in lucid and have verified that the version of collectd 4.8.2-1ubuntu0.1 in -proposed fixes the issue.

Marking as verification-done

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package collectd - 4.8.2-1ubuntu0.1

---------------
collectd (4.8.2-1ubuntu0.1) lucid-proposed; urgency=low

  * debian/patch/lp615509_curl_json.dpatch:
    - permit check of local files with curl_json (LP: #615509)
 -- Baptiste Mille-Mathias <email address hidden> Tue, 24 Aug 2010 13:21:26 +0200

Changed in collectd (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers