[SRU] CMake imported targets GTest::gmock and GTest::gmock_main are not available
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cmake |
Fix Released
|
Unknown
|
|||
cmake (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned | ||
Kinetic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[ Test plan ]
cat CMakeLists.txt
project(foo)
cmake_minimum_
find_package(GTest)
with the patch, a cmake .. and libgmock-dev installed results in this:
grep mock . -Ri
./CMakeFiles/
./CMakeFiles/
[ Where problems could occur ]
* Nowhere, its an upstream patch that don't regress the current status quo, just adding some new variables.
[ Other Info ]
The libgtest-dev and libgmock-dev are both built from the googletest source package. Googletest upstream has provided a CMake **config file package** since version 1.8.1, but for many releases, this config file package has not been included in the -dev packages.
When developers build a CMake project that wants to use a prebuilt GoogleTest for testing, they typically call FindPackage(GTest <REQUIRED_VERSION>) to locate the library. Since the config file package has not been included in libgtest-dev, the FindPackage CMake call falls back to using the FindGTest.cmake module originating from cmake and included in the cmake-data package.
So for several releases up to and including jammy jellyfish, the Imported targets:
* GTest::gtest
* GTest::gtest_main
* GTest::gmock
* GTest::gmock_main
have not been available in the distribution provided packages although defined by Googletest upstream.
Issue in CMake issue tracker https:/
CMake Merge Request https:/
Issue in Debian CMake packaging https:/
This issue should already be fixed in kinetic, since the CMake version is 3.24, which includes the update to cmake's FindGTest.cmake module.
I would also like to get this to jammy as a low priority update. Applying only the patch to FindGTest.cmake should make the risk of the update negligible.
Changed in cmake: | |
status: | Unknown → Fix Released |
tags: |
added: verification-done verification-done-focal removed: verification-needed verification-needed-focal |
Hello can you please post a debdiff against the jammy version?