uec-publish-tarball should gracefully fail when run before eucarc is sourced

Bug #526504 reported by Thierry Carrez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-utils (Ubuntu)
Fix Released
Low
Scott Moser

Bug Description

Binary package hint: cloud-utils

I ran uec-publish-tarball without sourcing eucarc first, and it failed like this:

$ uec-publish-tarball lucid-server-uec-amd64.tar.gz lucid
mardi 23 février 2010, 15:37:44 (UTC+0100): ====== extracting image ======
Warning: no ramdisk found, assuming '--ramdisk none'
kernel : lucid-server-uec-amd64-vmlinuz-virtual
ramdisk: none
image : lucid-server-uec-amd64.img
mardi 23 février 2010, 15:37:53 (UTC+0100): ====== bundle/upload kernel ======
failed to check for existing manifest
failed to upload kernel
cleaning up /tmp/uec-publish-tarball.rE1z6O

Checking in pre-flight checks that the environment is available would probably be better and allow for some more informative error message.

Revision history for this message
Scott Moser (smoser) wrote :

is "Failed to check for existing manifest... Have you source eucarc?"
good enough for "graceful"?

Revision history for this message
Thierry Carrez (ttx) wrote :

Well, I was more thinking of something along those lines:

$ uec-publish-tarball lucid-server-uec-amd64.tar.gz lucid
UEC environment not set ! Have you sourced eucarc ?

I don't really see the point of extracting the image if we know by advance registration will fail ?

Revision history for this message
Scott Moser (smoser) wrote : Re: [Bug 526504] Re: uec-publish-tarball should gracefully fail when run before eucarc is sourced

On Tue, 23 Feb 2010, Thierry Carrez wrote:

> Well, I was more thinking of something along those lines:
>
> $ uec-publish-tarball lucid-server-uec-amd64.tar.gz lucid
> UEC environment not set ! Have you sourced eucarc ?
>
> I don't really see the point of extracting the image if we know by
> advance registration will fail ?

I'd like to avoid having to worry about configuration of a separate
utility. Ie, at the moment there are 2 ways in which euca2ools could get
its environment set up:
 - config file (~/.eucarc, /etc/eucarc)
 - environment files

Checking for those 2 things isn't impossible, but just want to avoid the
rabbit hole.

Revision history for this message
Thierry Carrez (ttx) wrote :

Understood. Then your proposal in comment #1 is probably graceful enough. Other solution, how about calling some euca2ools command early in the process to check that it's successful ? Like euca-describe-images ?

Revision history for this message
Scott Moser (smoser) wrote :

On Tue, 23 Feb 2010, Thierry Carrez wrote:

> Understood. Then your proposal in comment #1 is probably graceful
> enough. Other solution, how about calling some euca2ools command early
> in the process to check that it's successful ? Like euca-describe-images
> ?

Sold. I'll have it do that.

Revision history for this message
Scott Moser (smoser) wrote :

Fixing this with a check call to 'euca-describe-images' before extracting tarball.

Changed in cloud-utils (Ubuntu):
assignee: nobody → Scott Moser (smoser)
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-utils - 0.8-0ubuntu1

---------------
cloud-utils (0.8-0ubuntu1) lucid; urgency=low

  * uec-publish-image: return to using symbolic link for renaming
    (LP: #522292 is fixed)
  * uec-publish-tarball: fail before extracting tarball if environment
    is not set up for euca2ools (LP: #526504)
 -- Scott Moser <email address hidden> Mon, 01 Mar 2010 12:02:53 -0500

Changed in cloud-utils (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.