Bad variable use: FLOCK_DEVICE_FD != FLOCK_DISK_ID

Bug #1898533 reported by Paride Legovini
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-utils (Ubuntu)
Fix Released
High
Paride Legovini

Bug Description

As found by laney in a cloud-initramfs merge proposal,
FLOCK_DEVICE_FD != FLOCK_DISK_ID.

FLOCK_DEVICE_FD would never be set, so we would always
return from unlock_disk_and_settle and never either:
 * close the device
 * settle.

Revision history for this message
Paride Legovini (paride) wrote :
Changed in cloud-utils (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Paride Legovini (paride)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-utils - 0.31-29-ge0792e3d-0ubuntu1

---------------
cloud-utils (0.31-29-ge0792e3d-0ubuntu1) groovy; urgency=medium

  * New upstream snapshot.
    - Fix bad variable use. [Scott Moser] (LP: #1898533)
    Test/CI or cosmetic changes:
    - Use test/run-all under c-i. [Scott Moser] (LP: #1898533)
    - Add a 'tests/run-all' to easily run all the test/test* files.
      [Scott Moser]
    - tox: shellcheck: workaround false positives [Paride Legovini]
    - tox: add the test/* scripts to the shellcheck run [Paride Legovini]
    - Whitespace cleanups [Scott Moser]

 -- Paride Legovini <email address hidden> Mon, 05 Oct 2020 14:03:39 +0200

Changed in cloud-utils (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.