Activity log for bug #1835124

Date Who What changed Old value New value Message
2019-07-02 21:20:04 David Krauser bug added bug
2019-07-02 21:49:08 Joshua Powers bug added subscriber Joshua Powers
2019-07-04 01:55:17 Bryce Harrington bug task added cloud-utils
2019-07-08 18:49:41 Joshua Powers cloud-utils: status New Triaged
2019-07-08 18:49:43 Joshua Powers cloud-utils: importance Undecided High
2019-07-08 18:49:51 Joshua Powers tags server-next
2019-07-08 19:00:39 Rafael David Tinoco cloud-utils (Ubuntu): status New Confirmed
2019-07-08 19:00:53 Rafael David Tinoco cloud-utils (Ubuntu): status Confirmed Triaged
2019-07-08 19:00:56 Rafael David Tinoco cloud-utils: status Triaged Confirmed
2019-07-08 19:02:11 Rafael David Tinoco bug added subscriber Canonical Server Team
2019-07-08 19:19:52 Rafael David Tinoco cloud-utils (Ubuntu): importance Undecided Wishlist
2019-07-10 16:23:31 Launchpad Janitor merge proposal linked https://code.launchpad.net/~smoser/cloud-utils/+git/cloud-utils/+merge/369959
2019-07-10 17:05:28 Rafael David Tinoco cloud-utils (Ubuntu): importance Wishlist Low
2019-07-10 17:05:30 Rafael David Tinoco cloud-utils (Ubuntu): status Triaged In Progress
2019-07-10 17:05:57 Rafael David Tinoco cloud-utils (Ubuntu): assignee Scott Moser (smoser)
2019-07-10 18:01:13 Scott Moser cloud-utils: status Confirmed Fix Committed
2019-07-10 18:01:53 Scott Moser cloud-utils (Ubuntu): assignee Scott Moser (smoser)
2019-07-10 18:11:16 Scott Moser cloud-utils (Ubuntu): assignee Scott Moser (smoser)
2019-07-10 18:45:05 Rafael David Tinoco bug added subscriber Rafael David Tinoco
2019-07-14 03:31:08 Launchpad Janitor cloud-utils (Ubuntu): status In Progress Fix Released
2019-07-16 14:13:10 Rafael David Tinoco nominated for series Ubuntu Disco
2019-07-16 14:13:10 Rafael David Tinoco bug task added cloud-utils (Ubuntu Disco)
2019-07-16 14:17:04 Launchpad Janitor merge proposal linked https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/cloud-utils/+git/cloud-utils/+merge/370194
2019-07-16 18:02:51 Rafael David Tinoco cloud-utils (Ubuntu Disco): status New In Progress
2019-07-16 18:02:54 Rafael David Tinoco cloud-utils (Ubuntu Disco): assignee Rafael David Tinoco (rafaeldtinoco)
2019-07-16 18:02:56 Rafael David Tinoco cloud-utils (Ubuntu Disco): importance Undecided Low
2019-07-16 18:25:00 Rafael David Tinoco bug added subscriber Ubuntu Sponsors Team
2019-08-01 13:05:55 Rafael David Tinoco description When growpart attempts to determine the partition to resize, it uses this logic: $ sed -n '266,275p' $(which growpart) dpart="${DISK}${PART}" # disk and partition number if [ -b "${DISK}p${PART}" -a "${DISK%[0-9]}" != "${DISK}" ]; then # for block devices that end in a number (/dev/nbd0) # the partition is "<name>p<partition_number>" (/dev/nbd0p1) dpart="${DISK}p${PART}" elif [ "${DISK#/dev/loop[0-9]}" != "${DISK}" ]; then # for /dev/loop devices, sfdisk output will be <name>p<number> # format also, even though there is not a device there. dpart="${DISK}p${PART}" fi If the disk is an image, and the image filename ends with a number, the partition will be "${DISK}p${PART}"; however, "${DISK}p${PART}" will not be a block device. Thus, the partition is improperly identified as just "${DISK}${PART}". This gives us a failure like: + growpart -v -v -v disk-uefi.ext4 1 update-partition set to true resizing 1 on disk-uefi.ext4 using resize_sfdisk_gpt running[sfd_list][erronly] sfdisk --list --unit=S disk-uefi.ext4 6291456 sectors of 512. total size=3221225472 bytes running[sfd_dump][erronly] sfdisk --unit=S --dump disk-uefi.ext4 ## sfdisk --unit=S --dump disk-uefi.ext4 label: gpt label-id: A9F73A73-50FD-4335-9082-1249985F154D device: disk-uefi.ext4 unit: sectors first-lba: 34 last-lba: 6291422 disk-uefi.ext4p1 : start= 227328, size= 4384735, type=0FC63DAF-8483-4772-8E79-3D69D8477DE4, uuid=C1191CD2-0753-4A53-8CD4-E6079735CA42 disk-uefi.ext4p14 : start= 2048, size= 8192, type=21686148-6449-6E6F-744E-656564454649, uuid=3A2AD377-EB6D-4689-9126-35148C003A95 disk-uefi.ext4p15 : start= 10240, size= 217088, type=C12A7328-F81F-11D2-BA4B-00A0C93EC93B, uuid=98C675C8-4FF6-425C-B783-E77FDE70C967 FAILED: failed to get start and end for disk-uefi.ext41 in disk-uefi.ext4 [Impact] * DEP8 race condition for ppc64el (LP: #1836593): intermittent migration regressions. * growpart: fix bug when file image ends in a digit (LP: #1835124): image files can't end in ".ext4", for example, orelse growpart doesn't work. * fix spelling error in ec2metadata (LP: #1810857): no impact. [Test Case] (k)inaddy@kvirtclone:~$ sudo fdisk /fakedisk.ext4 (m for help): d Selected partition 1 Partition 1 has been deleted. Command (m for help): n Partition type p primary (0 primary, 0 extended, 4 free) e extended (container for logical partitions) Select (default p): p Partition number (1-4, default 1): First sector (2048-262143, default 2048): Last sector, +/-sectors or +/-size{K,M,G,T,P} (2048-262143, default 262143): +100mb Created a new partition 1 of type 'Linux' and of size 95 MiB. Command (m for help): w The partition table has been altered. Syncing disks. (k)inaddy@kvirtclone:~$ sudo growpart /fakedisk.ext4 1 FAILED: failed to get start and end for /fakedisk.ext41 in /fakedisk.ext4 [Regression Potential] * Fix tries to recognize if volume is a block device or not. Same code exists for block devices, which reduces probability of issues. * Fix was done by pkg maintainer and it is already upstreamed. [Other Info] * Original description: When growpart attempts to determine the partition to resize, it uses this logic: $ sed -n '266,275p' $(which growpart)         dpart="${DISK}${PART}" # disk and partition number         if [ -b "${DISK}p${PART}" -a "${DISK%[0-9]}" != "${DISK}" ]; then                 # for block devices that end in a number (/dev/nbd0)                 # the partition is "<name>p<partition_number>" (/dev/nbd0p1)                 dpart="${DISK}p${PART}"         elif [ "${DISK#/dev/loop[0-9]}" != "${DISK}" ]; then                 # for /dev/loop devices, sfdisk output will be <name>p<number>                 # format also, even though there is not a device there.                 dpart="${DISK}p${PART}"         fi If the disk is an image, and the image filename ends with a number, the partition will be "${DISK}p${PART}"; however, "${DISK}p${PART}" will not be a block device. Thus, the partition is improperly identified as just "${DISK}${PART}". This gives us a failure like: + growpart -v -v -v disk-uefi.ext4 1 update-partition set to true resizing 1 on disk-uefi.ext4 using resize_sfdisk_gpt running[sfd_list][erronly] sfdisk --list --unit=S disk-uefi.ext4 6291456 sectors of 512. total size=3221225472 bytes running[sfd_dump][erronly] sfdisk --unit=S --dump disk-uefi.ext4 ## sfdisk --unit=S --dump disk-uefi.ext4 label: gpt label-id: A9F73A73-50FD-4335-9082-1249985F154D device: disk-uefi.ext4 unit: sectors first-lba: 34 last-lba: 6291422 disk-uefi.ext4p1 : start= 227328, size= 4384735, type=0FC63DAF-8483-4772-8E79-3D69D8477DE4, uuid=C1191CD2-0753-4A53-8CD4-E6079735CA42 disk-uefi.ext4p14 : start= 2048, size= 8192, type=21686148-6449-6E6F-744E-656564454649, uuid=3A2AD377-EB6D-4689-9126-35148C003A95 disk-uefi.ext4p15 : start= 10240, size= 217088, type=C12A7328-F81F-11D2-BA4B-00A0C93EC93B, uuid=98C675C8-4FF6-425C-B783-E77FDE70C967 FAILED: failed to get start and end for disk-uefi.ext41 in disk-uefi.ext4
2019-09-02 15:16:12 Łukasz Zemczak cloud-utils (Ubuntu Disco): status In Progress Fix Committed
2019-09-02 15:16:14 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-09-02 15:16:16 Łukasz Zemczak bug added subscriber SRU Verification
2019-09-02 15:16:21 Łukasz Zemczak tags server-next server-next verification-needed verification-needed-disco
2019-09-04 14:53:03 Scott Moser description [Impact] * DEP8 race condition for ppc64el (LP: #1836593): intermittent migration regressions. * growpart: fix bug when file image ends in a digit (LP: #1835124): image files can't end in ".ext4", for example, orelse growpart doesn't work. * fix spelling error in ec2metadata (LP: #1810857): no impact. [Test Case] (k)inaddy@kvirtclone:~$ sudo fdisk /fakedisk.ext4 (m for help): d Selected partition 1 Partition 1 has been deleted. Command (m for help): n Partition type p primary (0 primary, 0 extended, 4 free) e extended (container for logical partitions) Select (default p): p Partition number (1-4, default 1): First sector (2048-262143, default 2048): Last sector, +/-sectors or +/-size{K,M,G,T,P} (2048-262143, default 262143): +100mb Created a new partition 1 of type 'Linux' and of size 95 MiB. Command (m for help): w The partition table has been altered. Syncing disks. (k)inaddy@kvirtclone:~$ sudo growpart /fakedisk.ext4 1 FAILED: failed to get start and end for /fakedisk.ext41 in /fakedisk.ext4 [Regression Potential] * Fix tries to recognize if volume is a block device or not. Same code exists for block devices, which reduces probability of issues. * Fix was done by pkg maintainer and it is already upstreamed. [Other Info] * Original description: When growpart attempts to determine the partition to resize, it uses this logic: $ sed -n '266,275p' $(which growpart)         dpart="${DISK}${PART}" # disk and partition number         if [ -b "${DISK}p${PART}" -a "${DISK%[0-9]}" != "${DISK}" ]; then                 # for block devices that end in a number (/dev/nbd0)                 # the partition is "<name>p<partition_number>" (/dev/nbd0p1)                 dpart="${DISK}p${PART}"         elif [ "${DISK#/dev/loop[0-9]}" != "${DISK}" ]; then                 # for /dev/loop devices, sfdisk output will be <name>p<number>                 # format also, even though there is not a device there.                 dpart="${DISK}p${PART}"         fi If the disk is an image, and the image filename ends with a number, the partition will be "${DISK}p${PART}"; however, "${DISK}p${PART}" will not be a block device. Thus, the partition is improperly identified as just "${DISK}${PART}". This gives us a failure like: + growpart -v -v -v disk-uefi.ext4 1 update-partition set to true resizing 1 on disk-uefi.ext4 using resize_sfdisk_gpt running[sfd_list][erronly] sfdisk --list --unit=S disk-uefi.ext4 6291456 sectors of 512. total size=3221225472 bytes running[sfd_dump][erronly] sfdisk --unit=S --dump disk-uefi.ext4 ## sfdisk --unit=S --dump disk-uefi.ext4 label: gpt label-id: A9F73A73-50FD-4335-9082-1249985F154D device: disk-uefi.ext4 unit: sectors first-lba: 34 last-lba: 6291422 disk-uefi.ext4p1 : start= 227328, size= 4384735, type=0FC63DAF-8483-4772-8E79-3D69D8477DE4, uuid=C1191CD2-0753-4A53-8CD4-E6079735CA42 disk-uefi.ext4p14 : start= 2048, size= 8192, type=21686148-6449-6E6F-744E-656564454649, uuid=3A2AD377-EB6D-4689-9126-35148C003A95 disk-uefi.ext4p15 : start= 10240, size= 217088, type=C12A7328-F81F-11D2-BA4B-00A0C93EC93B, uuid=98C675C8-4FF6-425C-B783-E77FDE70C967 FAILED: failed to get start and end for disk-uefi.ext41 in disk-uefi.ext4 [Impact]   * DEP8 race condition for ppc64el (LP: #1836593): intermittent migration regressions.   * growpart: fix bug when file image ends in a digit (LP: #1835124): image files can't end in ".ext4", for example, orelse growpart doesn't work.   * fix spelling error in ec2metadata (LP: #1810857): no impact. [Test Case] (k)inaddy@kvirtclone:~$ sudo fdisk /fakedisk.ext4 (m for help): d Selected partition 1 Partition 1 has been deleted. Command (m for help): n Partition type    p primary (0 primary, 0 extended, 4 free)    e extended (container for logical partitions) Select (default p): p Partition number (1-4, default 1): First sector (2048-262143, default 2048): Last sector, +/-sectors or +/-size{K,M,G,T,P} (2048-262143, default 262143): +100mb Created a new partition 1 of type 'Linux' and of size 95 MiB. Command (m for help): w The partition table has been altered. Syncing disks. (k)inaddy@kvirtclone:~$ sudo growpart /fakedisk.ext4 1 FAILED: failed to get start and end for /fakedisk.ext41 in /fakedisk.ext4 [Regression Potential]  * Fix tries to recognize if volume is a block device or not. Same code exists for block devices, which reduces probability of issues.  * Fix was done by pkg maintainer and it is already upstreamed. [Other Info] * Related Bugs: * bug 1842682: regression in test-growpart results in test fail device or resource busy  * Original description: When growpart attempts to determine the partition to resize, it uses this logic: $ sed -n '266,275p' $(which growpart)         dpart="${DISK}${PART}" # disk and partition number         if [ -b "${DISK}p${PART}" -a "${DISK%[0-9]}" != "${DISK}" ]; then                 # for block devices that end in a number (/dev/nbd0)                 # the partition is "<name>p<partition_number>" (/dev/nbd0p1)                 dpart="${DISK}p${PART}"         elif [ "${DISK#/dev/loop[0-9]}" != "${DISK}" ]; then                 # for /dev/loop devices, sfdisk output will be <name>p<number>                 # format also, even though there is not a device there.                 dpart="${DISK}p${PART}"         fi If the disk is an image, and the image filename ends with a number, the partition will be "${DISK}p${PART}"; however, "${DISK}p${PART}" will not be a block device. Thus, the partition is improperly identified as just "${DISK}${PART}". This gives us a failure like: + growpart -v -v -v disk-uefi.ext4 1 update-partition set to true resizing 1 on disk-uefi.ext4 using resize_sfdisk_gpt running[sfd_list][erronly] sfdisk --list --unit=S disk-uefi.ext4 6291456 sectors of 512. total size=3221225472 bytes running[sfd_dump][erronly] sfdisk --unit=S --dump disk-uefi.ext4 ## sfdisk --unit=S --dump disk-uefi.ext4 label: gpt label-id: A9F73A73-50FD-4335-9082-1249985F154D device: disk-uefi.ext4 unit: sectors first-lba: 34 last-lba: 6291422 disk-uefi.ext4p1 : start= 227328, size= 4384735, type=0FC63DAF-8483-4772-8E79-3D69D8477DE4, uuid=C1191CD2-0753-4A53-8CD4-E6079735CA42 disk-uefi.ext4p14 : start= 2048, size= 8192, type=21686148-6449-6E6F-744E-656564454649, uuid=3A2AD377-EB6D-4689-9126-35148C003A95 disk-uefi.ext4p15 : start= 10240, size= 217088, type=C12A7328-F81F-11D2-BA4B-00A0C93EC93B, uuid=98C675C8-4FF6-425C-B783-E77FDE70C967 FAILED: failed to get start and end for disk-uefi.ext41 in disk-uefi.ext4
2019-09-24 06:57:18 Rafael David Tinoco tags server-next verification-needed verification-needed-disco server-next verification-done verification-done-disco
2019-09-24 18:01:13 Brian Murray tags server-next verification-done verification-done-disco server-next verification-needed verification-needed-disco
2019-10-16 17:37:12 Rafael David Tinoco tags server-next verification-needed verification-needed-disco server-next verification-done verification-done-disco
2019-10-21 14:35:41 Launchpad Janitor cloud-utils (Ubuntu Disco): status Fix Committed Fix Released
2019-10-21 14:35:58 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2020-06-09 16:51:43 Robie Basak tags server-next verification-done verification-done-disco verification-done verification-done-disco
2020-07-15 10:51:24 Paride Legovini cloud-utils: status Fix Committed Fix Released