| 2022-12-08 15:51:24 |
James Falcon |
bug |
|
|
added bug |
| 2022-12-08 16:14:18 |
James Falcon |
description |
TODO |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 16:14:49 |
James Falcon |
nominated for series |
|
Ubuntu Focal |
|
| 2022-12-08 16:14:49 |
James Falcon |
bug task added |
|
cloud-init (Ubuntu Focal) |
|
| 2022-12-08 16:18:11 |
James Falcon |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
[Regression Potential]
It is possible some functionality added in version 10 of debhelper would no longer be available after this revert. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 16:20:34 |
Chad Smith |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
[Regression Potential]
It is possible some functionality added in version 10 of debhelper would no longer be available after this revert. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log should not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 16:20:49 |
Chad Smith |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log should not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 16:23:21 |
Chad Smith |
cloud-init (Ubuntu): status |
New |
In Progress |
|
| 2022-12-08 16:23:26 |
Chad Smith |
cloud-init (Ubuntu Focal): status |
New |
In Progress |
|
| 2022-12-08 16:29:44 |
Chad Smith |
summary |
cloud-init restarts after upgrade when it shouldn't |
cloud-init restarts after upgrade when it shouldn't, regenerating SSH host keys on Azure Focal |
|
| 2022-12-08 16:30:12 |
Chad Smith |
summary |
cloud-init restarts after upgrade when it shouldn't, regenerating SSH host keys on Azure Focal |
cloud-init restarts during package upgrade when it shouldn't, regenerating SSH host keys on Azure Focal |
|
| 2022-12-08 16:32:30 |
James Falcon |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Upstream PR: https://github.com/canonical/cloud-init/pull/1900/
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 16:54:32 |
James Falcon |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 17:06:24 |
James Falcon |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being removed.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 21:10:39 |
Chad Smith |
attachment added |
|
binary-control-tar-diff-of-deb-compat-10-vs-deb-compat-9 https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/+attachment/5635169/+files/binary-control-tar-diff-of-deb-compat-10-vs-deb-compat-9 |
|
| 2022-12-08 21:54:51 |
Steve Langasek |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5 first included in focal in version 22.3-13-g70ce6442-0ubuntu1~20.04.1, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 21:56:51 |
Steve Langasek |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5 first included in focal in version 22.3-13-g70ce6442-0ubuntu1~20.04.1, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5 first included in focal in version 22.3-13-g70ce6442-0ubuntu1~20.04.1, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4. The control.tar.gz when building with debhelper compat 9 vs 10 has been examined to ensure there are no other functional changes to the output besides the fix for this regression and this analysis is included in https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/comments/3.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 21:57:30 |
Steve Langasek |
cloud-init (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2022-12-08 21:57:32 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2022-12-08 21:57:33 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2022-12-08 21:57:36 |
Steve Langasek |
tags |
|
verification-needed verification-needed-focal |
|
| 2022-12-08 23:06:43 |
Haw Loeung |
bug |
|
|
added subscriber The Canonical Sysadmins |
| 2022-12-08 23:26:36 |
Chad Smith |
cloud-init (Ubuntu Focal): importance |
Undecided |
High |
|
| 2022-12-08 23:26:38 |
Chad Smith |
cloud-init (Ubuntu): importance |
Undecided |
High |
|
| 2022-12-08 23:40:19 |
Chad Smith |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5 first included in focal in version 22.3-13-g70ce6442-0ubuntu1~20.04.1, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4. The control.tar.gz when building with debhelper compat 9 vs 10 has been examined to ensure there are no other functional changes to the output besides the fix for this regression and this analysis is included in https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/comments/3.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5 first included in focal in version 22.3-13-g70ce6442-0ubuntu1~20.04.1, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4. The control.tar.gz when building with debhelper compat 9 vs 10 has been examined to ensure there are no other functional changes to the output besides the fix for this regression and this analysis is included in https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/comments/3.
Verification test script:
#!/bin/bash
echo "==== Focal Verification of https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159 ====
# Create upgrade to proposed script
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q;
apt-get install -qy cloud-init;
EOF
lxc launch ubuntu-daily:focal sru-f
echo "=== OLD version Before cloud-init upgrade"
lxc exec sru-f -- cloud-init -v
echo "=== Track number of boot events cloud-init saw before upgrade from 22.4.2"
lxc exec sru-f -- cloud-init analyze show
echo "=== OLD version postinst contains try-restart logic to restart cloud-init services"
grep try-restart /var/lib/dpkg/info/cloud-init.postinst
echo "=== Upgrade to -proposed version of cloud-init: ....20.04.2"
lxc file push setup_proposed.sh sru-f/
lxc exec sru-f -- bash /setup_proposed.sh
lxc exec sru-f -- cloud-init -v
echo "=== Number of boot events from cloud-init service restart should not have changed"
lxc exec sru-f -- cloud-init analyze show
echo "=== No new log messages indicating NEW version of cloud-init was restarted"
grep 22.4.2-0ubuntu0~20.04.2 /var/log/
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 23:57:50 |
Chad Smith |
description |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5 first included in focal in version 22.3-13-g70ce6442-0ubuntu1~20.04.1, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4. The control.tar.gz when building with debhelper compat 9 vs 10 has been examined to ensure there are no other functional changes to the output besides the fix for this regression and this analysis is included in https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/comments/3.
Verification test script:
#!/bin/bash
echo "==== Focal Verification of https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159 ====
# Create upgrade to proposed script
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q;
apt-get install -qy cloud-init;
EOF
lxc launch ubuntu-daily:focal sru-f
echo "=== OLD version Before cloud-init upgrade"
lxc exec sru-f -- cloud-init -v
echo "=== Track number of boot events cloud-init saw before upgrade from 22.4.2"
lxc exec sru-f -- cloud-init analyze show
echo "=== OLD version postinst contains try-restart logic to restart cloud-init services"
grep try-restart /var/lib/dpkg/info/cloud-init.postinst
echo "=== Upgrade to -proposed version of cloud-init: ....20.04.2"
lxc file push setup_proposed.sh sru-f/
lxc exec sru-f -- bash /setup_proposed.sh
lxc exec sru-f -- cloud-init -v
echo "=== Number of boot events from cloud-init service restart should not have changed"
lxc exec sru-f -- cloud-init analyze show
echo "=== No new log messages indicating NEW version of cloud-init was restarted"
grep 22.4.2-0ubuntu0~20.04.2 /var/log/
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
=== Begin SRU Template ===
[Impact]
In 0f6db8c5 first included in focal in version 22.3-13-g70ce6442-0ubuntu1~20.04.1, Build-Depends was changed from "debhelper (>= 9.20160709)" to "debhelper-compat (= 10)". This is causing cloud-init to erroneously have a restart section in the post-install script:
# Automatically added by dh_systemd_start/12.10ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
deb-systemd-invoke try-restart 'cloud-config.service' 'cloud-config.target' 'cloud-final.service' 'cloud-init-hotplugd.service' 'cloud-init-hotplugd.socket' 'cloud-init-local.service' 'cloud-init.service' 'cloud-init.target' >/dev/null || true
fi
fi
fi
This script makes cloud-init restart on upgrade with services running interleaved and out of order. On older Azure instances, this creates a race on upgrade that can lead to ssh host keys being replaced.
[Test Case]
1.
- Launch a focal instance
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init services
- Ensure /var/log/cloud-init.log contains no logs of cloud-init services running interleaved or out of order
2.
- Upgrade a focal instance from pre-22.3 to the latest version
- Ensure /var/lib/dpkg/info/cloud-init.postinst does not contain a section restarting cloud-init
- Ensure /var/log/cloud-init.log and /var/log/cloud-init-output.log do not contain any logs with the upgraded package version referencd 22.4.2-0ubuntu0~20.04.2 as that would indicate cloud-init serviers were restarted
Verification Test script
#!/bin/bash
set -ex
echo ==== Focal Verification of https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159 ====
# Create upgrade to proposed script
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q;
apt-get install -qy cloud-init;
EOF
lxc launch ubuntu-daily:focal sru-f
while ! lxc exec sru-f -- cloud-init status --wait --long; do
sleep 5
done
echo "=== OLD version Before cloud-init upgrade"
lxc exec sru-f -- cloud-init -v
echo "=== Track number of boot events cloud-init saw before upgrade from 22.4.2"
BOOT_RECORDS=$(lxc exec sru-f -- cloud-init analyze show | grep 'boot record')
echo "=== OLD version postinst contains try-restart logic to restart cloud-init services"
lxc exec sru-f grep try-restart /var/lib/dpkg/info/cloud-init.postinst && echo SUCCESS: OLD version still restarts services || echo FAILURE: OLD version does not try-restart cloud-init services
echo "=== Upgrade to -proposed version of cloud-init: ....20.04.2"
lxc file push setup_proposed.sh sru-f/
lxc exec sru-f -- bash /setup_proposed.sh
lxc exec sru-f -- cloud-init -v
echo "=== Number of boot events from cloud-init service restart should not have changed"
NEW_BOOT_RECORDS=$(lxc exec sru-f -- cloud-init analyze show | grep 'boot record')
if [ "$BOOT_RECORDS" == "$NEW_BOOT_RECORDS" ]; then
echo SUCCESS same number of boot records across upgrade
else
echo FAILURE: different boot records seen across upgrade $NEW_BOOT_RECORDS
fi
echo "=== NEW version postinst does NOT contain try-restart logic for cloud-init services"
lxc exec sru-f grep try-restart /var/lib/dpkg/info/cloud-init.postinst && echo FAILURE: NEW version still restarts services || echo SUCCESS: NEW version does not try-restart cloud-init services
echo === No new log messages indicating NEW version of cloud-init was restarted
lxc exec sru-f grep 22.4.2-0ubuntu0~20.04.2 /var/log/cloud-init-output.log && echo SUCCESS: not service restarts across upgrade || echo FAILURE: found service restarts across upgrade
[Regression Potential]
It is possible some functionality added in version 10 of debhelper is no longer available. Since this change was made in version 22.3 of cloud-init, this would be limited to focal versions of cloud-init 22.3 and 22.4. The control.tar.gz when building with debhelper compat 9 vs 10 has been examined to ensure there are no other functional changes to the output besides the fix for this regression and this analysis is included in https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/comments/3.
[Other Info]
PR with change: https://github.com/canonical/cloud-init/pull/1900
Potentially related debhelper bug: https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054
=== End SRU Template === |
|
| 2022-12-08 23:58:46 |
Chad Smith |
attachment added |
|
sru-verification-lp-1999159.sh https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/+attachment/5635190/+files/sru-verification-lp-1999159.sh |
|
| 2022-12-09 00:01:13 |
Chad Smith |
attachment removed |
sru-verification-lp-1999159.sh https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/+attachment/5635190/+files/sru-verification-lp-1999159.sh |
|
|
| 2022-12-09 00:01:41 |
Chad Smith |
attachment added |
|
sru-verification-lp-1999159.sh https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1999159/+attachment/5635191/+files/sru-verification-lp-1999159.sh |
|
| 2022-12-09 00:04:58 |
Chad Smith |
tags |
verification-needed verification-needed-focal |
verification-done verification-done-focal |
|
| 2022-12-12 20:22:38 |
Launchpad Janitor |
cloud-init (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-12-12 20:22:42 |
Steve Langasek |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2023-02-02 16:10:00 |
Chad Smith |
cloud-init (Ubuntu): status |
In Progress |
Fix Released |
|
