[SRU] Support for CloudStack's basic networking in Precise

[Vincent Bernat]

SRU Justification

** SRU for 12.04 only **

[IMPACT] Users of a CloudStack platform using basic networking are unable to retrieve user data because they query the default gateway instead of the virtual router. With basic networking, the default gateway is not the virtual router (it could be any router). Without user data, the VM is left unconfigured without any SSH key to login.

[TEST CASE]
1. Spawn an Ubuntu Precise VM.
2. Install the fixed .deb.
3. rm /var/lib/cloud
4. reboot
5. Check userdata is now correctly retrieved (in /var/lib/cloud/instances*/cloud-config.txt)

[REGRESSION POTENTIAL]
 - Inexistant for non CloudStack source.
 - Need testing for CloudStack with advanced networking.
 - Only a backport of what is already working fine in Trusty.

[ORIGINAL REPORT]
cloud-init in Precise is unable to handle CloudStack because it tries to query the default gateway instead of the virtual router. This is fixed in later versions of cloud-init but it would be convenient to backport the fix in the precise-updates. Attached is a patch fixing that. Tested with CloudStack 4.3 and works fine.

[Vincent Bernat (vbernat)]

Hey!

I see that there has been some updates to cloud-init in Precise but this change was not even considered. Without this change, this data source cannot work when CloudStack is configured with basic networking (in this case, the virtual router is not the gateway). What should be done for this bug report to be considered?

[Vincent Bernat (vbernat)]

Here is an updated patch. Please consider it for the next release. It has been tested on a Cloudstack setup running with basic networking. It is extracted from what currently is in cloud-init.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "lp-1382481-cloudstack-vr.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Dan Watkins (oddbloke)]

We currently have advanced networking working in precise with a partner, so I think this is specifically about basic networking; I've updated the title of the bug to match my understanding.

[Vincent Bernat (vbernat)]

Yes, that's correct. It doesn't affect advanced networking where the vrouter is the default gateway (hence its name).

[Ben Howard (darkmuggle-deactivatedaccount)]

Hi Vincent -- thanks for helping. I would be happy to include this patch as part of the next SRU, but since we don't have a CloudStack to test this on, we would need your help on putting this through the SRU process. If you can apply the patch and the SRU'ify this bug, I'll be happy to sponsor it (and that way you get the credit).

[Vincent Bernat (vbernat)]

Hi Ben!

I am already using this patch. I can prepare a package with it, test it and provide a debdiff (if that's what you mean with "SRU'ify"). I am unable to test if that still works with advanced networking. Would somebody be able to do that?

[Ben Howard (darkmuggle-deactivatedaccount)]

Hi Vincent, if you can provide a debdiff and then add test case (see Bug
#1292648) as an example, it would be great. Once the package is accepted
for for SRU, you would need follow the test case and mark it as
"verification-done".

[Vincent Bernat (vbernat)]

Proposed fix for this issue.

[Vincent Bernat (vbernat)]

Hi Ben!

All done. Note that I tagged with verification-done but this should also be checked to work with advanced networking (I am pretty sure that won't be a problem, this is just a backport).

The test case may be difficult to execute in real conditions: with the "current" VM images, you won't be able to login after boot (both accounts will get a random password and you won't get your SSH keys setup). So, either you need some patched VM images or you need to change root password from Grub. However, as a non-regression test, it is perfectly valid.

[Ben Howard (darkmuggle-deactivatedaccount)]

Hi Vincent, I've submitted an upload for -proposed along with another fix. Once the fix lands in -proposed, can you please complete the verification steps?

[Vincent Bernat (vbernat)]

Yes, sure, I'll do it.

[Stéphane Graber (stgraber)]

Hello Vincent, or anyone else affected,

Accepted cloud-init into precise-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.6.3-0ubuntu1.22 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Vincent Bernat (vbernat)]

0.6.3-0ubuntu1.22 works fine for me (tested on CloudStack with basic networking enabled).

[Launchpad Janitor (janitor)]

This bug was fixed in the package cloud-init - 0.6.3-0ubuntu1.22

---------------
cloud-init (0.6.3-0ubuntu1.22) precise; urgency=medium

  * debian/patches/lp-1458052-redact-azure-password.patch:
     - redact plain text password in /var/lib/waagent/ovf.xml (LP: #1458052).

  [ Vincent Bernat ]
  * debian/patches/lp-1382481-cloudstack-vr.patch:
     - support CloudStack's basic networking (LP: #1382481).

 -- Ben Howard <email address hidden> Thu, 17 Sep 2015 12:57:16 -0600

[Stéphane Graber (stgraber)]

The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.