[SRU][FFe] CloudSigma Datasource doesn't handle vendor-data correctly

Bug #1303986 reported by Viktor Petersson on 2014-04-07
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Undecided
Unassigned
cloud-init (Ubuntu)
Medium
Ben Howard
Trusty
Medium
Ben Howard

Bug Description

SRU Justificaton:
This SRU fulfills the FFE exception granted.

Cloud Sigma has asked that we update the DataSource in Cloud-init to support the 14.04 VendorData construct. The regression potential for this change is low, as only the cloud-init Cloud-Sigma datasource is changed, a test suite has been provided and it has been tested by Cloud Sigma.

The reason for this late-in-the-cylce change is so that Cloud Sigma can have use the official Ubuntu Images with out conflating user and vendor-data. Currently Cloud Sigma uses the user-data channel improperly for transmitting vendor specific information to Cloud-init, when they should be using the vendor-data channel. By switching to the proper channel for vendor specific information, user-data and vendor-data will not be mangled, preventing collisions of user-data and vendor-specific data.

[ORIGINAL BUG REPORT]
It appears as the CloudSigma datasource only has support for 'user-data', and not 'vendor-data.'

Related branches

information type: Public → Public Security
information type: Public Security → Private Security
information type: Private Security → Public
Ben Howard (darkmuggle) on 2014-04-11
summary: - CloudSigma Datasource doesn't handle vendor-data correctly
+ [FFe] CloudSigma Datasource doesn't handle vendor-data correctly
Changed in cloud-init:
assignee: nobody → Ben Howard (utlemming)
description: updated
affects: cloud-init → cloud-init (Ubuntu)
Changed in cloud-init (Ubuntu):
assignee: Ben Howard (utlemming) → nobody

Attached patch showing that changes only affect the Cloud Sigma DS.

Changed in cloud-init (Ubuntu):
assignee: nobody → Ben Howard (utlemming)
Ben Howard (darkmuggle) on 2014-04-11
description: updated
Adam Conrad (adconrad) wrote :

If this is well tested, the change looks small and sane enough to me. Go for it.

Stéphane Graber (stgraber) wrote :

The change is small and looks reasonable to me, so FFe granted. However we are in final freeze, so you'll need to justify why we need this now rather than post-release as a SRU.

Changed in cloud-init (Ubuntu):
status: New → Triaged
Scott Moser (smoser) on 2014-04-15
Changed in cloud-init (Ubuntu Trusty):
importance: Undecided → Medium
Ben Howard (darkmuggle) wrote :
description: updated
summary: - [FFe] CloudSigma Datasource doesn't handle vendor-data correctly
+ [SRU][FFe] CloudSigma Datasource doesn't handle vendor-data correctly
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-init - 0.7.6~bzr976-0ubuntu1

---------------
cloud-init (0.7.6~bzr976-0ubuntu1) utopic; urgency=medium

  * debian/cloud-init.templates: fix choices so dpkg-reconfigure works as
    expected (LP: #1325746)
  * New upstream snapshot.
    * tests: SmartOS test not depend on /dev/ttyS1 device node (LP: #1316597)
    * poll ttyS1 only after check for 'cloudsigma' in dmidecode (LP: #1316475)
    * cloudsigma: support vendor-data (LP: #1303986)
 -- Scott Moser <email address hidden> Tue, 03 Jun 2014 16:41:07 -0400

Changed in cloud-init (Ubuntu):
status: Triaged → Fix Released
Ben Howard (darkmuggle) on 2014-06-20
Changed in cloud-init (Ubuntu Trusty):
status: Triaged → Fix Committed

Hello Viktor, or anyone else affected,

Accepted cloud-init into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/cloud-init/0.7.5-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
John Agosta (jagosta) wrote :

Chris:
I spoke with Viktor today and requested his team test and provide results here.

Viktor Petersson (vpetersson) wrote :

I will be looking over this together with Kiril.

Viktor Petersson (vpetersson) wrote :

The RC appears to be broken on our cloud. It simply doesn't pick up on our data source anymore.

Here's how I tested it:

 * I fetched the latest image[1] and converted it to RAW (cloud requirement).
 * I uploaded the image and made sure that it booted properly and that the CloudInit data was detected (it was).
 * I loop-mounted and chroot'd into the RAW image and installed the updated binary package[2].
 * I then uploaded the modified image and booted off of it. The CloudInit data was no longer detected.

[1] http://cloud-images.ubuntu.com/trusty/current/trusty-server-cloudimg-amd64-disk1.img
[2] https://launchpad.net/ubuntu/+source/cloud-init/0.7.5-0ubuntu1.1/+build/6126829/+files/cloud-init_0.7.5-0ubuntu1.1_all.deb

Chris J Arges (arges) on 2014-07-14
tags: added: verification-failed
removed: verification-needed
John Agosta (jagosta) wrote :

Hi Viktor:

1) Are you testing with your "new" cloud? Kiril has stated your "new cloud" would have this dmi info in the instances. We did explicitly break (with agreement from Kiril) the datasource on something without that dmi info. Our understanding is the new cloud would have 'cloudsigma' as the value returned by 'dmi-decode -s system-product-name'. See code changes in https://code.launchpad.net/~kiril-vladimiroff/cloud-init/cloudsigma-smbios-data-check/+merge/221524

2) If you are using your "new cloud" them could you provide /var/log/cloud-init* from a instance after [failed] boot

Scott Moser (smoser) on 2014-07-14
tags: added: verification-needed
removed: verification-failed
Viktor Petersson (vpetersson) wrote :

@jagosta, well this is a bit embarrassing. It looks like we messed up on our end.

We did roll the required change, but there was a human error, so currently we set 'system-vendor' instead of 'system-product-name'.

We're going to roll out a fix for this, but it won't be live until ~Monday.

Viktor Petersson (vpetersson) wrote :

Just an update: We're now rolled this update out on one of our location (WDC) and confirmed that it does in fact work.

$ sudo dpkg -l cloud-init
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-=============================================-===========================-===========================-===============================================================================================
ii cloud-init 0.7.5-0ubuntu1.1 all Init scripts for cloud instances

$ sudo dmidecode -s system-product-name
CloudSigma

Scott Moser (smoser) wrote :

marked verification done based on above comment.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-init - 0.7.5-0ubuntu1.1

---------------
cloud-init (0.7.5-0ubuntu1.1) trusty-proposed; urgency=medium

  [ Ben Howard ]
  * debian/patches/lp1316475-1303986-cloudsigma.patch: Backport of
    CloudSigma Datasource from 14.10
    - [FFe] Support VendorData for CloudSigma (LP: #1303986).
    - Only query /dev/ttys1 when CloudSigma is detected (LP: #1316475).

  [ Scott Moser ]
  * debian/cloud-init.templates: fix choices so dpkg-reconfigure works as
    expected (LP: #1325746)
 -- Scott Moser <email address hidden> Fri, 20 Jun 2014 13:29:29 -0400

Changed in cloud-init (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Scott Moser (smoser) wrote :

fix-released in 0.7.6

Changed in cloud-init:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers