Break the conflicts with click the optparser
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| click (Ubuntu) |
Undecided
|
Sergio Schvezov | ||
| Xenial |
Undecided
|
Unassigned | ||
| Yakkety |
Undecided
|
Unassigned | ||
| Zesty |
Undecided
|
Unassigned | ||
| Artful |
Undecided
|
Sergio Schvezov |
Bug Description
[Impact]
* python-click and python-
python package for its implementation.
* Since python-
package and python3-click is a package meant to be used in other
implementations it makes sense to break the conflict by moving the
package name for python-
* snapcraft has moved from docopt to python3-click, users that have click
installed don't have an upgrade path.his bug.
[Test Case]
* Where snapcraft 2.30 is present:
- apt install click
- Install snapcraft << 2.30
- update to snapcraft >= 2.30
- the upgrade should not be held on any package.
- click and snapcraft commands should work.
* Install python3-click and click should be possible. The click command
should keep working and python3 -c 'from click import group' shall work.
[Regression Potential]
* Users depending on click from python-
unexpected click in any scripts they may have.
[Other Info]
* While unfortunate, click as a technology is deprecated and not used
anymore. This resolution path was discussed with slangasek and apw prior
to any work.
Related branches
- Colin Watson: Approve on 2017-06-01
-
Diff: 799 lines (+100/-93)41 files modified.bzrignore (+4/-4)
Makefile.am (+1/-1)
bin/click (+2/-2)
click_package/build.py (+5/-5)
click_package/commands/__init__.py (+1/-1)
click_package/commands/build.py (+1/-1)
click_package/commands/buildsource.py (+1/-1)
click_package/commands/chroot.py (+2/-2)
click_package/commands/desktophook.py (+1/-1)
click_package/commands/info.py (+2/-2)
click_package/commands/install.py (+1/-1)
click_package/commands/list.py (+1/-1)
click_package/commands/verify.py (+1/-1)
click_package/framework.py (+2/-2)
click_package/install.py (+4/-4)
click_package/tests/__init__.py (+1/-1)
click_package/tests/gimock.py (+3/-3)
click_package/tests/gimock_types.py (+1/-1)
click_package/tests/helpers.py (+2/-2)
click_package/tests/integration/test_signatures.py (+1/-1)
click_package/tests/integration/test_verify.py (+3/-2)
click_package/tests/test_arfile.py (+3/-3)
click_package/tests/test_build.py (+4/-4)
click_package/tests/test_chroot.py (+3/-3)
click_package/tests/test_database.py (+4/-4)
click_package/tests/test_framework.py (+2/-2)
click_package/tests/test_hooks.py (+3/-3)
click_package/tests/test_install.py (+10/-10)
click_package/tests/test_osextras.py (+3/-3)
click_package/tests/test_paths.py.in (+1/-1)
click_package/tests/test_query.py (+2/-2)
click_package/tests/test_scripts.py (+1/-1)
click_package/tests/test_static.py (+2/-2)
click_package/tests/test_user.py (+4/-4)
configure.ac (+3/-3)
debian/changelog (+7/-0)
debian/control (+0/-1)
debian/tests/run-tests.sh (+1/-1)
doc/index.rst (+3/-3)
setup.py.in (+2/-2)
tox.ini (+2/-2)
- Colin Watson: Approve on 2017-06-13
-
Diff: 786 lines (+99/-92)40 files modified.bzrignore (+4/-4)
Makefile.am (+1/-1)
bin/click (+2/-2)
click_package/build.py (+5/-5)
click_package/commands/__init__.py (+1/-1)
click_package/commands/build.py (+1/-1)
click_package/commands/buildsource.py (+1/-1)
click_package/commands/chroot.py (+2/-2)
click_package/commands/desktophook.py (+1/-1)
click_package/commands/info.py (+2/-2)
click_package/commands/install.py (+1/-1)
click_package/commands/list.py (+1/-1)
click_package/commands/verify.py (+1/-1)
click_package/framework.py (+2/-2)
click_package/install.py (+4/-4)
click_package/tests/__init__.py (+1/-1)
click_package/tests/gimock.py (+3/-3)
click_package/tests/gimock_types.py (+1/-1)
click_package/tests/helpers.py (+2/-2)
click_package/tests/integration/test_verify.py (+3/-2)
click_package/tests/test_arfile.py (+3/-3)
click_package/tests/test_build.py (+4/-4)
click_package/tests/test_chroot.py (+3/-3)
click_package/tests/test_database.py (+4/-4)
click_package/tests/test_framework.py (+2/-2)
click_package/tests/test_hooks.py (+3/-3)
click_package/tests/test_install.py (+10/-10)
click_package/tests/test_osextras.py (+3/-3)
click_package/tests/test_paths.py.in (+1/-1)
click_package/tests/test_query.py (+2/-2)
click_package/tests/test_scripts.py (+1/-1)
click_package/tests/test_static.py (+2/-2)
click_package/tests/test_user.py (+4/-4)
configure.ac (+3/-3)
debian/changelog (+7/-0)
debian/control (+0/-1)
debian/tests/run-tests.sh (+1/-1)
doc/index.rst (+3/-3)
setup.py.in (+2/-2)
tox.ini (+2/-2)
description: | updated |
Sergio Schvezov (sergiusens) wrote : | #1 |
Launchpad Janitor (janitor) wrote : | #2 |
This bug was fixed in the package click - 0.4.46+
---------------
click (0.4.46+
* Rename the python package this installs from click to click_package.
(LP: #1693226)
* Use the correct overlayfs module name for the chroot configuration.
(LP: #1696402)
-- Sergio Schvezov <email address hidden> Wed, 07 Jun 2017 18:53:16 +0000
Changed in click (Ubuntu): | |
status: | New → Fix Released |
Leo Arias (elopio) wrote : | #3 |
I ran the test cases documented in this bug using an artful lxc container.
Everything works as expected.
Brian Murray (brian-murray) wrote : | #4 |
I sponsored the click packages from https:/
I did not upload the Xenial package because it is an upgrade from 0.4.43 to 0.4.46 and I think that bears some further discussion.
Leo Arias (elopio) wrote : | #5 |
I ran the test cases documented in this bug using a xenial container and the bileto PPA: https:/
Everything works as expected.
An upload of click to xenial-proposed has been rejected from the upload queue for the following reason: "Sadly, this package has more than the bugfix for this particular bug - there is a 21k diff in overall which rather implies a new upstream version. This needs to be documented in the changelog. Please re-upload with the changelog modified (and possibly a new SRU bug opened for the backport).".
Hello Sergio, or anyone else affected,
Accepted click into zesty-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-
Further information regarding the verification process can be found at https:/
Changed in click (Ubuntu Zesty): | |
status: | New → Fix Committed |
tags: | added: verification-needed |
Changed in click (Ubuntu Xenial): | |
status: | New → Fix Committed |
Łukasz Zemczak (sil2100) wrote : | #8 |
Hello Sergio, or anyone else affected,
Accepted click into xenial-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-
Further information regarding the verification process can be found at https:/
Changed in click (Ubuntu Yakkety): | |
status: | New → Fix Committed |
Łukasz Zemczak (sil2100) wrote : | #9 |
Hello Sergio, or anyone else affected,
Accepted click into yakkety-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-
Further information regarding the verification process can be found at https:/
Łukasz Zemczak (sil2100) wrote : | #10 |
On re-evaluation, I have decided to accept the xenial upload - mostly because click is anyway a deprecated technology.
Leo Arias (elopio) wrote : | #11 |
We tested this in xenial, yakkety and zesty proposed, together with snapcraft for bug #1692102.
No issues found with the rename of the package, and now snapcraft can be updated without problems.
I've just marked this as verified.
tags: |
added: verification-done removed: verification-needed |
Launchpad Janitor (janitor) wrote : | #12 |
This bug was fixed in the package click - 0.4.46+
---------------
click (0.4.46+
* Rename the python package this installs from click to click_package.
(LP: #1693226)
* Use the correct overlayfs module name for the chroot configuration.
(LP: #1696402)
-- Sergio Schvezov <email address hidden> Wed, 07 Jun 2017 18:53:16 +0000
Changed in click (Ubuntu Zesty): | |
status: | Fix Committed → Fix Released |
The verification of the Stable Release Update for click has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.
Launchpad Janitor (janitor) wrote : | #14 |
This bug was fixed in the package click - 0.4.46+
---------------
click (0.4.46+
* Rename the python package this installs from click to click_package.
(LP: #1693226)
* Use the correct overlayfs module name for the chroot configuration.
(LP: #1696402)
-- Sergio Schvezov <email address hidden> Wed, 07 Jun 2017 18:53:16 +0000
Changed in click (Ubuntu Yakkety): | |
status: | Fix Committed → Fix Released |
Launchpad Janitor (janitor) wrote : | #15 |
This bug was fixed in the package click - 0.4.43+
---------------
click (0.4.43+
* Rename the python package this installs from click to click_package.
(LP: #1693226)
-- Kyle Fazzari <email address hidden> Tue, 13 Jun 2017 17:14:46 +0000
Changed in click (Ubuntu Xenial): | |
status: | Fix Committed → Fix Released |
the_dark_knight (bharatdarapu) wrote : | #16 |
I get the following error for sudo apt-get -f install
Preparing to unpack .../click_
Traceback (most recent call last):
File "/usr/bin/click", line 37, in <module>
import click
ImportError: No module named 'click'
dpkg: warning: subprocess old pre-removal script returned error exit status 1
dpkg: trying script from the new package instead ...
Traceback (most recent call last):
File "/usr/bin/click", line 37, in <module>
import click
ImportError: No module named 'click'
dpkg: error processing archive /var/cache/
subprocess new pre-removal script returned error exit status 1
Job for click-system-
See "systemctl status click-system-
click-system-
Errors were encountered while processing:
/var/cache/
E: Sub-process /usr/bin/dpkg returned an error code (1)
I installed python click with sudo pip3 install click and tried running sudo apt-get -f install
Preparing to unpack .../click_
Traceback (most recent call last):
File "/usr/bin/click", line 55, in <module>
from click import commands
ImportError: cannot import name 'commands'
dpkg: warning: subprocess old pre-removal script returned error exit status 1
dpkg: trying script from the new package instead ...
Traceback (most recent call last):
File "/usr/bin/click", line 55, in <module>
from click import commands
ImportError: cannot import name 'commands'
dpkg: error processing archive /var/cache/
subprocess new pre-removal script returned error exit status 1
Job for click-system-
See "systemctl status click-system-
click-system-
Errors were encountered while processing:
/var/cache/
E: Sub-process /usr/bin/dpkg returned an error code (1)
nimbosa (darth-serious) wrote : | #17 |
on Ubuntu Xenial this still gives this error:
```
Traceback (most recent call last):
File "/usr/bin/click", line 37, in <module>
import click_package as click
ImportError: No module named 'click_package'
dpkg: warning: subprocess old pre-removal script returned error exit status 1
dpkg: trying script from the new package instead ...
Traceback (most recent call last):
File "/usr/bin/click", line 37, in <module>
import click_package as click
ImportError: No module named 'click_package'
dpkg: error processing archive /var/cache/
subprocess new pre-removal script returned error exit status 1
```
i did a little experiment:
`sudo apt update && sudo apt install python3-
then reinstalling:
`sudo apt install click click-apparmor --reinstall --force-yes`
fixes this now on Xenial Xerus
I did some preemptive testing with ppa:ci- train-ppa- service/ ubuntu/ 2790 (https:/ /bileto. ubuntu. com/#/ticket/ 2790) which should land in artful:
root@artful:/# dpkg -l snapcraft Unknown/ Install/ Remove/ Purge/Hold Not/Inst/ Conf-files/ Unpacked/ halF-conf/ Half-inst/ trig-aWait/ Trig-pend /Reinst- required (Status,Err: uppercase=bad) ======= ====-== ======= ===-=== ======= ==-==== ======= ======= ======= ======= = Unknown/ Install/ Remove/ Purge/Hold Not/Inst/ Conf-files/ Unpacked/ halF-conf/ Half-inst/ trig-aWait/ Trig-pend /Reinst- required (Status,Err: uppercase=bad) ======= ====-== ======= ===-=== ======= ==-==== ======= ======= ======= ======= =
Desired=
| Status=
|/ Err?=(none)
||/ Name Version Architecture Description
+++-===
ii snapcraft 2.30.1+17.10 all easily craft snaps
root@artful:/# dpkg -l click
Desired=
| Status=
|/ Err?=(none)
||/ Name Version Architecture Description
+++-===
ii click 0.4.46+17.10 amd64 Click packages
root@artful:/# snapcraft --help
Usage: snapcraft [OPTIONS] COMMAND [ARGS]...
Snapcraft is a delightful packaging tool.
Options:
-d, --debug
--help Show this message and exit.
Commands: integration systems to...
build Build artifacts defined for a part.
clean Remove content - cleans downloads, builds or...
cleanbuild Create a snap using a clean environment...
close Close <channel> for <snap-name>.
create-key Create a key to sign assertions.
define Shows the definition for the cloud part.
enable-ci Enable continuous-
gated Get the list of snaps and revisions gating a...
help Obtain help for a certain plugin or topic.
init Initialize a snapcraft project.
list-keys List the keys available to sign assertions.
list-plugins List the available plugins that handle...
list-registered List snap names registered or shared with...
list-revisions Get the history on the store for <snap-name>.
login Authenticate session against Ubuntu One SSO.
logout Clear session credentials.
prime Final copy and preparation for the snap.
pull Download or retrieve artifacts defined for a...
push Push <snap-file> to the store.
register Register <snap-name> with the store.
register-key Register a key with the store to sign...
release Release <snap-name> on <revision> to the...
search Searches the remote parts cache for matching...
sign-build Sign a built snap file and assert it using...
snap Create a snap.
stage Stage the part's built artifacts into the...
status Get the status on the store for <snap-name>.
tour Setup the snapcraft examples used in the...
update Updates the parts listing from the cloud.
validate Validate a gated snap.
root@artful:/# click --help
Usage: click COMMAND [options]
Commands are as follows ('click COMMAND --help' for more):
build Build a Click package.
buildsource Build a Click source package.
chroot Use and manage a Click ...