Title: Custom prefix/postfix to the generated click chroots

Bug #1364327 reported by Zoltan Balogh on 2014-09-02
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
click (Ubuntu)
High
Colin Watson

Bug Description

Testing the click chroot operations are the part of the Ubuntu SDK test plan.

According to the test plan we should be able to create, use  and destroy click chroots on the host without conflicting with the already set up and used click croots. Also the tests should use clean click chroots as the existing chroots might be outdated or modified.

For that we need a CLICK_CHROOT_SUFFIX variable.  The click tools should use that suffix for all click chroot operation.

For example when the CLICK_CHROOT_SUFFIX=_test1234 is set the

$ click chroot -a armhf -f ubuntu-sdk-14.10 create

command should create /var/lib/schroot/chroots/click-ubuntu-sdk-14.10-armhf_test1234 and the

$ click chroot -a armhf -f ubuntu-sdk-14.10 run

command should use the /var/lib/schroot/chroots/click-ubuntu-sdk-14.10-armhf_test1234 chroot.

With this feature the Ubuntu SDK test suite just need to set the CLICK_CHROOT_SUFFIX= and carry on with the tests.

Related branches

Colin Watson (cjwatson) wrote :

Looking through the code for click chroot, I see that the ClickChroot class constructor already takes a name= keyword argument, which defaults to "click", and is used to form the first part of the full chroot name. Right now this is unused, but it could easily be exposed by way of a new command-line option. I would prefer this over creating a new mechanism.

Would you be content if "click chroot -a armhf -f ubuntu-sdk-14.10 --name test1234 create" etc. worked? You could then make your scripts that call "click chroot" honour an environment variable if that's easier to coordinate at the top level.

Changed in click (Ubuntu):
status: New → Incomplete
importance: Undecided → High
Colin Watson (cjwatson) wrote :

13:40 <bzoltan> cjwatson: Yes, it does. We need to fix our code in few places. But still your suggestion sounds the most simple and straightforward.

Changed in click (Ubuntu):
status: Incomplete → Triaged
Colin Watson (cjwatson) on 2014-09-13
Changed in click (Ubuntu):
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Colin Watson (cjwatson) on 2014-09-26
Changed in click (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click - 0.4.33

---------------
click (0.4.33) utopic; urgency=medium

  [ Pete Woods ]
  * Add scope-facing APIs to chroot build (LP: #1370727).

  [ Colin Watson ]
  * Warn that "click install" without a registration may result in later
    garbage-collection.
  * Rearrange garbage-collection to remove versions of packages that have no
    user registrations and are not running, rather than using the artificial
    @gcinuse registration which never really worked properly.
  * Run garbage-collection immediately before running system hooks on system
    startup (LP: #1342858).
  * Add new -n/--name option to "click chroot", defaulting to "click"
    (LP: #1364327).

  [ Michael Vogt ]
  * Make click destroy more robust by unmounting any mounted filesystem
    inside the schroot first (LP: #1346723).
  * Stop apps if necessary when uninstalling them (LP: #1232130).
  * Add new "click framework {info,get-field}" subcommands.
 -- Ubuntu daily release <email address hidden> Mon, 29 Sep 2014 14:18:41 +0000

Changed in click (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers