wrong permissions of click packages due to adb shell umask of 0000
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
click (Ubuntu) |
Fix Released
|
High
|
Colin Watson |
Bug Description
Hi,
Starting a root shell with adb shell gets me an umask of 0000 which causes side effects; e.g. when installing a click package with click install, it wont have the same permissions as others installed via the scope:
drwxrwxrwx 3 clickpkg clickpkg 4096 Aug 22 14:43 ar.com.
drwxrwxrwx 3 clickpkg clickpkg 4096 Aug 22 14:58 com.ubuntu.
drwxr-xr-x 3 clickpkg clickpkg 4096 Aug 19 13:21 com.ubuntu.
drwxr-xr-x 3 clickpkg clickpkg 4096 Aug 19 13:21 com.ubuntu.
drwxr-xr-x 3 clickpkg clickpkg 4096 Aug 19 13:21 com.ubuntu.sudoku
I believe we should fix click to set permissions of click package dirs and adb to set umask correctly.
Cheers,
Related branches
- Colin Watson: Approve
- Ubuntu CI managed package branches: Pending requested
-
Diff: 485 lines (+269/-70)11 files modifiedREADME (+1/-0)
click/build.py (+10/-22)
click/framework.py (+138/-0)
click/install.py (+8/-28)
click/paths.py.in (+1/-0)
click/tests/helpers.py (+29/-0)
click/tests/test_build.py (+39/-5)
click/tests/test_install.py (+2/-4)
debian/changelog (+8/-0)
doc/file-format.rst (+1/-2)
doc/index.rst (+32/-9)
Changed in click (Ubuntu): | |
importance: | Undecided → Medium |
tags: | added: appstore |
Changed in click (Ubuntu): | |
status: | New → Triaged |
importance: | Medium → High |
Changed in click (Ubuntu): | |
status: | Triaged → Fix Committed |
assignee: | nobody → Colin Watson (cjwatson) |
adb bug at #1215481