| 2016-05-20 21:34:17 |
Jamie Strandboge |
bug |
|
|
added bug |
| 2016-05-20 21:34:30 |
Jamie Strandboge |
nominated for series |
|
Ubuntu Yakkety |
|
| 2016-05-20 21:34:30 |
Jamie Strandboge |
bug task added |
|
click-reviewers-tools (Ubuntu Yakkety) |
|
| 2016-05-20 21:34:30 |
Jamie Strandboge |
nominated for series |
|
Ubuntu Xenial |
|
| 2016-05-20 21:34:30 |
Jamie Strandboge |
bug task added |
|
click-reviewers-tools (Ubuntu Xenial) |
|
| 2016-05-20 21:34:44 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Yakkety): status |
New |
Fix Committed |
|
| 2016-05-20 21:34:47 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Yakkety): importance |
Undecided |
High |
|
| 2016-05-20 21:34:49 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Xenial): importance |
Undecided |
High |
|
| 2016-05-20 21:34:51 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Yakkety): assignee |
|
Jamie Strandboge (jdstrand) |
|
| 2016-05-20 21:34:53 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Xenial): assignee |
|
Jamie Strandboge (jdstrand) |
|
| 2016-05-20 21:34:56 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Xenial): status |
New |
In Progress |
|
| 2016-05-20 21:40:12 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Xenial): status |
In Progress |
Triaged |
|
| 2016-05-20 21:56:17 |
Jamie Strandboge |
description |
... |
[Impact]
Upgrade to review tools 0.43. The review tools provide lint-style checks for clicks and snaps. This release has several bug fixes and support for new snappy yaml declarations, the most important of which is supporting the 'confinement' property.
Here is the complete changelog:
* sr_lint.py:
- kernel snaps may have external symlinks
- handle top-level plugs and slots with yaml data as 'null' (LP: #1579201)
- add epoch checks (LP: #1583298)
- .pyc are arch-independent, so don't complain about them
- add confinement checks (LP: #1580819)
* data/apparmor-easyprof-ubuntu.json:
- add opengl interface as 'common' (LP: #1572140)
- add reserved bluez, network-manager and location-observe interfaces
* sr_security.py:
- remove last reference to 'cap'
- turn resquash test into info for now until the squashfs-tools bugs are
fixed and this is a reliable check
* when 'confinement' is 'devmode', override the result type to 'info'
- common.py: add override_result_type to allow in support of 'confinement'
overrides
- sr_common.py: add _devmode_override()
- sr_security.py: use override_result_type if in devmode
- LP: #1584231
[Test Case]
The testsuite tests the above and the store is already using these checks. To verify the package:
1. install the package
2. verify click reviews work with: click-review /path/to/click
3. verify snapv1 reviews work with: click-review /path/to/15.04/snap
4. verify snapv2 reviews work with: click-review /path/to/16/snap
[Regression Potential]
The worst regression is that the lint tool would trace back to the user running it instead of displaying the information. The testsuite is run during the build and is comprehensive with the added code maintaining 100% coverage for sr_security.py and sr_lint.py. sr_common.py maintaining 98% coverage.
[Other Info]
The store has been running r651 for weeks with no issues. r652 and later are to support the new snappy 'confinement' and 'epoch' fields as per the spec and fixes a few minor issues. The store will land this next week and if there are regressions there, I will update this bug. |
|
| 2016-05-20 21:56:36 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Xenial): status |
Triaged |
In Progress |
|
| 2016-05-20 21:56:59 |
Jamie Strandboge |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2016-05-20 21:58:20 |
Jamie Strandboge |
summary |
support 'confinement' field in snap v2 yaml |
update to 0.43 (aka, support 'confinement' field in snap v2 yaml) |
|
| 2016-05-23 18:56:20 |
Jamie Strandboge |
click-reviewers-tools (Ubuntu Yakkety): status |
Fix Committed |
Fix Released |
|
| 2016-05-24 20:48:11 |
Martin Pitt |
click-reviewers-tools (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
| 2016-05-24 20:48:14 |
Martin Pitt |
bug |
|
|
added subscriber SRU Verification |
| 2016-05-24 20:48:17 |
Martin Pitt |
tags |
|
verification-needed |
|
| 2016-05-25 18:52:21 |
Jamie Strandboge |
tags |
verification-needed |
verification-done |
|
| 2016-05-30 19:43:30 |
Launchpad Janitor |
click-reviewers-tools (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2016-05-30 19:43:48 |
Adam Conrad |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
