Invalid framework "ubuntu-sdk-15.04"

[XiaoGuo, Liu]

Today, I just flashed my nexus phone software to the most updated 15.04:

phablet@ubuntu-phablet:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 15.04
Release: 15.04
Codename: vivid

phablet@ubuntu-phablet:~$ system-image-cli -i
current build number: 186
device name: mako
channel: ubuntu-touch/devel-proposed
alias: ubuntu-touch/vivid-proposed
last update: 2015-04-28 05:06:46
version version: 186
version ubuntu: 20150428
version device: 20150210
version custom: 20150428

I am using the latest Qt creator and create a very basic "QML app with Simple UI (qmlproject)" template application. During the creation, I chose "Ubuntu-sdk-15.04" and the framework. On the phone, it shows:

phablet@ubuntu-phablet:~$ click framework list
ubuntu-sdk-13.10
ubuntu-sdk-14.04-dev1
ubuntu-sdk-14.04-html-dev1
ubuntu-sdk-14.04-html
ubuntu-sdk-14.04-papi-dev1
ubuntu-sdk-14.04-papi
ubuntu-sdk-14.04-qml-dev1
ubuntu-sdk-14.04-qml
ubuntu-sdk-14.04
ubuntu-sdk-14.10-dev1
ubuntu-sdk-14.10-dev2
ubuntu-sdk-14.10-html-dev1
ubuntu-sdk-14.10-html-dev2
ubuntu-sdk-14.10-html
ubuntu-sdk-14.10-papi-dev1
ubuntu-sdk-14.10-papi-dev2
ubuntu-sdk-14.10-papi
ubuntu-sdk-14.10-qml-dev1
ubuntu-sdk-14.10-qml-dev2
ubuntu-sdk-14.10-qml-dev3
ubuntu-sdk-14.10-qml
ubuntu-sdk-14.10
ubuntu-sdk-15.04-html
ubuntu-sdk-15.04-papi
ubuntu-sdk-15.04-qml
ubuntu-sdk-15.04

Clearly, "ubuntu-sdk-15.04" is there, but when I run my app, it shows:

:-1: error: security_policy_version_matches_framework (qmltest.apparmor): Invalid framework 'ubuntu-sdk-15.04'

[Test Case]
 - Download https://bugs.launchpad.net/ubuntu/vivid/+source/click-reviewers-tools/+bug/1449368/+attachment/4390735/+files/com.ubuntu.developer.dholbach.webapp-mixcloud_0.3_all.click and run click-review on it.
 - Find it breaking.
 - Install update.
 - Try again. Test succeeds.

[Impact]
Click apps using the "ubuntu-sdk-15.04" framework are not validated. click-reviewers-tools errors out.

[Regression Potential]
Little. The test suite passes, it's been landed in the PPA of the SDK team which is heavily used, so this is already working for many people.

[Benjamin Zeller (zeller-benjamin)]

This message is coming from the click-reviewers-tools, the IDE just shows the result.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Jamie Strandboge (jdstrand)]

Can you attach these files from your host:
~/.cache/click-reviewers-tools/frameworks.json
~/.cache/click-reviewers-tools/apparmor-easyprof-ubuntu.json

[Daniel Holbach (dholbach)]

I'm seeing the same issue.

[Daniel Holbach (dholbach)]

Take a valid click package, update framework in manifest.json to "ubuntu-sdk-15.04" and run click-review from trunk, to get:

Errors
------
 - security_policy_version_matches_framework (webapp-mixcloud.json)
 Invalid framework 'ubuntu-sdk-15.04'
./com.ubuntu.developer.dholbach.webapp-mixcloud_0.3_all.click: FAIL

[Daniel Holbach (dholbach)]

AFAICS we need to update clickreviews/cr_security.py around line 109.

[Jamie Strandboge (jdstrand)]

Daniel, yes you are right. This is committed in in r453. Note, that if specifying the ubuntu-sdk-15.04 framework, the click needs to specify the 1.3 policy_version (it currently specifies 1.2).

[Jamie Strandboge (jdstrand)]

If you want to roll 0.27 for this change and push to the ppas, that would be fine. I've asked the store to sync this change.

[Daniel Holbach (dholbach)]

Shall we also push this as a SRU? It could be important enough...

[Daniel Holbach (dholbach)]

Pushed to the PPA. I'll make a 0.27 release and upload to wily.

[XiaoGuo, Liu (liu-xiao-guo)]

I think it is important to make it available to vivid as well

[Daniel Holbach (dholbach)]

Relevant change to be SRU'ed: http://pastebin.ubuntu.com/10990657/

[Daniel Holbach (dholbach)]

SRU uploaded: http://pastebin.ubuntu.com/10990707/

[Chris J Arges (arges)]

Hello XiaoGuo, or anyone else affected,

Accepted click-reviewers-tools into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/click-reviewers-tools/0.25.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[XiaoGuo, Liu (liu-xiao-guo)]

Hi,

I just tried to update my system, and the problem did not happen any more. I am not sure whether it is already there in the release for vivid.

Thanks & best regards,
xiaoguo

[Daniel Holbach (dholbach)]

Can you run

  dpkg -l click-reviewers-tools

in a terminal and paste the output here?

[Daniel Holbach (dholbach)]

Here's an updated .click package of the mixcloud webapp:

daniel@daydream:~/dev/apps/webapp-mixcloud$ bzr diff
=== modified file 'manifest.json'
--- manifest.json 2015-05-04 12:20:24 +0000
+++ manifest.json 2015-05-07 13:19:22 +0000
@@ -1,6 +1,6 @@
 {
     "description": "Mixcloud - great radio, for everyone",
- "framework": "ubuntu-sdk-14.10",
+ "framework": "ubuntu-sdk-15.04",
     "hooks": {
         "webapp-mixcloud": {
             "apparmor": "webapp-mixcloud.json",
@@ -11,6 +11,6 @@
     "maintainer": "Daniel Holbach <email address hidden>",
     "name": "com.ubuntu.developer.dholbach.webapp-mixcloud",
     "title": "webapp-mixcloud",
- "version": "0.3"
+ "version": "0.4"
 }

=== modified file 'webapp-mixcloud.json'
--- webapp-mixcloud.json 2014-08-29 15:44:52 +0000
+++ webapp-mixcloud.json 2015-05-07 13:19:30 +0000
@@ -6,5 +6,5 @@
     "video",
     "webview"
   ],
- "policy_version": 1.2
+ "policy_version": 1.3
 }

daniel@daydream:~/dev/apps/webapp-mixcloud$

[Daniel Holbach (dholbach)]

daniel@daydream:~$ wget -q http://launchpadlibrarian.net/205810567/click-reviewers-tools_0.25.1_all.debdaniel@daydream:~$ wget -q https://bugs.launchpad.net/ubuntu/+source/click-reviewers-tools/+bug/1449368/+attachment/4393007/+files/com.ubuntu.developer.dholbach.webapp-mixcloud_0.4_all.click
daniel@daydream:~$ sudo dpkg -i click-reviewers-tools_0.25.1_all.deb
dpkg: Warnung: Version 0.28-0~457~ubuntu15.04.1 des Paketes click-reviewers-tools wird durch ältere Version 0.25.1 ersetzt
(Lese Datenbank ... 279777 Dateien und Verzeichnisse sind derzeit installiert.)
Vorbereitung zum Entpacken von click-reviewers-tools_0.25.1_all.deb ...
Entpacken von click-reviewers-tools (0.25.1) über (0.28-0~457~ubuntu15.04.1) ...
click-reviewers-tools (0.25.1) wird eingerichtet ...
daniel@daydream:~$ click-review com.ubuntu.developer.dholbach.webapp-mixcloud_0.4_all.click
com.ubuntu.developer.dholbach.webapp-mixcloud_0.4_all.click: pass
daniel@daydream:~$

If you have a similar output as the one I do here, please change the tag of this bug from 'verification-needed' to 'verification-done'.

Thanks.

[Daniel Holbach (dholbach)]

Sorry, my last comment got messed up a bit. The commands I meant were:

wget http://launchpadlibrarian.net/205810567/click-reviewers-tools_0.25.1_all.deb

wget https://bugs.launchpad.net/ubuntu/+source/click-reviewers-tools/+bug/1449368/+attachment/4393007/+files/com.ubuntu.developer.dholbach.webapp-mixcloud_0.4_all.click

sudo dpkg -i click-reviewers-tools_0.25.1_all.deb

click-review com.ubuntu.developer.dholbach.webapp-mixcloud_0.4_all.click

[XiaoGuo, Liu (liu-xiao-guo)]

liuxg@liuxg:~$ dpkg -l click-reviewers-tools
Desired=Unknown/Install/Remove/Purge/Hold
|
Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-============-============-=================================
ii click-reviewer 0.27-0~455~u all tools to review click packages

On Thu, May 7, 2015 at 9:18 PM, Daniel Holbach <email address hidden>
wrote:

> Can you run
>
> dpkg -l click-reviewers-tools
>
> in a terminal and paste the output here?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1449368
>
> Title:
> Invalid framework "ubuntu-sdk-15.04"
>
> Status in click-reviewers-tools package in Ubuntu:
> Fix Released
> Status in click-reviewers-tools source package in Vivid:
> Fix Committed
>
> Bug description:
> Today, I just flashed my nexus phone software to the most updated
> 15.04:
>
> phablet@ubuntu-phablet:~$ lsb_release -a
> No LSB modules are available.
> Distributor ID: Ubuntu
> Description: Ubuntu 15.04
> Release: 15.04
> Codename: vivid
>
> phablet@ubuntu-phablet:~$ system-image-cli -i
> current build number: 186
> device name: mako
> channel: ubuntu-touch/devel-proposed
> alias: ubuntu-touch/vivid-proposed
> last update: 2015-04-28 05:06:46
> version version: 186
> version ubuntu: 20150428
> version device: 20150210
> version custom: 20150428
>
> I am using the latest Qt creator and create a very basic "QML app with
> Simple UI (qmlproject)" template application. During the creation, I
> chose "Ubuntu-sdk-15.04" and the framework. On the phone, it shows:
>
> phablet@ubuntu-phablet:~$ click framework list
> ubuntu-sdk-13.10
> ubuntu-sdk-14.04-dev1
> ubuntu-sdk-14.04-html-dev1
> ubuntu-sdk-14.04-html
> ubuntu-sdk-14.04-papi-dev1
> ubuntu-sdk-14.04-papi
> ubuntu-sdk-14.04-qml-dev1
> ubuntu-sdk-14.04-qml
> ubuntu-sdk-14.04
> ubuntu-sdk-14.10-dev1
> ubuntu-sdk-14.10-dev2
> ubuntu-sdk-14.10-html-dev1
> ubuntu-sdk-14.10-html-dev2
> ubuntu-sdk-14.10-html
> ubuntu-sdk-14.10-papi-dev1
> ubuntu-sdk-14.10-papi-dev2
> ubuntu-sdk-14.10-papi
> ubuntu-sdk-14.10-qml-dev1
> ubuntu-sdk-14.10-qml-dev2
> ubuntu-sdk-14.10-qml-dev3
> ubuntu-sdk-14.10-qml
> ubuntu-sdk-14.10
> ubuntu-sdk-15.04-html
> ubuntu-sdk-15.04-papi
> ubuntu-sdk-15.04-qml
> ubuntu-sdk-15.04
>
> Clearly, "ubuntu-sdk-15.04" is there, but when I run my app, it shows:
>
> :-1: error: security_policy_version_matches_framework
> (qmltest.apparmor): Invalid framework 'ubuntu-sdk-15.04'
>
> [Test Case]
> - Download
> https://bugs.launchpad.net/ubuntu/vivid/+source/click-reviewers-tools/+bug/1449368/+attachment/4390735/+files/com.ubuntu.developer.dholbach.webapp-mixcloud_0.3_all.click
> and run click-review on it.
> - Find it breaking.
> - Install update.
> - Try again. Test succeeds.
>
>
> [Impact]
> Click apps using the "ubuntu-sdk-15.04" framework are not validated.
> click-reviewers-tools errors out.
>
>
>...

[Daniel Holbach (dholbach)]

<bzoltan> dholbach: I went on the official way :) disabling the SDK PPA put back the stock c-r-t from vivid archive and the SDK throw an error when made a 15.04 app for 15.05 device. I enabled the vivid-proposed and it pulled the 0.25.1 c-r-t what fixed the issue. GREEN LIGHT :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package click-reviewers-tools - 0.25.1

---------------
click-reviewers-tools (0.25.1) vivid; urgency=medium

  * Fix 'Invalid framework "ubuntu-sdk-15.04"' error.
    Change is already in wily and corresponds to r453 in
    clickreviews/cr_security.py. (LP: #1449368)

 -- Daniel Holbach <email address hidden> Tue, 05 May 2015 18:07:42 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for click-reviewers-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.