clementine should build-depend on libqca2-dev (for Spotify support)

Bug #995689 reported by Lee Couringon
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
clementine (Debian)
Won't Fix
Unknown
clementine (Ubuntu)
Won't Fix
Low
Unassigned

Bug Description

Version of Kubuntu: 12.04
Version of Clementine: 1.0.1
What I expected to happen: Spotify account support
What happened instead: Spotify was not listed in the internet providers section of the settings window

Tags: patch
Revision history for this message
Daniel Letzeisen (dtl131) wrote :

The issue is that Debian/Ubuntu do not include libspotify in their repos for licensing reasons. This bug applies to rhythmbox, but it's the same idea:
https://bugzilla.gnome.org/show_bug.cgi?id=579914

Changed in clementine (Ubuntu):
status: New → Confirmed
Revision history for this message
pvz (petrvz) wrote :

I have the same problem; spotify support worked out of the box on 11.10, and stopped working after upgrading to 12.04.
What has changed between 11.10 and 12.04?

Revision history for this message
Adriaan (aadje) wrote :

I filed this at the Clementine issues and got the following reply from David Sansome:

Me:

What steps will reproduce the problem?

After the update via the update manager, Spotify support was missing. I had to reinstall the older 'precise' version manually for it to come back:

This is what the update manager has to say about it:

Installed version: 1.0.1~precise
Available version: 1.0.1+dfsg-1ubuntu2

On Windows 7 version 1.0.1, however, the Spotify support is still there.

What version of the product are you using? On what operating system?

As stated I now use Clementine 1.0.1~precise on Ubuntu 12.04 LTS.

Answer from David:

This will be because the package in the Ubuntu repository has been built without Spotify support. Can you file the bug upstream on Launchpad?

Revision history for this message
Daniel Letzeisen (dtl131) wrote :

Just use the package from clementine's website. It is not older than the one in Ubuntu's (both are 1.0.1).

Revision history for this message
David Sansome (me-davidsansome) wrote :

I don't think this is a duplicate of bug #370311 - the Ubuntu packagers just need to compile Clementine with Spotify support, not develop a whole new plugin. Spotify support in Clementine only requires libprotobuf. The non-GPL parts aren't a compile-time requirement and will be downloaded from the Clementine website at runtime if the user tries to use spotify.

Revision history for this message
Daniel Letzeisen (dtl131) wrote : Re: clementine should build-depend on libprotobuf-dev (for Spotify support)

@D Sansome, thanks for clarifying.

summary: - Does not Support Spotify
+ clementine should build-depend on libprotobuf-dev (for Spotify support)
Changed in clementine (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Low
summary: - clementine should build-depend on libprotobuf-dev (for Spotify support)
+ clementine should build-depend on libprotobuf-dev, protobuf-compiler,
+ and libqca2-dev (for Spotify support)
Revision history for this message
Daniel Letzeisen (dtl131) wrote : Re: clementine should build-depend on libprotobuf-dev, protobuf-compiler, and libqca2-dev (for Spotify support)
Changed in clementine (Debian):
status: Unknown → Won't Fix
Revision history for this message
Jeremy Bícha (jbicha) wrote :

This bug was fixed in the package clementine - 1.1.1+dfsg-1

---------------
clementine (1.1.1+dfsg-1) experimental; urgency=low

  * New upstream release.
  * Add libfftw3-dev to build-depends for moodbar support (Closes: #694250)
  * Add libsparsehash-dev to build-depends and set minimum requirement to
    version 1.8 for libtag1-dev for Google Drive support. (Closes: #694924)
  * Update the debian/watch file. Thanks to Bart Martens.
  * Remove deprecated DM-Upload-Allowed field in debian/control file.
  * Set build-depend libechonest-dev minimum version to version 2.0.1.

 -- Thomas Pierson <email address hidden> Mon, 10 Dec 2012 23:03:05 +0100

clementine (1.1.0~rc1+dfsg-1) experimental; urgency=low

  * New upstream release candidate. (Closes: #639975)
  * Remove obsolete patches.
  * Add libprotobuf and protobuf-compiler to build-depends because it
    is now a hard requirement.
  * Update debian/copyright and debian/README.Debian files.
  * Add a lintian override binary-without-manpage because a new binary
    clementine-tagreader is only used internaly by Clementine and does not
    need a manpage.

 -- Thomas Pierson <email address hidden> Sun, 30 Sep 2012 20:27:06 +0200

Changed in clementine (Ubuntu):
status: Triaged → Fix Released
status: Fix Released → Confirmed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

The Debian packaging still doesn't depend on qca2, so reopening.

Changed in clementine (Ubuntu):
status: Confirmed → Triaged
summary: - clementine should build-depend on libprotobuf-dev, protobuf-compiler,
- and libqca2-dev (for Spotify support)
+ clementine should build-depend on libqca2-dev (for Spotify support)
Changed in clementine (Ubuntu):
assignee: nobody → Christian Mangold (neversfelde)
Changed in clementine (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Christian Mangold (neversfelde) wrote :
Revision history for this message
Christian Mangold (neversfelde) wrote :
Revision history for this message
Christian Mangold (neversfelde) wrote :
Revision history for this message
Christian Mangold (neversfelde) wrote :
Revision history for this message
Christian Mangold (neversfelde) wrote :
Changed in clementine (Ubuntu):
assignee: Christian Mangold (neversfelde) → Kubuntu Developers (kubuntu-dev)
tags: added: patch
Revision history for this message
Scott Kitterman (kitterman) wrote :

Actually, I tend to agree with Debian. I don't think adding an automatic downloader from a third party repository is an appropriate solution.

Changed in clementine (Ubuntu):
assignee: Kubuntu Developers (kubuntu-dev) → nobody
Revision history for this message
Daniel Letzeisen (dtl131) wrote :

FWIW, I've uploaded a fixed version of Clementine to my ppa: https://launchpad.net/~dtl131/+archive/ppa
Right now, there's only quantal version, but if anyone's interested in other Ubuntu versions, please post here.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I also disagree about automatic third party downloader.

Can the automatic downloader be disabled?

Ubuntu is free and always will be free, promoting & using proprietary 3rd-party library by default is not the intent of our project.
We could publish a clementine-nonfree package with a downloader wrapper (like it's done for flashplugin), but I'd rather see that done in debian first.

ps. unsubscribing sponsors, and subscribing myself to the bug report.

Changed in clementine (Ubuntu):
status: In Progress → Won't Fix
Revision history for this message
Daniel Letzeisen (dtl131) wrote :

I know it won't matter, but I completely disagree with the 'Won't FIx' decision. I don't see how's it any different than building something like jockey/Additional drivers to make it easier if the user decides s/he wants non-free software. Simply depending on libqca2-dev will not install non-free software. It only gives the user the option to do so if s/he uses and logs in to Spotify. Ubuntu is supposed to be pragmatic about the non-free software issue, and while I understand they don't want to promote it, they should not artificially hinder its use either.

Revision history for this message
Christian Mangold (neversfelde) wrote :

@Scott I disagree at this. The official spotify client is focussed on unity and pretty useless for KDE users.
clementine is market leader on implementing spotify, but as far as I know all other players and especially amarok are working on it.

Also all distributions I lately tested are offering it with clementine. This should really be fixed,

Keep in mind, that spotify support in clementine is enabled, but not working. So if we won't fix this, we have to remove it completely and differ from the debian package is necessary.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.