[SRU] Cinnamon session doesn't shutdown until all apps close regardless if they act to Cinnamon's logout request

Bug #1887312 reported by Joshua Peisach on 2020-07-12
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
cinnamon-session (Ubuntu)
Low
Joshua Peisach
Focal
Low
Unassigned

Bug Description

Reference to upstream commit: csm-manager.c: Don't let programs that exit without responding to cinnamon-session's request delay the shutdown.

This fixes the following issue: https://github.com/linuxmint/cinnamon/issues/3752

SRU TEMPLATE:

[Impact]

 * When Cinnamon is exiting, it will wait for apps to close before it shutsdown.
* Using normal shutdown procedures it can be overwritten (e.g. shutdown -a) and will save time.
* The commit upstream removes delay in Cinnamon Session shutdown.

[Test Case]

 * Open an app that requires time to shutdown-e.g. Steam.
 * Shut down and look for the time that it takes to shutdown.
 * Force shutdown Cinnamon from terminal
 * Notice it takes no time to shutdown.

[Regression Potential]

 * Regression is nearly impossible due to this coming from upstream, and the new versions in Groovy. Development will probably still continue through patches.

 * This is also something GNOME from upstream patched.

 * Regression could be possible if things such as memory/RAM speed change or an update of Cinnamon (such as muffin Window Manager) occur overtime.

 * As new apps come by and it takes time to actually safely close the applications, this can cause possible lag and unsafe possible corruption but this is very unlikely.

[Other Info]

 * The bug patch is from upstream (see the commit that closed the issue above)
 * This is part of the bug fixes in cinnamon-session upstream.

An SRU is strongly recommended. Above is the template. Debdiff will be applied in comments.

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: cinnamon-session (not installed)
ProcVersionSignature: Ubuntu 5.4.0-40.44-generic 5.4.44
Uname: Linux 5.4.0-40-generic x86_64
ApportVersion: 2.20.11-0ubuntu27.3
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
Date: Sun Jul 12 15:46:08 2020
InstallationDate: Installed on 2020-04-23 (80 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: cinnamon-session
UpgradeStatus: No upgrade log present (probably fresh install)

Joshua Peisach (itzswirlz) wrote :
Joshua Peisach (itzswirlz) wrote :

Debdiff/New DSC File/Patch File:

description: updated
Joshua Peisach (itzswirlz) wrote :

LP doesn't allow you to send multiple attachments so:

summary: - Cinnamon session doesn't shutdown until all apps close regardless if
- they act to Cinnamon's logout request
+ [SRU] Cinnamon session doesn't shutdown until all apps close regardless
+ if they act to Cinnamon's logout request
Changed in cinnamon-session (Ubuntu):
status: New → Fix Committed
assignee: nobody → Joshua Peisach (itzswirlz)
Joshua Peisach (itzswirlz) wrote :

Patch affects other patches-I will be patching and fixing the patch shortly

Changed in cinnamon-session (Ubuntu):
status: Fix Committed → In Progress
Joshua Peisach (itzswirlz) wrote :

Final patch available.

description: updated
Changed in cinnamon-session (Ubuntu):
status: In Progress → Fix Committed
Mathew Hodson (mhodson) on 2020-07-30
Changed in cinnamon-session (Ubuntu):
importance: Undecided → Low
tags: added: patch sru
Joshua Peisach (itzswirlz) wrote :

Switch to 'in progress' as we are waiting MOTU

Changed in cinnamon-session (Ubuntu):
status: Fix Committed → In Progress
description: updated
Fantu (fantonifabio) wrote :

I also saw this issue, about the patch no issue is reported about it from a fast search and gnome-session have same change from one year without revert or change about it, so seems safe.

Joshua Peisach (itzswirlz) wrote :

Groovy Beta is like tomorrow... so I'll definitely know if it's a problem. I doubt it'll be

Mathew Hodson (mhodson) on 2020-10-03
Changed in cinnamon-session (Ubuntu Focal):
importance: Undecided → Low
Graham Inggs (ginggs) wrote :

Joshua, there are some unnecessary changes in your debdiff (trailing white space), e.g.

- case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:
+ case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:

-_finished_playing_logout_sound (ca_context *c, uint32_t id, int error, void *userdata)
+_finished_playing_logout_sound (ca_context *c, uint32_t id, int error, void *userdata)

Would you please trim it down to only what's needed?

Also, this:

Bug: https://bugs.launchpad.net/ubuntu/+source/cinnamon-session/+bug/1887312
Bug-<Vendor>: https://github.com/linuxmint/cinnamon/issues/3752

should be:

Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/cinnamon-session/+bug/1887312
Bug: https://github.com/linuxmint/cinnamon/issues/3752

Joshua Peisach (itzswirlz) wrote :

Alright-I see some activity so I'll go through these:

"Joshua, there are some unnecessary changes in your debdiff (trailing white space), e.g.

- case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:
+ case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:"

Most of the time I blame Linux Mint. Atom automatically deletes trailing white spaces-so I'll check the diff to see if it removed the whitespace or added whitespaces.

But if you really want I can manually remove it.

"Also, this:

Bug: https://bugs.launchpad.net/ubuntu/+source/cinnamon-session/+bug/1887312
Bug-<Vendor>: https://github.com/linuxmint/cinnamon/issues/3752

should be:

Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/cinnamon-session/+bug/1887312
Bug: https://github.com/linuxmint/cinnamon/issues/3752"
Okay. I'll fix that ASAP

Joshua Peisach (itzswirlz) wrote :

Yes-these are whitespaces. I don't think you should be upset about these being removed:

- case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:
+ case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:"

Joshua Peisach (itzswirlz) wrote :

Okay, here changes the Bug and Bug-Ubuntu fields.

The whtiespaces are whitespace removals, so I think we can keep it.

Graham Inggs (ginggs) wrote :

Please trim your debdiff down to only what is needed.
Having unnecessary changes just makes things harder to review.

Graham Inggs (ginggs) wrote :

Uploaded, thanks.

Changed in cinnamon-session (Ubuntu Focal):
status: New → In Progress

Hello Joshua, or anyone else affected,

Accepted cinnamon-session into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cinnamon-session/4.4.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in cinnamon-session (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.