hwacc branches fail to build

Bug #2006641 reported by Bram Stolk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
chromium-browser (Ubuntu)
Triaged
Undecided
Bram Stolk

Bug Description

Currently the hwacc branches of snap_from_source fail to build.

This is caused by the fact that the guide-0.9.1 patches are against 107 chromium, and no longer apply cleanly.

build logs here:
Candidate: https://launchpad.net/~chromium-team/+snap/chromium-snap-from-source-hwacc-candidate
Beta: https://launchpad.net/~chromium-team/+snap/chromium-snap-from-source-hwacc-beta
Dev: https://launchpad.net/~chromium-team/+snap/chromium-snap-from-source-hwacc-dev

Related branches

Bram Stolk (b-stolk)
Changed in chromium-browser (Ubuntu):
assignee: nobody → Bram Stolk (b-stolk)
Hector CAO (hectorcao)
Changed in chromium-browser (Ubuntu):
status: New → In Progress
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Cherry picked to all branches, currently building.

Changed in chromium-browser (Ubuntu):
status: In Progress → Fix Committed
tags: added: beta-ok candidate-failed dev-failed
tags: removed: candidate-failed
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

One-copy patch does not apply to 111.

Beta has just moved 110->111. Thus the next build of beta will fail.

tags: added: candidate-ok
Revision history for this message
Bram Stolk (b-stolk) wrote (last edit ):

>One-copy patch does not apply to 111.

That is regrettable. I'll do a quick test to see if a higher --fuzz helps, by any chance. Which would be a trivial fix.

UPDATE: it did not..

patching file media/capture/video/video_capture_buffer_tracker_factory_impl.cc
patching file third_party/blink/renderer/platform/video_capture/video_capture_impl.cc
Hunk #1 FAILED at 531.
Hunk #2 succeeded at 534 (offset -13 lines).
1 out of 2 hunks FAILED -- rejects in file third_party/blink/renderer/platform/video_capture/video_capture_impl.cc

I'll take a look at the diffs between 110 and 111 in meld.

tags: added: beta-failed
removed: beta-ok
Changed in chromium-browser (Ubuntu):
status: Fix Committed → Triaged
description: updated
tags: added: beta-ok dev-ok
removed: beta-failed dev-failed
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

For 113, guide-0.9.1:a49acb3:one-copy.diff fails to apply.

tags: added: dev-failed
removed: dev-ok
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.