[snap] New Chromium icon, not yet used by Snap

[Alexander Browne]

Google updated the Chrome/Chromium icons recently (see more at https://twitter.com/elvin_not_11/status/1489647032201465861), but I don't think the Snap icon has been updated.

Here's the Chromium icons on the Chromium source GitHub mirror, which was easier for me to search: https://github.com/chromium/chromium/tree/main/chrome/app/theme/chromium/linux

[Alexander Browne (elcste)]

Looking at the snapcraft.yaml (https://git.launchpad.net/~chromium-team/chromium-browser/+git/snap-from-source/tree/snapcraft.yaml#n233)

I think what needs to change is

      cp chrome/app/theme/chromium/product_logo_256.png $SNAPCRAFT_PART_INSTALL/chromium.png

to

      cp chrome/app/theme/chromium/linux/product_logo_256.png $SNAPCRAFT_PART_INSTALL/chromium.png

That is, add `linux` to the icon source path, since these new icons differ by platform.

(If the code was on GitHub I'd submit a PR, but I'm very much a beginner with git and haven't done it on LP before.)

[Nathan Teodosio (nteodosio)]

Hi Alexander, thanks for your report!

> (If the code was on GitHub I'd submit a PR, but I'm very much a beginner with git and haven't done it on LP before.)

Yeah, navigating Launchpad may be hard for the first time. However, if you are interested, this is how you would go about it:

- Create a SSH key pair for Launchpad[1].

- Get the development branch from the chromium-browser:

    git clone -b dev https://git.launchpad.net/~chromium-team/chromium-browser/+git/snap-from-source

  As described in its page[2].

- Push to your own Launchpad repository. It should be something like

    git remote add origin git+ssh://<email address hidden>/~elcste/+git/REPOSITORY_NAME
    git push --set-upstream origin master

- If you visit your repository (assuming the branch is "dev", https://code.launchpad.net/~elcste/chromium-browser/+git/chromium-browser/+ref/dev), you can "propose for merging" against the ~chromium-team/chromium-browser/+git/snap-from-source repository on the dev branch.

Please feel free to drop any question if you get stuck, either here or sending me an email[3].

[1]: https://help.launchpad.net/YourAccount/CreatingAnSSHKeyPair
[2]: https://code.launchpad.net/~chromium-team/chromium-browser/+git/snap-from-source/+ref/dev
[3]: https://launchpad.net/%7Enteodosio/+contactuser

[Alexander Browne (elcste)]

Hey Nathan,

Thanks for the instructions! I think I made a merge proposal correctly: https://code.launchpad.net/~elcste/chromium-browser/+git/chromium-browser/+merge/429317

[Nathan Teodosio (nteodosio)]

Great to see you successfully submitted it! Thank you for your contribution.

[Alexander Browne (elcste)]

The new icon looks good 😁