[snap] Needlessly cats ~/.chromium-browser.init

Bug #1877593 reported by Roman Odaisky on 2020-05-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
chromium-browser (Ubuntu)
Low
Olivier Tilloy

Bug Description

$ fgrep -w cat -C4 /snap/chromium/current/bin/chromium.launcher

# Source ~/.chromium-browser.init for compatibility with the chromium-browser
# deb package (https://launchpad.net/bugs/1837746)
if [ -f $REALHOME/.chromium-browser.init ]; then
  cat $REALHOME/.chromium-browser.init 2>/dev/null
  if [ "$?" -eq "0" ]; then
    . $REALHOME/.chromium-browser.init
  fi
fi

This `cat` needlessly clutters the output when using things like `xdg-open`. If the intent is to check whether policies permit reading the file (so `test -f` wouldn’t work), then the stdout should be redirected to /dev/null as well.

Sebastien Bacher (seb128) wrote :

Thank you for your bug report

The change was added in
https://git.launchpad.net/~chromium-team/chromium-browser/+git/snap-from-source/commit/?h=beta&id=5e1f049a

Redirecting the output makes sense

tags: added: snap
summary: - Needlessly cats ~/.chromium-browser.init
+ [snap] Needlessly cats ~/.chromium-browser.init
Olivier Tilloy (osomon) wrote :
Changed in chromium-browser (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Olivier Tilloy (osomon)
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers