Take Picture button is enabled outside gtk thread lock

Bug #223172 reported by Gary Lasker on 2008-04-27
12
Affects Status Importance Assigned to Milestone
Cheese
Fix Released
Medium
cheese (Ubuntu)
Undecided
Unassigned
Hardy
Undecided
Unassigned
Intrepid
Undecided
Unassigned

Bug Description

Binary package hint: cheese

Inside the camera setup thread, some UI updates are done using
gdk_threads_enter/leave(). However, the call to enable the Take Picture button
currently occurs *after* gdk_threads_leave(), so it is occurring outside the
gtk thread lock.

It's a very simple fix. I've filed a patch against Cheese upstream SVN trunk and it has been accepted.

Related branches

Gary Lasker (gary-lasker) wrote :

Here is the patch that was used to address the issue.

Changed in acton:
assignee: nobody → gary-lasker
importance: Undecided → High
status: New → Fix Committed
Changed in cheese:
status: Unknown → Fix Released
Steve Magoun (smagoun) on 2008-05-02
Changed in acton:
milestone: none → beta2
Changed in acton:
status: Fix Committed → Fix Released
Pedro Villavicencio (pedro) wrote :

fixed upstream now.

Changed in cheese:
status: New → Fix Committed
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in cheese:
status: New → Fix Committed
Gary Lasker (gary-lasker) wrote :

I verified this problem has been fixed in the updated version of Cheese in -proposed. The menus now appear reliably and the UI is consistently responsive. This fix has been verified both on desktop Ubuntu 8.04 running natively on a Macbook Pro and in Hildon mode on an Intel Menlow-based MID device (Jax10).

Martin Pitt (pitti) wrote :

Copied hardy-proposed to hardy-updates and intrepid.

Changed in cheese:
status: Fix Committed → Fix Released
status: Fix Committed → Fix Released
Michael Terry (mterry) on 2009-10-28
tags: added: oem-services
Changed in cheese:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.