Checkstyle unusable on Trusty

[Saikrishna Arcot]

[Impact]
On Trusty, the commons-beanutils source package was updated to 1.9.1. The org.apache.commons.collections class was (appropriately) moved to the libcommons-collections3-java source package. Because the startup script doesn't include the new jar file in the runtime, checkstyle crashes, saying it's unable to load the org.apache.commons.collections.FastHashMap class.

[Test Case]
Run checkstyle, specifying the required checkstyle XML file and one or more Java files. The following stacktrace will be printed:
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/collections/FastHashMap
        at org.apache.commons.beanutils.PropertyUtilsBean.getPropertyDescriptor(PropertyUtilsBean.java:959)
        at org.apache.commons.beanutils.BeanUtilsBean.copyProperty(BeanUtilsBean.java:388)
        at com.puppycrawl.tools.checkstyle.api.AutomaticBean.contextualize(AutomaticBean.java:206)
        at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:156)
        at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:184)
        at com.puppycrawl.tools.checkstyle.Main.createChecker(Main.java:143)
        at com.puppycrawl.tools.checkstyle.Main.main(Main.java:120)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.collections.FastHashMap
        at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
        ... 7 more

[Regression Potential]

Limited. One java runtime library and a dependency was added, so there should be no regression. In addition, the commons-beanutils library might no longer be needed, but it has been left in (to avoid any potential regression).

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: checkstyle 5.6-2build1
ProcVersionSignature: Ubuntu 3.13.0-24.46-generic 3.13.9
Uname: Linux 3.13.0-24-generic x86_64
ApportVersion: 2.14.1-0ubuntu3
Architecture: amd64
CurrentDesktop: KDE
Date: Wed Apr 16 19:54:17 2014
EcryptfsInUse: Yes
InstallationDate: Installed on 2012-10-19 (544 days ago)
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Release amd64 (20121017.5)
PackageArchitecture: all
SourcePackage: checkstyle
UpgradeStatus: Upgraded to trusty on 2014-04-15 (1 days ago)

[Brian Murray (brian-murray)]

Shouldn't this also get fixed in Debian?

[Brian Murray (brian-murray)]

I mean it seems to me like this fix is worth forwarding to debian.

[Saikrishna Arcot (saiarcot895)]

It is, but I wanted to get Trusty done first, since it has been released already.

[Brian Murray (brian-murray)]

Generally, the Stable Release Update process requires that the fix be available in the development release of Ubuntu. See http://wiki.ubuntu.com/StableReleaseUpdates.

[Saikrishna Arcot (saiarcot895)]

Ah, ok. I've opened a bug report in Debian at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747560. (For some reason, the text isn't being wrapped.)

[Sebastien Bacher (seb128)]

https://launchpad.net/ubuntu/+source/checkstyle/5.7-2

[Sebastien Bacher (seb128)]

sponsored the change, it's waiting in the SRU queue
https://launchpad.net/ubuntu/trusty/+queue?queue_state=1&queue_text=checkstyle

[Chris J Arges (arges)]

Hello Saikrishna, or anyone else affected,

Accepted checkstyle into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/checkstyle/5.6-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Saikrishna Arcot (saiarcot895)]

I can verify that this bug has been fixed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package checkstyle - 5.6-2ubuntu0.1

---------------
checkstyle (5.6-2ubuntu0.1) trusty; urgency=medium

  * Update the wrapper script to include the libcommons-collections3 jar
    library (LP: #1308794)
  * Add libcommons-collection3-java as a dependency
 -- Saikrishna Arcot <email address hidden> Wed, 16 Apr 2014 21:58:42 -0400

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for checkstyle has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.