Ubuntu

Please sync checkinstall 1.6.1-8 (universe) from Debian unstable (main)

Reported by Bhavani Shankar on 2008-08-17
6
Affects Status Importance Assigned to Milestone
checkinstall (Debian)
New
Unknown
checkinstall (Ubuntu)
Wishlist
Unassigned

Bug Description

Please sync checkinstall 1.6.1-8 (universe) from Debian unstable (main).

Explanation of the Ubuntu delta and why it can be dropped:
The Ubuntu change of replacing 'which' with '/usr/bin/which' was rejected by the Debian Maintainer.

"I'm not really sure it's checkinstall's job to work around a broken which.
Aliases shouldn't break checkinstall. What would break checkinstall is a
broken which that is present before /usr/bin in $PATH. However, if we care
about this then we should start adding full paths to all programs invoked,
and there lies madness."

Since the Debian Maintainer does not feel that this patch is needed, it will not be applied upstream. As a result, we will need to maintain this diff in Ubuntu. By dropping this change, we will be able to finally sync checkinstall from Debian.

Changelog since current jaunty version 1.6.1-7ubuntu1:

checkinstall (1.6.1-8) unstable; urgency=low

  * Recommend make since it's the most used install tool. (Closes: #487964).
  * Use quilt for managing patches to upstream sources.
  * Allow Requires to be used in Debian. (Closes: #469639)
  * Turn off system translation by default, since it is currently broken.
  * Update the Vcs-* tags since we moved to Git.

 -- Felipe Sateler <email address hidden> Thu, 24 Jul 2008 14:34:06 -0400

Bhavani Shankar (bhavi) wrote :
Changed in checkinstall:
status: New → Confirmed
Nathan Handler (nhandler) wrote :

You don't need to include this change "Use quilt for managing patches to upstream sources." in your changelog entry. This was a Debian change, not an Ubuntu change. Also, now that Debian recommends make, there is no reason we need to Depend on make. Recommended packages are installed by default in intrepid.

Changed in checkinstall:
assignee: nobody → bhavi
importance: Undecided → Wishlist
status: Confirmed → Incomplete
Bhavani Shankar (bhavi) wrote :

Okay nathan :)

Changed in checkinstall:
assignee: bhavi → nobody
status: Incomplete → Confirmed
Bhavani Shankar (bhavi) wrote :

Update: Its a FTBFS on intrepid pbuilder.

Changed in checkinstall:
status: Confirmed → New
Changed in checkinstall:
status: New → Incomplete
Bhavani Shankar (bhavi) wrote :
Download full text (18.4 KiB)

UN: /bin/echo ['echo', 'Forking build subprocess...']
Forking build subprocess...
RUN: /usr/share/launchpad-buildd/slavebin/unpack-chroot ['unpack-chroot', '698347-1735660', '/home/buildd/filecache-default/afd16d064834ba16cf76892ae54fedc9689539ae']
Uncompressing the tarball...
Synching the system clock with the buildd NTP service...
22 Aug 13:50:54 ntpdate[1000]: adjust time server 10.211.37.1 offset 0.009185 sec
Unpacking chroot for build 698347-1735660
RUN: /usr/share/launchpad-buildd/slavebin/mount-chroot ['mount-chroot', '698347-1735660']
Mounting chroot for build 698347-1735660
RUN: /usr/share/launchpad-buildd/slavebin/apply-ogre-model ['apply-ogre-model', '698347-1735660', 'main']
Attempting OGRE for main in build-698347-1735660
RUN: /usr/share/launchpad-buildd/slavebin/override-sources-list ['override-sources-list', '698347-1735660', 'deb http://ppa.launchpad.net/emgent/ubuntu intrepid main', 'deb http://ftpmaster.internal/ubuntu intrepid main restricted universe multiverse', 'deb http://ftpmaster.internal/ubuntu intrepid-security main restricted universe multiverse', 'deb http://ftpmaster.internal/ubuntu intrepid-updates main restricted universe multiverse']
Overriding sources.list in build-698347-1735660
RUN: /usr/share/launchpad-buildd/slavebin/update-debian-chroot ['update-debian-chroot', '698347-1735660']
Updating debian chroot for build 698347-1735660
Get:1 http://ftpmaster.internal intrepid Release.gpg [189B]
Ign http://ppa.launchpad.net intrepid Release.gpg
Get:2 http://ftpmaster.internal intrepid-security Release.gpg [191B]
Get:3 http://ftpmaster.internal intrepid-updates Release.gpg [191B]
Get:4 http://ftpmaster.internal intrepid Release [65.9kB]
Get:5 http://ftpmaster.internal intrepid-security Release [37.0kB]
Get:6 http://ppa.launchpad.net intrepid Release [27.6kB]
Ign http://ppa.launchpad.net intrepid/main Packages
Get:7 http://ppa.launchpad.net intrepid/main Packages [3013B]
Get:8 http://ftpmaster.internal intrepid-updates Release [37.0kB]
Get:9 http://ftpmaster.internal intrepid/main Packages [1220kB]
Get:10 http://ftpmaster.internal intrepid/restricted Packages [7921B]
Get:11 http://ftpmaster.internal intrepid/universe Packages [4559kB]
Get:12 http://ftpmaster.internal intrepid/multiverse Packages [206kB]
Get:13 http://ftpmaster.internal intrepid-security/main Packages [14B]
Get:14 http://ftpmaster.internal intrepid-security/restricted Packages [14B]
Get:15 http://ftpmaster.internal intrepid-security/universe Packages [14B]
Get:16 http://ftpmaster.internal intrepid-security/multiverse Packages [14B]
Get:17 http://ftpmaster.internal intrepid-updates/main Packages [14B]
Get:18 http://ftpmaster.internal intrepid-updates/restricted Packages [14B]
Get:19 http://ftpmaster.internal intrepid-updates/universe Packages [14B]
Get:20 http://ftpmaster.internal intrepid-updates/multiverse Packages [14B]
Fetched 6164kB in 6s (1027kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
The following packages will be upgraded:
  libpam-foreground libpam-modules libpam-runtime libpam0g
4 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 500kB of archives.
Af...

Bhavani Shankar (bhavi) wrote :

Here is the modified one which fixes FTBFS :)

Changed in checkinstall:
status: Incomplete → Confirmed
Nathan Handler (nhandler) wrote :

Here is the build.log file of checkinstall 1.6.1-8 patched with Bhavani's latest debdiff. I was able to successfully build the package in an intrepid pbuilder.

Daniel Holbach (dholbach) wrote :

You do much more changes than you list in the changelog:

  * Merge from debian unstable, remaining changes: (LP: #258727)
    - Use /usr/bin/which instead of which.
  * Removed patch 18fix-locale-charset.diff to fix FTBFS.

 checkinstall | 12 +--
 checkinstall-1.6.1/debian/changelog | 96 +++++++++++++++++++++++++++++++
 checkinstall-1.6.1/debian/control | 4 -
 checkinstall-1.6.1/debian/patches/series | 1
 debian/patches/18fix-locale-charset.diff | 26 --------
 locale/checkinstall-de.po | 2
 locale/checkinstall-es.po | 2
 7 files changed, 106 insertions(+), 37 deletions(-)

Also you drop "Recommends: make".

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

Changed in checkinstall:
assignee: nobody → bhavi
status: Confirmed → Incomplete
Changed in checkinstall:
assignee: bhavi → nhandler
status: Incomplete → In Progress
Nathan Handler (nhandler) wrote :
description: updated
Nathan Handler (nhandler) wrote :

Please ignore all comments (except https://bugs.launchpad.net/ubuntu/+source/checkinstall/+bug/258727/comments/10). They were from when this bug report was requesting that checkinstall be merged. We are now able to sync checkinstall, so the comments are no longer valid.

Changed in checkinstall:
assignee: nhandler → nobody
status: In Progress → New
James Westby (james-w) wrote :

ACK from me.

Thanks,

James

Changed in checkinstall:
status: New → Confirmed
Steve Langasek (vorlon) wrote :

[Updating] checkinstall (1.6.1-7ubuntu1 [Ubuntu] < 1.6.1-8 [Debian])
 * Trying to add checkinstall...
  - <checkinstall_1.6.1-8.diff.gz: downloading from http://ftp.debian.org/debian/>
  - <checkinstall_1.6.1-8.dsc: downloading from http://ftp.debian.org/debian/>
  - <checkinstall_1.6.1.orig.tar.gz: already in distro - downloading from librarian>
I: checkinstall [universe] -> checkinstall_1.6.1-7ubuntu1 [universe].

Changed in checkinstall:
status: Confirmed → Fix Released
Artur Rona (ari-tczew) on 2009-11-28
affects: debian → checkinstall (Debian)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.