| 2012-06-21 13:00:57 |
Sylvain Pineau |
bug |
|
|
added bug |
| 2012-07-04 13:21:07 |
Brendan Donegan |
checkbox: status |
New |
Confirmed |
|
| 2012-07-04 13:21:10 |
Brendan Donegan |
checkbox: importance |
Undecided |
High |
|
| 2012-07-04 13:21:20 |
Brendan Donegan |
summary |
Add udisks2 support to scripts/removable_storage_watcher |
Add udisks2 support to scripts/removable_storage_* scripts |
|
| 2012-09-03 14:17:30 |
Zygmunt Krynicki |
checkbox: assignee |
|
Zygmunt Krynicki (zkrynicki) |
|
| 2012-09-04 07:43:28 |
Brendan Donegan |
checkbox: status |
Confirmed |
In Progress |
|
| 2012-09-04 13:28:53 |
Ara Pulido |
checkbox: milestone |
|
0.14.x |
|
| 2012-09-04 14:02:27 |
Zygmunt Krynicki |
attachment added |
|
dbus-monitor --system output captured while inserting a USB thumb drive on a quantal system https://bugs.launchpad.net/checkbox/+bug/1016035/+attachment/3292325/+files/device-inserted-quantal.txt |
|
| 2012-09-06 09:37:27 |
Zygmunt Krynicki |
branch linked |
|
lp:~zkrynicki/checkbox/fix-1016035 |
|
| 2012-09-18 14:34:36 |
Ara Pulido |
checkbox: importance |
High |
Critical |
|
| 2012-09-18 15:42:43 |
Ara Pulido |
checkbox: importance |
Critical |
High |
|
| 2012-09-25 09:27:46 |
Zygmunt Krynicki |
branch unlinked |
lp:~zkrynicki/checkbox/fix-1016035 |
|
|
| 2012-10-09 13:20:48 |
Zygmunt Krynicki |
checkbox: status |
In Progress |
Fix Committed |
|
| 2012-10-09 13:50:51 |
Ara Pulido |
summary |
Add udisks2 support to scripts/removable_storage_* scripts |
Every script that uses udisk in currently broken in Quantal |
|
| 2012-10-09 17:50:13 |
Launchpad Janitor |
branch linked |
|
lp:~roadmr/ubuntu/quantal/checkbox/0.14.9 |
|
| 2012-10-09 17:55:10 |
Daniel Manrique |
attachment added |
|
checkbox_0.14.9_amd64.build https://bugs.launchpad.net/checkbox/+bug/1016035/+attachment/3390424/+files/checkbox_0.14.9_amd64.build |
|
| 2012-10-09 19:46:40 |
Daniel Manrique |
description |
udisks2 will be the default backend for gnome/unity in Quantal:
https://wiki.ubuntu.com/QuantalQuetzal/TechnicalOverview/Alpha1#Ubuntu
The current version works well for udisks version 1 but we should add the support for udisks2 as well:
http://udisks.freedesktop.org/docs/latest/ref-dbus.html |
udisks2 will be the default backend for gnome/unity in Quantal:
https://wiki.ubuntu.com/QuantalQuetzal/TechnicalOverview/Alpha1#Ubuntu
The current version works well for udisks version 1 but we should add the support for udisks2 as well:
http://udisks.freedesktop.org/docs/latest/ref-dbus.html
Udisks2 does not provide some bits of information that udisks1 does, and which are necessary to have coverage of all device types that checkbox can test (usb 2.0 and 3.0, memory cards, esata, firewire). So the code is somewhat extensive to account for all these use cases.
A few changes to job definitions were needed (the addition of --memorycard parameter) since it's needed for memory cards to be properly recognized.
We tested building the package (build log is attached as a comment), installing and upgrading (logs also as comments). We also redid our manual testing by launching the modified scripts (removable_storage_watcher and removable_storage_test) with various parameters (especially the -m and -p parameters used to test for devices with specific speeds, to validate in particular that usb 3.0 devices are testable) and different kinds of devices. The scripts work well and as expected. |
|
| 2012-10-09 19:46:50 |
Daniel Manrique |
bug |
|
|
added subscriber Ubuntu Release Team |
| 2012-10-09 19:47:28 |
Daniel Manrique |
bug task added |
|
checkbox (Ubuntu) |
|
| 2012-10-09 19:48:35 |
Daniel Manrique |
summary |
Every script that uses udisk in currently broken in Quantal |
[FFe] Every script that uses udisk in currently broken in Quantal |
|
| 2012-10-09 19:48:43 |
Kate Stewart |
summary |
[FFe] Every script that uses udisk in currently broken in Quantal |
[FFE] Every script that uses udisk in currently broken in Quantal |
|
| 2012-10-09 21:00:42 |
Daniel Manrique |
description |
udisks2 will be the default backend for gnome/unity in Quantal:
https://wiki.ubuntu.com/QuantalQuetzal/TechnicalOverview/Alpha1#Ubuntu
The current version works well for udisks version 1 but we should add the support for udisks2 as well:
http://udisks.freedesktop.org/docs/latest/ref-dbus.html
Udisks2 does not provide some bits of information that udisks1 does, and which are necessary to have coverage of all device types that checkbox can test (usb 2.0 and 3.0, memory cards, esata, firewire). So the code is somewhat extensive to account for all these use cases.
A few changes to job definitions were needed (the addition of --memorycard parameter) since it's needed for memory cards to be properly recognized.
We tested building the package (build log is attached as a comment), installing and upgrading (logs also as comments). We also redid our manual testing by launching the modified scripts (removable_storage_watcher and removable_storage_test) with various parameters (especially the -m and -p parameters used to test for devices with specific speeds, to validate in particular that usb 3.0 devices are testable) and different kinds of devices. The scripts work well and as expected. |
udisks2 will be the default backend for gnome/unity in Quantal:
https://wiki.ubuntu.com/QuantalQuetzal/TechnicalOverview/Alpha1#Ubuntu
The current version works well for udisks version 1 but we should add the support for udisks2 as well:
http://udisks.freedesktop.org/docs/latest/ref-dbus.html
== Importance==
This feature is pretty important to have as currently all the storage tests are broken; they do not work on Quantal and will produce failing results even for users with working hardware. This code enables these features to work correctly under Quantal.
Udisks2 does not provide some bits of information that udisks1 does, and which are necessary to have coverage of all device types that checkbox can test (usb 2.0 and 3.0, memory cards, esata, firewire). So the code is somewhat extensive to account for all these use cases.
A few changes to job definitions were needed (the addition of --memorycard parameter) since it's needed for memory cards to be properly recognized.
== Risk assessment ==
The udisks2 code was developed in an incremental fashion. Due to the
requirement that the same code base keep working on Ubuntu 12.04, the changes
were done carefully to minimize breakage.
Since udisks2 introduces a few API changes and removes certain properties the
old code depended on, particularly speed reporting which is needed for proper
USB 3.0 testing, some refactoring was needed to abstract these changes and keep
the code as clean as possible. Unit tests for these components help ensure
there's no breakage while changing code. While developing, many tests with
actual hardware were performed to ensure that device detection and testing was
reliable and failure scenarios were handled properly.
Once all the parts were ready to land, the udisks2 code was integrated and
merged into checkbox. During this phase the code continued to be tested with
actual hardware to guarantee that all the pieces "fit together" correctly and
the end result worked adequately.
Once everything was in place, two sets of tests were performed: a set of tests
to ensure the features worked as required, and validate that nothing had broken
during final integration. Finally, when preparing the Ubuntu upload, a package
was built and the scripts were tested from the sort of installation an end-user
would see.
Since the code was very extensively tested during development, we believe the
risk of including this to be rather low, and any impact would be localized to
the storage device testing section of checkbox, so the symptoms would in any
case be very easy to identify and clear to solve. Despite this, during testing
all the code behaved properly so if any, the potential remaining problems
should be corner-cases unlikely to have a widespread impact.
== Testing ==
We tested building the package (build log is attached as a comment), installing and upgrading (logs also as comments). We also redid our manual testing by launching the modified scripts (removable_storage_watcher and removable_storage_test) with various parameters (especially the -m and -p parameters used to test for devices with specific speeds, to validate in particular that usb 3.0 devices are testable) and different kinds of devices. The scripts work well and as expected. |
|
| 2012-10-09 22:35:14 |
Launchpad Janitor |
checkbox (Ubuntu): status |
New |
Fix Released |
|
| 2012-10-09 23:18:25 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/checkbox |
|
| 2012-10-11 01:46:58 |
Scott Kitterman |
removed subscriber Ubuntu Release Team |
|
|
|
| 2012-11-01 15:02:00 |
Brendan Donegan |
checkbox: status |
Fix Committed |
Fix Released |
|
| 2013-03-26 00:58:04 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/raring-proposed/checkbox |
|
