From c55d2f32bb1635e14993a42bb023d6beb2c5c6ee Thu Dec 31 09:00:17 2020 From: Gerald Yang Date: Thu, 31 Dec 2020 09:00:17 +0000 Subject: [PATCH]: Remove logging every slow request details to monitors recent change https://tracker.ceph.com/issues/43975 was made to slow request logging to include detail on each operation in the cluster logs. With this change, detail for every slow request is always sent to the monitors and added to the cluster logs. This does not scale. Large, high-throughput clusters can overwhelm their monitors with spurious logs in the event of a performance issue. Disrupting the monitors can then cause further instability in the cluster. This SRU reverts the cluster logging of every slow request the osd is processing. The slow request clog change was added in nautilus (14.2.10) and octopus (15.2.0). Signed-off-by: Gerald Yang --- src/osd/OSD.cc | 1 - 1 file changed, 1 deletion(-) Bug-Ubuntu: https://bugs.launchpad.net/bugs/1909162 diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index 5e6064e0ef..eeaf7e0834 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -8091,7 +8091,6 @@ vector OSD::get_health_metrics() << " currently " << op.state_string(); lgeneric_subdout(cct,osd,20) << ss.str() << dendl; - clog->warn() << ss.str(); slow++; if (!oldest_op || op.get_initiated() < oldest_op->get_initiated()) { oldest_op = &op; -- 2.17.1