Packaging: incorrect /etc/default

[Peter Sabaini]

[Impact]
Its not possible to pass environment variables to ceph daemons due to mis-installation of /etc/default/ceph (its a nested dir, not a file).

[Test Case]
sudo apt-get install ceph
ls -la /etc/default/ceph

[Regression Potential]
Medium - upgrades, due to nested ceph/ceph are a little complex, but the packaging maintainer scripts should deal with it.

[Original Bug Report]
I am running ceph 10.2 on trusty (via upstart). The /etc/default are:

# ls -la /etc/default/ceph/ceph
-rw-r--r-- 1 root root 325 Apr 29 19:54 /etc/default/ceph/ceph

Is ceph/ceph really intended? The upstart conf has this in it

# fgrep /etc/default /etc/init/ceph-osd.conf
    test -f /etc/default/ceph && . /etc/default/ceph

The debian/rules seem to create that dir, fwiw:

 install -d -m0755 debian/ceph-common/etc/default/ceph
 install -m0644 etc/default/ceph debian/ceph-common/etc/default/ceph

# apt-cache policy ceph
ceph:
  Installed: 10.2.0-0ubuntu0.16.04.1~cloud0
  Candidate: 10.2.0-0ubuntu0.16.04.1~cloud0
  Version table:
 *** 10.2.0-0ubuntu0.16.04.1~cloud0 0
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu/ trusty-updates/mitaka/main amd64 Packages
        100 /var/lib/dpkg/status
     0.80.11-0ubuntu1.14.04.1 0
        500 http://archive.ubuntu.com//ubuntu/ trusty-updates/main amd64 Packages
     0.79-0ubuntu1 0
        500 http://archive.ubuntu.com//ubuntu/ trusty/main amd64 Packages

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ceph - 10.2.1-0ubuntu1

---------------
ceph (10.2.1-0ubuntu1) yakkety; urgency=medium

  * New upstream version (LP: #1585660).
    - d/p/drop-user-group-osd-prestart.patch: Dropped, included upstream.
  * d/rules,ceph-common.install: Ensure that /etc/default/ceph is a file
    and not a directory (LP: #1587516).

 -- James Page <email address hidden> Mon, 06 Jun 2016 09:23:35 +0100

[Martin Pitt (pitti)]

Hello Peter, or anyone else affected,

Accepted ceph into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ceph/10.2.2-0ubuntu0.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[James Page (james-page)]

Upgrading to the version in proposed does not switch the dir -> file as designed; the version checks in the maintainer scripts are against 10.2.0, not 10.2.2 as now in proposed.

My bad - I validated the upgrade path, and then did the new point release.

[James Page (james-page)]

I've uploaded a 0.16.04.2 with the required fixes; I've tested upgrades from the existing ceph package in -updates and I think it works as intended.

[Chris J Arges (arges)]

Hello Peter, or anyone else affected,

Accepted ceph into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ceph/10.2.2-0ubuntu0.16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[James Page (james-page)]

Retested .2 upload - upgrades from current version in -updates DTRT with regards to switching /etc/default/ceph from a dir to a file. Verification completed.

[Martin Pitt (pitti)]

The verification of the Stable Release Update for ceph has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ceph - 10.2.2-0ubuntu0.16.04.2

---------------
ceph (10.2.2-0ubuntu0.16.04.2) xenial; urgency=medium

  * d/ceph-common.{preinst,postinst,postrm}: Fix version checks in maintainer
    scripts to ensure that /etc/default/ceph actually gets installed on
    upgrade (LP: #1587516).

ceph (10.2.2-0ubuntu0.16.04.1) xenial; urgency=medium

  * New upstream stable release (LP: #1585660).
    - d/p/drop-user-group-osd-prestart.patch: Dropped, included upstream.
    - d/ceph.install: Drop install of 60-ceph-partuuid-workaround.rules, no
      longer needed and not shipped by upstream.
  * Rename /etc/default/ceph/ceph -> /etc/default/ceph (LP: #1587516):
    - d/rules,ceph-common.install: Ensure that /etc/default/ceph is a file
      and not a directory.
    - d/ceph-common.{preinst,postinst,postrm}: Ensure that rename of
      /etc/default/ceph/ceph -> /etc/default/ceph is handled correctly
      and that any end-user changes are preserved.

 -- James Page <email address hidden> Tue, 19 Jul 2016 10:32:34 +0100

[James Page (james-page)]

The verification of the Stable Release Update for ceph has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[James Page (james-page)]

This bug was fixed in the package ceph - 10.2.2-0ubuntu0.16.04.2~cloud0
---------------

 ceph (10.2.2-0ubuntu0.16.04.2~cloud0) trusty-mitaka; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 ceph (10.2.2-0ubuntu0.16.04.2) xenial; urgency=medium
 .
   * d/ceph-common.{preinst,postinst,postrm}: Fix version checks in maintainer
     scripts to ensure that /etc/default/ceph actually gets installed on
     upgrade (LP: #1587516).