| 2007-08-04 15:14:01 |
Colin Watson |
bug |
|
|
added bug |
| 2007-08-04 15:14:29 |
Colin Watson |
bug |
|
|
assigned to cdrkit (Ubuntu) |
| 2007-08-04 15:15:26 |
Colin Watson |
bug |
|
|
assigned to cdrkit (Debian) |
| 2007-08-04 15:17:02 |
Colin Watson |
cdrtools: status |
New |
Invalid |
|
| 2007-08-04 15:17:02 |
Colin Watson |
cdrtools: statusexplanation |
|
|
|
| 2007-08-04 15:17:16 |
Colin Watson |
cdrtools: status |
New |
Invalid |
|
| 2007-08-04 15:17:16 |
Colin Watson |
cdrtools: statusexplanation |
|
|
|
| 2007-08-04 15:17:39 |
Colin Watson |
cdrkit: status |
New |
Invalid |
|
| 2007-08-04 15:17:39 |
Colin Watson |
cdrkit: statusexplanation |
|
|
|
| 2007-08-04 15:20:15 |
Colin Watson |
description |
The build machine behind cdimage.ubuntu.com was recently upgraded to edgy/amd64. While testing the new system, I found that mkisofs segfaulted while trying to build Ubuntu alternate install CD images. Investigation showed that this is due to incorrect linked list code used while constructing the JTE include and exclude lists for jigdo file generation. This is unlikely to affect normal users of mkisofs, but affects those trying to build Debian or Ubuntu CD images.
This is also Debian bug 411873, and I've sent a patch there.
Since the crash is rather dependent on precise details of stack layout, it's not necessarily easy to reproduce directly. However, valgrind picks it up with no trouble. Steps to reproduce on an edgy system with mkisofs and valgrind installed (for feisty and gutsy, substitute "genisoimage" for "mkisofs" throughout:
mkdir -p /tmp/mkisofs-test
cd /tmp/mkisofs-test
mkdir -p t/pool
dd if=/dev/zero of=t/file bs=1024 count=100
touch md5
valgrind mkisofs -o t.iso -jigdo-jigdo t.jigdo -jigdo-template t.template -md5-list md5 -jigdo-force-md5 /pool/ t
The output will contain an error similar to the following (exact numbers are unimportant):
==8624== Conditional jump or move depends on uninitialised value(s)
==8624== at 0x42BB38: (within /usr/bin/mkisofs)
==8624== by 0x40E7D6: (within /usr/bin/mkisofs)
==8624== by 0x40EBD9: (within /usr/bin/mkisofs)
==8624== by 0x40460E: main (in /usr/bin/mkisofs)
==8624== by 0x4C570C3: (below main) (in /lib/libc-2.4.so)
The patch affects only JTE code, so (barring regressions due simply to rebuilding cdrtools), other uses of mkisofs will not be affected. Typical uses of mkisofs to build simple ISO images from a tree of files on disk do not use JTE; it is an advanced feature for use by distributors of heavily-downloaded ISO images. |
The build machine behind cdimage.ubuntu.com was recently upgraded to edgy/amd64. While testing the new system, I found that mkisofs segfaulted while trying to build Ubuntu alternate install CD images. Investigation showed that this is due to incorrect linked list code used while constructing the JTE include and exclude lists for jigdo file generation. This is unlikely to affect normal users of mkisofs, but affects those trying to build Debian or Ubuntu CD images.
This is also Debian bug 411873, and I've sent a patch there to fix the linked list generation. I have applied this patch in cdrkit 9:1.1.6-1ubuntu1 in gutsy. Corresponding patches against edgy and feisty are attached here.
Since the crash is rather dependent on precise details of stack layout, it's not necessarily easy to reproduce directly. However, valgrind picks it up with no trouble. Steps to reproduce on an edgy system with mkisofs and valgrind installed (for feisty and gutsy, substitute "genisoimage" for "mkisofs" throughout:
mkdir -p /tmp/mkisofs-test
cd /tmp/mkisofs-test
mkdir -p t/pool
dd if=/dev/zero of=t/file bs=1024 count=100
touch md5
valgrind mkisofs -o t.iso -jigdo-jigdo t.jigdo -jigdo-template t.template -md5-list md5 -jigdo-force-md5 /pool/ t
The output will contain an error similar to the following (exact numbers are unimportant):
==8624== Conditional jump or move depends on uninitialised value(s)
==8624== at 0x42BB38: (within /usr/bin/mkisofs)
==8624== by 0x40E7D6: (within /usr/bin/mkisofs)
==8624== by 0x40EBD9: (within /usr/bin/mkisofs)
==8624== by 0x40460E: main (in /usr/bin/mkisofs)
==8624== by 0x4C570C3: (below main) (in /lib/libc-2.4.so)
The patch affects only JTE code, so (barring regressions due simply to rebuilding cdrtools), other uses of mkisofs will not be affected. Typical uses of mkisofs to build simple ISO images from a tree of files on disk do not use JTE; it is an advanced feature for use by distributors of heavily-downloaded ISO images. |
|
| 2007-08-04 15:20:05 |
Colin Watson |
cdrkit: status |
New |
Fix Released |
|
| 2007-08-04 15:24:29 |
Colin Watson |
bug |
|
|
added attachment '130376.edgy-proposed.patch' (edgy-proposed patch) |
| 2007-08-04 15:27:12 |
Colin Watson |
bug |
|
|
added attachment '130376.feisty-proposed.patch' (feisty-proposed patch) |
| 2007-08-04 15:27:36 |
Colin Watson |
title |
crash while checking MD5sums on include list |
crash while checking MD5sums on jigdo include list |
|
| 2007-08-04 15:27:58 |
Colin Watson |
cdrkit: importance |
Undecided |
High |
|
| 2007-08-04 15:27:58 |
Colin Watson |
cdrkit: statusexplanation |
|
|
|
| 2007-08-04 15:28:13 |
Colin Watson |
cdrtools: importance |
Undecided |
High |
|
| 2007-08-04 15:28:13 |
Colin Watson |
cdrtools: statusexplanation |
|
|
|
| 2007-08-04 15:28:25 |
Colin Watson |
cdrkit: importance |
Undecided |
High |
|
| 2007-08-04 15:28:25 |
Colin Watson |
cdrkit: statusexplanation |
|
|
|
| 2007-08-04 15:29:38 |
Colin Watson |
description |
The build machine behind cdimage.ubuntu.com was recently upgraded to edgy/amd64. While testing the new system, I found that mkisofs segfaulted while trying to build Ubuntu alternate install CD images. Investigation showed that this is due to incorrect linked list code used while constructing the JTE include and exclude lists for jigdo file generation. This is unlikely to affect normal users of mkisofs, but affects those trying to build Debian or Ubuntu CD images.
This is also Debian bug 411873, and I've sent a patch there to fix the linked list generation. I have applied this patch in cdrkit 9:1.1.6-1ubuntu1 in gutsy. Corresponding patches against edgy and feisty are attached here.
Since the crash is rather dependent on precise details of stack layout, it's not necessarily easy to reproduce directly. However, valgrind picks it up with no trouble. Steps to reproduce on an edgy system with mkisofs and valgrind installed (for feisty and gutsy, substitute "genisoimage" for "mkisofs" throughout:
mkdir -p /tmp/mkisofs-test
cd /tmp/mkisofs-test
mkdir -p t/pool
dd if=/dev/zero of=t/file bs=1024 count=100
touch md5
valgrind mkisofs -o t.iso -jigdo-jigdo t.jigdo -jigdo-template t.template -md5-list md5 -jigdo-force-md5 /pool/ t
The output will contain an error similar to the following (exact numbers are unimportant):
==8624== Conditional jump or move depends on uninitialised value(s)
==8624== at 0x42BB38: (within /usr/bin/mkisofs)
==8624== by 0x40E7D6: (within /usr/bin/mkisofs)
==8624== by 0x40EBD9: (within /usr/bin/mkisofs)
==8624== by 0x40460E: main (in /usr/bin/mkisofs)
==8624== by 0x4C570C3: (below main) (in /lib/libc-2.4.so)
The patch affects only JTE code, so (barring regressions due simply to rebuilding cdrtools), other uses of mkisofs will not be affected. Typical uses of mkisofs to build simple ISO images from a tree of files on disk do not use JTE; it is an advanced feature for use by distributors of heavily-downloaded ISO images. |
The build machine behind cdimage.ubuntu.com was recently upgraded to edgy/amd64. While testing the new system, I found that mkisofs segfaulted while trying to build Ubuntu alternate install CD images. Investigation showed that this is due to incorrect linked list code used while constructing the JTE include and exclude lists for jigdo file generation. This is unlikely to affect normal users of mkisofs, but affects those trying to build Debian or Ubuntu CD images. I would like to propose this for a stable release update in order to fix Ubuntu's production CD image building system without the need for a local build of mkisofs.
This is also Debian bug 411873, and I've sent a patch there to fix the linked list generation. I have applied this patch in cdrkit 9:1.1.6-1ubuntu1 in gutsy. Corresponding patches against edgy and feisty are attached here.
Since the crash is rather dependent on precise details of stack layout, it's not necessarily easy to reproduce directly. However, valgrind picks it up with no trouble. Steps to reproduce on an edgy system with mkisofs and valgrind installed (for feisty and gutsy, substitute "genisoimage" for "mkisofs" throughout:
mkdir -p /tmp/mkisofs-test
cd /tmp/mkisofs-test
mkdir -p t/pool
dd if=/dev/zero of=t/file bs=1024 count=100
touch md5
valgrind mkisofs -o t.iso -jigdo-jigdo t.jigdo -jigdo-template t.template -md5-list md5 -jigdo-force-md5 /pool/ t
The output will contain an error similar to the following (exact numbers are unimportant):
==8624== Conditional jump or move depends on uninitialised value(s)
==8624== at 0x42BB38: (within /usr/bin/mkisofs)
==8624== by 0x40E7D6: (within /usr/bin/mkisofs)
==8624== by 0x40EBD9: (within /usr/bin/mkisofs)
==8624== by 0x40460E: main (in /usr/bin/mkisofs)
==8624== by 0x4C570C3: (below main) (in /lib/libc-2.4.so)
The patch affects only JTE code, so (barring regressions due simply to rebuilding cdrtools), other uses of mkisofs will not be affected. Typical uses of mkisofs to build simple ISO images from a tree of files on disk do not use JTE; it is an advanced feature for use by distributors of heavily-downloaded ISO images. |
|
| 2007-08-04 15:29:54 |
Colin Watson |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2007-08-05 17:00:27 |
Martin Pitt |
cdrkit: status |
New |
In Progress |
|
| 2007-08-05 17:00:27 |
Martin Pitt |
cdrkit: assignee |
|
kamion |
|
| 2007-08-05 17:00:27 |
Martin Pitt |
cdrkit: statusexplanation |
|
Thanks, Colin! The patch makes perfect sense. Edgy's patch is fine as it is. Can you please do the XSBC-Original-Maintainer: dance for feisty?
Please go ahead and upload. |
|
| 2007-08-06 08:26:39 |
Bug Watch Updater |
cdrkit: status |
Unknown |
New |
|
| 2007-08-10 09:58:00 |
Colin Watson |
cdrtools: status |
New |
In Progress |
|
| 2007-08-10 09:58:00 |
Colin Watson |
cdrtools: statusexplanation |
|
Both uploaded, including the Maintainer change for feisty-proposed. |
|
| 2007-08-10 10:26:27 |
Martin Pitt |
cdrkit: status |
In Progress |
Fix Committed |
|
| 2007-08-10 10:26:27 |
Martin Pitt |
cdrkit: statusexplanation |
Thanks, Colin! The patch makes perfect sense. Edgy's patch is fine as it is. Can you please do the XSBC-Original-Maintainer: dance for feisty?
Please go ahead and upload. |
cdrkit accepted into feisty-proposed, please go ahead with QA testing. |
|
| 2007-08-10 10:26:47 |
Martin Pitt |
cdrtools: status |
In Progress |
Fix Committed |
|
| 2007-08-10 10:26:47 |
Martin Pitt |
cdrtools: statusexplanation |
Both uploaded, including the Maintainer change for feisty-proposed. |
cdrtools accepted into edgy-proposed, please go ahead with QA testing. |
|
| 2007-08-10 11:03:37 |
Colin Watson |
cdrkit: status |
Fix Committed |
Fix Released |
|
| 2007-08-10 11:03:37 |
Colin Watson |
cdrtools: status |
Fix Committed |
Fix Released |
|
| 2007-08-10 13:08:43 |
Martin Pitt |
cdrkit: status |
Fix Released |
Fix Committed |
|
| 2007-08-10 13:08:43 |
Martin Pitt |
cdrkit: statusexplanation |
cdrkit accepted into feisty-proposed, please go ahead with QA testing. |
|
|
| 2007-08-10 13:08:51 |
Martin Pitt |
cdrtools: status |
Fix Released |
Fix Committed |
|
| 2007-08-10 13:08:51 |
Martin Pitt |
cdrtools: statusexplanation |
cdrtools accepted into edgy-proposed, please go ahead with QA testing. |
|
|
| 2007-11-13 10:10:23 |
Martin Pitt |
cdrtools: status |
Fix Committed |
Fix Released |
|
| 2007-11-13 10:10:41 |
Martin Pitt |
cdrkit: status |
Fix Committed |
Fix Released |
|
| 2008-03-18 09:00:57 |
Bug Watch Updater |
cdrkit: status |
New |
Fix Released |
|
| 2009-07-09 04:15:24 |
Launchpad Janitor |
branch linked |
|
lp:~ubuntu-branches/ubuntu/feisty/cdrkit/feisty-proposed |
|
| 2009-07-09 04:15:26 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/karmic/cdrkit |
|
| 2009-08-22 20:56:07 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/edgy-updates/cdrtools |
|
