cdbs-edit-patch fails due to debian/rules whitespace

Bug #62623 reported by Forest Bond on 2006-09-27
2
Affects Status Importance Assigned to Milestone
cdbs (Ubuntu)
Medium
Martin Pitt

Bug Description

With this line in debian/rules:

DEB_TAR_SRCDIR := snd-8

cdbs-edit-patch inappropriately executes:

diff -Nur snd-8.4/build-tree/ snd-8 snd-8.4.new/build-tree/ snd-8 >> /home/fab/work/debs/snd/build/snd-8.4/debian/patches/newpatch.patch

Naturally, this gives an error:

diff: extra operand `snd-8.4.new/build-tree/'
diff: Try `diff --help' for more information.

Changes debian/rules line to this fixes the problem:

DEB_TAR_SRCDIR :=snd-8

(note no space before snd-8)

cdbs-edit-patch should account for whitespace in this string, correct? Or perhaps the whitespace shouldn't be there at all? Should make be removing it automatically?

-Forest

Martin Pitt (pitti) on 2006-09-27
Changed in cdbs:
assignee: nobody → pitti
importance: Undecided → Medium
status: Unconfirmed → In Progress
Martin Pitt (pitti) on 2006-10-02
Changed in cdbs:
status: In Progress → Fix Committed
Martin Pitt (pitti) wrote :

 cdbs (0.4.46ubuntu6) edgy; urgency=low
 .
   * scripts/cdbs-edit-patch: Fix whitespace handling of DEB_TAR_SRCDIR.
     Closes: LP#6262
   * 1/rules/tarball.mk.in: Remove debian/stamp-patch-*, so that cleaning a
     built source works when using simple-patchsys.mk.

Changed in cdbs:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers