cbmc 5.84.0-4 FTBFS on all architectures

[Danilo Egea Gondolfo]

cbmc is failing to build on all architectures for different reasons.

First it will fail due to some optional<T> variables that the compiler is saying are MAYBE uninitialized (-Werror=maybe-uninitialized). Adding -Wno-error=maybe-uninitialized to the CXX_FLAGS will fix the build on amd64 only. Which is already working on Debian.

On all the other archs we support, after adding the flag to disable the error, it will fail due to assertions and unit tests that are not passing.

[Danilo Egea Gondolfo (danilogondolfo)]

Adding the patch to fix the build on amd64.

It still needs more work to fix the rest. They are also failing on Debian.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "cbmc.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Benjamin Drung (bdrung)]

Is there a reason why you only disable the specific warning instead of dropping -Werror? Using -Werror in package build is not recommended, because it can break the package build on compiler updates. This has been discussed several times, but I failed to find some documentation to read up.

Please re-subscribe ~ubuntu-sponsors once you have address my comment.

[Benjamin Drung (bdrung)]

https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend/ gives a good reasoning against -Werror in the packaging context.