[Maverick] ubiquityhooks/30accessibility script copyes wrong place the live user orca settings during installation when choosed some blind profiles

[Attila Hammer]

Binary package hint: casper

Dear Developers,

In Orca 2.32 version the Orca preferences directory is changed. Prewious Orca versions stored the preferences with userhomedirectory/.orca folder.
Now, this is changed with 2.32 version, the new settings place is following:
userhomedirectory/.local/share/orca
This is true with gdm configuration directory, the right place Orca settings directori is /var/lib/gdm/.local/share/orca.

The casper source package ubiquityhooks/30accessibility script copyes live user Orca settings during installation with wrong places with some blindness related profiles. The problem is following: forgotted add with end of needed paths the /.local/share part.

When casper package is builded, this script have the Ubuntu Maverick live cd /usr/lib/ubiquity/target-config directory.

I maked a patch with hopefuly fix this problem with all places, I attaching this patch.

Attila

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: casper 1.244
ProcVersionSignature: Ubuntu 2.6.35-22.33-generic 2.6.35.4
Uname: Linux 2.6.35-22-generic i686
Architecture: i386
Date: Wed Sep 29 05:42:40 2010
LiveMediaBuild: Ubuntu 10.10 "Maverick Meerkat" - Release Candidate i386 (20100928)
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: casper

[Attila Hammer (hammera)]

This second rewision is working right, I tested with a clean installation a patched /usr/lib/ubiquity/target-config/30accessibility script.
This final revision fixing following problems my clean installed system:
1. Live user setted Orca settings again right place copyed with new installed system (first created user home/.local/share directory and /var/lib/gdm/.local/share directory).
2. Accessible login is working perfect again when I use my patched 30accessibility script during installation. Live user orca settings is migrated right the new installed system /var/lib/gdm/.local/share directory.

Please commit this final revision if this is possible.

Attila

[Luke Yelavich (themuso)]

Ok, thanks for your work. Subscribing ubuntu-release to get final approval. Patch tested and works here.

[Colin Watson (cjwatson)]

This is OK release-wise. However, there's one mistake that I can see here:

                                else
                                        mkdir -p /target/home/$TARGET_USERNAME/.local/share/orca
+ mkdir -p /var/lib/gdm/.local/share/orca
                                        echo "import orca.settings" >> /target/home/$TARGET_USERNAME/.local/share/orca/user-settings.py
                                        echo "orca.settings.enableSpeech = False" >> /target/home/$TARGET_USERNAME/.local/share/orca/user-settings.py
                                        echo "orca.settings.enableBraille = True" >> /target/home/$TARGET_USERNAME/.local/share/orca/user-settings.py
                                        chroot /target chown -R $TARGET_USERNAME.$TARGET_USERNAME /home/$TARGET_USERNAME/.local/share/orca
- cp -r /home/$TARGET_USERNAME/.local/share/orca /target/var/lib/gdm
+ cp -r /home/$TARGET_USERNAME/.local/share/orca /target/var/lib/gdm/.local/share/orca
                                        chroot /target chown -R gdm.gdm /var/lib/gdm/.local/share/orca
                                fi

This will result in /target/var/lib/gdm/.local/share/orca/orca/ being created. I think if you just don't add that mkdir then it should work?

[Colin Watson (cjwatson)]

Incidentally, it would be clearer and more robust if you put a trailing slash on cp target directories that you expect to exist already, e.g.:

+ cp -r /home/$TARGET_USERNAME/.local/share/orca /target/var/lib/gdm/.local/share/

[Attila Hammer (hammera)]

Colin, thank you the comments, sorry the mistake.
Luke, you do this changes and you have time to testing Colin wroted changes?
Unfortunately this day I am not in home, so I am not have this day
enough time to do a clean installation to see accessible login is
working right or not when doed this changes.
What the final date with need doing this new patch and final test?

Attila

[Colin Watson (cjwatson)]

There's a revised upload in the queue, which looks good (the mkdir is still there, but I've confirmed that the changed arguments to 'cp -r' will work).

[Launchpad Janitor (janitor)]

This bug was fixed in the package casper - 1.248

---------------
casper (1.248) maverick; urgency=low

  * ubiquity-hooks/30accessibility: Create .local/share subdirectory structure
    before copying files. Also copy orca files to ~/.local/share, instead
    ~/. Thanks to Attila Hammer for the patch. (LP: #650846)
 -- Luke Yelavich <email address hidden> Tue, 05 Oct 2010 15:35:35 +1100

[Colin Watson (cjwatson)]

Changes after tomorrow will probably be impractical to get into the release. Realistically any further change needed after this evening is unlikely to make it.