missing quotes confuses try_snap
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
casper (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: casper
try_snap is looking for a cow_device but when it does not find one, and $dev is "" (empty) it falsely starts treating the empty device as a block device, with a bunch of follow-up errors.
Intuitive or not, [ -b ] is true but [ -b "" ] is false.
casper-log:
+ dev=
+ [ -b ]
+ echo
+ grep -qs loop
+ snapdev=
+ do_snap_copy /root ROOT
+ fromdev=
+ todir=/root
+ snap_type=ROOT
+ fs_size used
+ dev=
+ mountp=
+ used=used
+ [ -z ]
+ where_is_mounted
+ device=
+ grep -q ^ /proc/mounts
+ return 1
+ mountp=
+ [ 1 -gt 0 ]
+ mountp=
+ mkdir -p /mnt/tmp_fs_size
+ get_fstype
+ local FSTYPE
+ local FSSIZE
/init: line 1: can't open : no such file
+ fstype
+ eval
+ [ != unknown ]
+ echo
+ return 0
+ mount -t -o ro /mnt/tmp_fs_size
ProblemType: Bug
Architecture: i386
Date: Sat Sep 5 10:54:00 2009
DistroRelease: Ubuntu 9.10
Package: casper 1.189
ProcEnviron:
LANG=en_US.UTF-8
SHELL=/bin/bash
ProcVersionSign
SourcePackage: casper
Uname: Linux 2.6.31-9-generic i686
Related branches
- Ubuntu Core Development Team: Pending requested
- Diff: None lines
Changed in casper (Ubuntu): | |
status: | New → Fix Committed |
This bug was fixed in the package casper - 1.190
---------------
casper (1.190) karmic; urgency=low
[ Colin Watson ]
* Don't produce an invalid sed program when trying to remove an applet
which isn't in the panel (LP: #406188).
[ Tormod Volden ]
* do not remount filesystems that already have been probed when
searching for the livefs (LP: #424464)
* Fix quoting in try_snap (LP: #424742).
* Silence error messages for non-existent device nodes (LP: #425159).
-- Colin Watson <email address hidden> Mon, 07 Sep 2009 13:10:53 +0100