[SRU] Missing build dep libsndfile1-dev discovered

[Erich Eickmeyer]

[Impact]

 * Users have reported the inability to use soundfonts with Carla hosted allowing them to make sound which they weren't before.

 * Backporting this to the stable release would fix the problem.

 * The upload simply adds libsndfile1-dev as a build dependency, also includes an upstream patch from the author to fix incompatibilities with lsp-plugins.

[Test Case]

 * Add any soundfont-utilizing synthesizer plugin to Carla, patch audio out to system out, attempt to play notes either using a MIDI keyboard or using the canvas keyboard in Carla. Carla gives the following error: ad_open(): fatal: no decoder backend available

 * Using the same procedures after the libsndfile1-dev build dependency is added should result in actual notes being produced.

[Regression Potential]

 * Adding libsndfile1-dev as a build dependency allows synthesizer plugins to actually make sound, which they weren't before, but instead were causing the aforementioned error. This is primarily to allow said synthesizer to use sfz sound fonts. I see no regression potential here.

 * Adding the patch from the upstream developer (in debian/patches) fixes a compatibility issue with lsp-plugins in which the plugins were not behaving correctly in some cases. This has been tested to work upstream, and is included in the beta version of Carla 2.1. No regression here as it fixes an existing bug upstream.

 * Had to fix the debian/rules file to allow the wine bridges to build against the version of wine included in the archives due to a bug in said wine package. Mostly a workaround, but allows build to take place. If there is a regression here, I do not see it in my testing. (built correctly in ppa:ubuntustudio-dev/autobuild)

[Other Information]

 * Upload includes a patch from upstream developer to fix compatibility issues with lsp-plugins, and debian/rules has been modified to deal with FTBFS bug introduced by wine-development included in eoan.

 * I have PPU rights on this package, so patch is not included in this bug report as no sponsorship is needed. Just looking for a "green light".

 * As of this writing, focal is in freeze, but the fix has been uploaded there as well and is in-queue.

[Erich Eickmeyer (eeickmeyer)]

Getting FTB errors, will resubscribe SRU team when fixed.

[Erich Eickmeyer (eeickmeyer)]

Fixed FTB errors.

[Thomas Ward (teward)]

Uploads pending in Eoan and Focal.

Bugs targeted per Eickmeyer's request.

[Łukasz Zemczak (sil2100)]

An upload of carla to eoan-proposed has been rejected from the upload queue for the following reason: "Is there any reason for the very non-standard distro-versioning of the package? The ubuntu4+gitXXX notion feels very confusing and, additionally, is not really sequential, as it includes a git commit id. For instance, if a follow up upload needs to be done for eoan, how can we guarantee that the +gitXXX portion will be higher than the previous one if this is a checksum? How users are to determine, which git checkout is 'newer'? Especially that devel seems to use the exact same numbering scheme. If there are no explicit, solid reasons for using this versioning, please use the standard ubuntu3.1 or ubuntu3.19.04.1 SRU versioning.".

[Launchpad Janitor (janitor)]

This bug was fixed in the package carla - 2.0.0-0ubuntu5+gitde67dcb

---------------
carla (2.0.0-0ubuntu5+gitde67dcb) focal; urgency=medium

  * No-change upload to rebuild for focal

 -- Erich Eickmeyer <email address hidden> Mon, 21 Oct 2019 19:24:35 -0700

[Erich Eickmeyer (eeickmeyer)]

Upload reversioned to 2.0.0-0ubuntu4 per request. If rejected, will reupload as 2.0.0-0ubuntu3.1

[Timo Aaltonen (tjaalton)]

Hello Erich, or anyone else affected,

Accepted carla into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/carla/2.0.0-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Erich Eickmeyer (eeickmeyer)]

Everything on this fix checks good. Actual sounds are being produced by synthesizer plugins per my tests.

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for carla has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package carla - 2.0.0-0ubuntu4

---------------
carla (2.0.0-0ubuntu4) eoan; urgency=medium

  * Fix missing libsndfile1-dev in build deps (LP: #1849168)
  * Add patch for lsp-plugins compatibility
  * Fixed FTBFS issue with current wine-development version

 -- Erich Eickmeyer <email address hidden> Mon, 21 Oct 2019 08:10:08 -0700