python2.6-dev should perhaps depend on zlib-dev

[James Westby]

Binary package hint: python2.6

Hi,

A no-change rebuild of capisuite with 2.6 as the default python
fails:

m -f libccmodules.a
ar cru libccmodules.a audiosend.o callmodule.o audioreceive.o faxreceive.o connectmodule.o switch2faxG3.o readDTMF.o calloutgoing.o disconnectmodule.o faxsend.o
ranlib libccmodules.a
make[4]: Leaving directory `/tmp/buildd/capisuite-0.4.5/src/modules'
make[4]: Entering directory `/tmp/buildd/capisuite-0.4.5/src'
if i486-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I.. -DLOCALSTATEDIR=\"/var\" -DPKGDATADIR=\"/usr/share/capisuite\" -DPKGSYSCONFDIR=\"/etc/capisuite\" -DPKGLIBDIR=\"/usr/lib/capisuite\" -I/usr/include/python2.6 -g -O2 -MT main.o -MD -MP -MF ".deps/main.Tpo" -c -o main.o main.cpp; \
 then mv -f ".deps/main.Tpo" ".deps/main.Po"; else rm -f ".deps/main.Tpo"; exit 1; fi
i486-linux-gnu-g++ -g -O2 -Wl,-Bsymbolic-functions -L/usr/lib/python2.6/config -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions -o capisuite main.o application/libccapplication.a modules/libccmodules.a backend/libccbackend.a -lpthread -lcapi20 -lpthread -ldl -lutil -lm -lpython2.6 -L/usr/lib -lz
/usr/bin/ld: cannot find -lz
collect2: ld returned 1 exit status

This is because /usr/lib/python2.6/config/Makefile contains

LOCALMODLIBS= -L$(exec_prefix)/lib -lz

where for 2.5 that variable is empty.

Either this is a mistake and the variable should be empty for python 2.6 as well,
python2.6-dev should depend on the -dev package for libz, or each pacakge that
uses this variable to get the linker line will have the Build-Dependencies altered.

Thanks,

James

[Matthias Klose (doko)]

I did see a similiar case with some package. IMO it is wrong for an extension to link with MODLIBS or LOCALMODLIBS. These are the libraries needed to build the extension modules in the python core. capisuite should be fixed instead not to link with MODLIBS.

[Savvas Radevic (medigeek)]

I've attached a patch for python 2.6 transition. It includes zlib1g-dev.
Do you believe the program does not depend on zlib at all?
I will try and remove the dependency, but my programming knowledge is limited.

[Savvas Radevic (medigeek)]

PPA build that matches the patch posted above:
http://launchpadlibrarian.net/23320337/buildlog_ubuntu-jaunty-lpia.capisuite_0.4.5-8ubuntu2~ppajaunty3_FULLYBUILT.txt.gz

[Savvas Radevic (medigeek)]

This patch is without zlib (and without LOCALMODLIBS).

PPA build:
http://launchpadlibrarian.net/23324661/buildlog_ubuntu-jaunty-lpia.capisuite_0.4.5-8ubuntu2~ppajaunty4_FULLYBUILT.txt.gz

[Savvas Radevic (medigeek)]

I've tested the one without zlib with simple commands and it seems to work:
https://edge.launchpad.net/%7Emedigeek/+archive/ppa/+files/capisuite_0.4.5-8ubuntu2~ppajaunty4_amd64.deb

$ cat /etc/default/capisuite
# run_capisuite_daemon:
# set 'y' to activate the boot/shutdown script
# /etc/init.d/capisuite (Don't forget to
# configure the files in /etc/capisuite/
#
run_capisuite_daemon=y
$ sudo invoke-rc.d capisuite start
Starting capisuite daemon: capisuite.
$ sudo invoke-rc.d capisuite
invoke-rc.d: syntax error: missing required parameter
$ sudo invoke-rc.d capisuite status
Usage: /etc/init.d/capisuite {start|stop|restart|force-reload}
invoke-rc.d: initscript capisuite, action "status" failed.
$ sudo invoke-rc.d capisuite restart
Restarting capisuite daemon: capisuite.
$ sudo invoke-rc.d capisuite stop
Stopping capisuite daemon: capisuite.

[Alessio Treglia (quadrispro)]

Updated the Maintainer and uploaded, thanks for your work.

Please, submit the debdiff to Debian BTS.

[Launchpad Janitor (janitor)]

This bug was fixed in the package capisuite - 0.4.5-8ubuntu2

---------------
capisuite (0.4.5-8ubuntu2) jaunty; urgency=low

  [ Savvas Radevic ]
  * Python 2.6 transition.
  * Added debian/patches/configure_get-correct-python-dirs.diff
  * Added debian/patches/configure_build-without-LOCALMODLIBS.diff
    (LP: #336344)

  [ Alessio Treglia ]
  * Update Maintainer field as per spec.

 -- Savvas Radevic <email address hidden> Mon, 02 Mar 2009 21:10:27 +0100

[Savvas Radevic (medigeek)]

I forgot to apply the patches *before* ./configure in debian/rules, I've sent the patch to Alessio to approve it. Sorry everyone!

[Savvas Radevic (medigeek)]

Forwarding the pbuilder log and the patch! :-)

Patches build fine, but I'm away this week, can't test-run it

---------- Forwarded message ----------
From: Savvas Radevic <email address hidden>
Date: Sat, 21 Mar 2009 20:54:41 +0100
Subject: Re: [Build #913740] lpia build of capisuite 0.4.5-8ubuntu2 in
ubuntu jaunty RELEASE
To: Alessio Treglia <email address hidden>

OK, here's the pbuilder log for capisuite on amd64:

[...]
APPLYING PATCH:
patching file configure
APPLYING PATCH:
patching file configure
APPLYING PATCH:
patching file scripts/incoming.py
APPLYING PATCH:
patching file src/application/pythonscript.cpp
CFLAGS="-Wall -g -O2" ./configure --host=x86_64-linux-gnu
--build=x86_64-linux-gnu --prefix=/usr --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
[...]
capisuite_0.4.5-8ubuntu3_amd64.deb
 Package: capisuite
 Version: 0.4.5-8ubuntu3
 Architecture: amd64
 Maintainer: Ubuntu MOTU Developers <email address hidden>
 Installed-Size: 3476
 Depends: libc6 (>= 2.4), libcapi20-3, libgcc1 (>= 1:4.1.1),
libpython2.6 (>= 2.6), libstdc++6 (>= 4.2.1), python (<< 2.7), python
(>= 2.6), python-central (>= 0.6.11), sfftobmp (>= 3.0), gs, postfix |
mail-transport-agent, sox, libtiff-tools (>= 3.7)

I've sent a PPA build for this (capisuite 0.4.5-8ubuntu3~ppa1):
https://edge.launchpad.net/~medigeek/+archive/ppa/+build/913857
https://edge.launchpad.net/~medigeek/+archive/ppa/+build/913858
https://edge.launchpad.net/~medigeek/+archive/ppa/+build/913859

--
Sent from my mobile device

[Savvas Radevic (medigeek)]

I've set it back to "Confirmed", as the patch wasn't actually used!
The last patch above does the trick. :)

[Daniel Holbach (dholbach)]

Added "(LP: #336344)" to debian/changelog. Uploaded. Sitting in the archive admin queue.

[Launchpad Janitor (janitor)]

This bug was fixed in the package capisuite - 0.4.5-8ubuntu3

---------------
capisuite (0.4.5-8ubuntu3) jaunty; urgency=low

  * debian/rules: Apply patches before ./configure (LP: #336344)

 -- Savvas Radevic <email address hidden> Sat, 21 Mar 2009 19:47:45 +0100