[camera-app] improve SD card error handling
Bug #1540116 reported by
Bill Filler
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
| camera-app (Ubuntu) |
Fix Released
|
Medium
|
Ugo Riboni | ||
Bug Description
We need to improve the error handling when user selects using SD card as storage for photos, as currently we have issues if SD is not writable or formatted correctly.
Should investigate the following:
- check if we can actually write to SD card: when user switches to SD card, verify we can actually write a file there and if not display a message and don't allow to change the setting
- handle errors more gracefully when failure to write to SD card: in the case an error happens when writing to the SD, save the photo to local storage and notify the user about the problem
Related branches
lp:~uriboni/camera-app/sd-card-checks
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 1739 lines (+299/-1151)16 files modifiedCameraApp/CMakeLists.txt (+2/-4)
CameraApp/components.cpp (+9/-0)
CameraApp/qstorageinfo.cpp (+0/-378)
CameraApp/qstorageinfo.h (+0/-102)
CameraApp/qstorageinfo_p.h (+0/-84)
CameraApp/qstorageinfo_unix.cpp (+0/-442)
CameraApp/storagelocations.cpp (+121/-0)
CameraApp/storagelocations.h (+50/-0)
CameraApp/storagemonitor.cpp (+34/-1)
CameraApp/storagemonitor.h (+5/-0)
GalleryView.qml (+3/-3)
ViewFinderOverlay.qml (+30/-13)
ViewFinderView.qml (+29/-1)
cameraapplication.cpp (+0/-106)
cameraapplication.h (+0/-15)
tests/unittests/qstorageinfo_stub.cpp (+16/-2)
Revision history for this message
| Bill Filler (bfiller) wrote | #1 |
| Changed in camera-app (Ubuntu): | |
| assignee: | nobody → Ugo Riboni (uriboni) |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Bill Filler (bfiller) |
| milestone: | none → ww08-2016 |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| summary: |
- improve SD card error handling + [camera-app] improve SD card error handling |
| Changed in camera-app (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| Changed in camera-app (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
| Changed in camera-app (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is related to bug: https:/