Actually detect flash support for active camera
Bug #1390423 reported by
Brendan Donegan
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| camera-app (Ubuntu) |
Fix Released
|
High
|
Ugo Riboni | ||
Bug Description
Most front cameras on phones do not have a flash, so naturally the control for this in the sub-controls doesn't work. However there is nothing to visually distinguish this from the other controls (Location and HDR) that do work, so it's slightly confusing from a users perspective. This control should be removed, or at least be dependent on the presence of a flash for the front camera
Related branches
lp:~phablet-team/qtubuntu-camera/query-supported-flash-modes
- PS Jenkins bot: Pending (continuous-integration) requested
- Florian Boucault: Pending requested
-
Diff: 134 lines (+32/-16)5 files modifieddebian/control (+1/-1)
src/aalcameraflashcontrol.cpp (+15/-14)
src/aalcameraflashcontrol.h (+3/-1)
unittests/mocks/aal/camera_compatibility_layer.cpp (+11/-0)
unittests/mocks/aal/camera_compatibility_layer_capabilities.h (+2/-0)
- Florian Boucault (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 134 lines (+32/-16)5 files modifieddebian/control (+1/-1)
src/aalcameraflashcontrol.cpp (+15/-14)
src/aalcameraflashcontrol.h (+3/-1)
unittests/mocks/aal/camera_compatibility_layer.cpp (+11/-0)
unittests/mocks/aal/camera_compatibility_layer_capabilities.h (+2/-0)
| Changed in camera-app (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| Changed in camera-app: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| Changed in camera-app: | |
| assignee: | nobody → Ugo Riboni (uriboni) |
Revision history for this message
| Ugo Riboni (uriboni) wrote | #1 |
| Changed in camera-app: | |
| status: | Confirmed → Fix Committed |
| Changed in camera-app (Ubuntu): | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Ugo Riboni (uriboni) wrote | #2 |
| Changed in camera-app: | |
| status: | Fix Committed → In Progress |
| Changed in camera-app (Ubuntu): | |
| status: | Fix Committed → In Progress |
| assignee: | nobody → Ugo Riboni (uriboni) |
| summary: |
- Front camera controls includes Flash type selection even though this is - not supported + Actually detect flash support for active camera |
| Changed in camera-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| no longer affects: | camera-app |
To post a comment you must log in.
This is fixed in trunk. On krilling for example flipping to the front camera when the flash is on will not show any flash control. flipping to the back camera will bring back the flash