Changing zoom in "List View" mode does not refresh display

[Laurent Bonnaud]

[Impact]

When user changes the zoom level in the list view, the view isn't auto-updated properly. It can be partially updated by hovering mouse pointer over
files/folders, but there are still visual issues present (like wrong font size in some places).

The patch attached to this report fixes the issue.

The fix is already present in Artful and tested by developers and users. Would be nice to backport it to Zesty as well, as the issue causes problems for users who need to change the zoom level.

[Test Case]

Steps to reproduce:
- launch Caja
- switch to list view
- use zoom buttons to zoom in and out

Actual zoom level in the list view won't be updated. Hover the mouse over files and folders to see some partial update.

[Regression Potential]

None. The patch only makes sure the view is properly updated. It doesn't affect anything else.

[Other Info]

The patch is included into the debdiff attached to this report.

The debdiff contains patches to fix bug 1680604, bug 1683653, bug 1688687. See other reports for the corresponding SRU templates.

[Original Description]

Hi,

here is how to reproduce the problem:
 - view a folder in "List View" mode
 - change the zoom level

Expected result: the view is updated immediately

Actual result: the view is not updated unless the mouse is used to repaint the area or the directory is changed

Besides zoom levels above 200% are unusable.

ProblemType: Bug
DistroRelease: Ubuntu 17.04
Package: caja 1.18.1-0ubuntu1
Uname: Linux 4.10.8-041008-lowlatency x86_64
ApportVersion: 2.20.4-0ubuntu3
Architecture: amd64
CurrentDesktop: MATE
Date: Thu Apr 6 22:44:06 2017
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: caja
UpgradeStatus: Upgraded to zesty on 2017-03-12 (25 days ago)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Etienne Papegnies (etienne-papegnies)]

Reported upstream @ https://github.com/mate-desktop/caja/issues/790

[Etienne Papegnies (etienne-papegnies)]

This is now fixed upstream.

[Vlad Orlov (monsta)]

Yes, but there's a regression - manual column resizing is disabled now.
Check https://github.com/mate-desktop/caja/pull/838 which should fix it.

[Martin Wimpress  (flexiondotorg)]

Fix in caja 1.18.4-0ubuntu2 released to the 17.10 archive.

[Vlad Orlov (monsta)]

Both Debian and Ubuntu need one more patch:
https://github.com/mate-desktop/caja/commit/cb8e3930d44bbbbc6d3faf78f7826be467978825.patch

Otherwise you'll get large icon margins on zooming out, like shown in the screenshot here:
https://github.com/mate-desktop/caja/pull/835#issuecomment-324911814

[Vlad Orlov (monsta)]

Nevermind - that commit is already included in the existing patch. I missed this fact due to the patch being named after the first commit. :)

[Vlad Orlov (monsta)]

Attaching the combined patch for Zesty's 1.18.1.

[Vlad Orlov (monsta)]

Attaching the debdiff with patches to fix bug 1680604, bug 1683653, bug 1688687 for Zesty.

[Vlad Orlov (monsta)]

[Impact]

When user changes the zoom level in the list view,
the view isn't auto-updated properly. It can be
partially updated by hovering mouse pointer over
files/folders, but there are still visual issues
present (like wrong font size in some places).

The patch attached to this report fixes the issue.

The fix is already present in Artful and tested by
developers and users. Would be nice to backport it
to Zesty as well, as the issue causes problems for
users who need to change the zoom level.

[Test Case]

Steps to reproduce:
- launch Caja
- switch to list view
- use zoom buttons to zoom in and out

Actual zoom level in the list view won't be updated.
Hover the mouse over files and folders to see some
partial update.

[Regression Potential]

None. The patch only makes sure the view is properly
updated. It doesn't affect anything else.

[Other Info]

The patch is included into the debdiff attached to
this report.

The debdiff contains patches to fix bug 1680604,
bug 1683653, bug 1688687. See other reports for the
corresponding SRU templates.

[Simon Quigley (tsimonq2)]

Hey Vlad,

Uploaded, great work as usual. :)

In the future though, could you please put the SRU template in the actual bug description instead of just as a comment?

Thanks for your contributions!

[Vlad Orlov (monsta)]

Sure, I can edit the description. I thought it's wasn't proper for me to do that :)

[Vlad Orlov (monsta)]

Should all Zesty entries in these reports be updated to "In Progress"?

[Brian Murray (brian-murray)]

Hello Laurent, or anyone else affected,

Accepted caja into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/caja/1.18.1-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

While I've accepted this the "Regression Potential" section is rather weak. What kinds of testing should be done to ensure the fix didn't break anything else?

[Vlad Orlov (monsta)]

The patch only affects the code related to setting zoom level in the list view. It should be enough to change zoom level several times and make sure there aren't any visual issues in the list view after each zoom change.

[Vlad Orlov (monsta)]

Testing in Zesty...

- replaced my local builds of caja, caja-common, libcaja-extension1, gir1.2-caja packages with version 1.18.1-0ubuntu2.1 from zesty-proposed
- restarted Caja
- switched to the list view
- changed the zoom level several times, from 33% (min) to 400% (max)
- used the button to reset the zoom level to default (50%)
- also tested various zoom levels with some folders expanded in the tree
- also checked that column resizing still works (it does)

All good, the list view is properly updated with each zoom level change.

[Launchpad Janitor (janitor)]

This bug was fixed in the package caja - 1.18.1-0ubuntu2.1

---------------
caja (1.18.1-0ubuntu2.1) zesty; urgency=medium

  * Added patches:
    + fix-list-view-zoom.patch - fixes visual issues with zoom in
      list view (LP: #1680604)
    + restore-dbus-init.patch - restores DBus initialization to fix
      Firefox freeze when opening download folder (LP: #1683653)
    + fix-mousewheel-scroll.patch - fixes mousewheel scrolling over
      pathbar buttons (LP: #1688687)

 -- Vlad Orlov <email address hidden> Mon, 06 Nov 2017 22:00:31 +0300

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for caja has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.