Activity log for bug #1662027

Date Who What changed Old value New value Message
2017-02-05 23:32:12 Joel N. Weber II bug added bug
2017-02-06 21:12:37 Paul Gevers bug watch added http://bugs.cacti.net/view.php?id=2446
2017-04-11 21:59:30 Nish Aravamudan nominated for series Ubuntu Zesty
2017-04-11 21:59:30 Nish Aravamudan bug task added cacti (Ubuntu Zesty)
2017-04-11 21:59:30 Nish Aravamudan nominated for series Ubuntu Xenial
2017-04-11 21:59:30 Nish Aravamudan bug task added cacti (Ubuntu Xenial)
2017-04-11 21:59:30 Nish Aravamudan nominated for series Ubuntu Yakkety
2017-04-11 21:59:30 Nish Aravamudan bug task added cacti (Ubuntu Yakkety)
2017-04-11 22:15:35 Nish Aravamudan bug added subscriber Nish Aravamudan
2017-04-13 19:31:12 Paul Gevers cacti (Ubuntu Zesty): status New Confirmed
2017-04-14 19:14:30 Paul Gevers bug watch added http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860271
2017-04-14 19:14:30 Paul Gevers bug task added cacti (Debian)
2017-04-14 22:48:13 Bug Watch Updater cacti (Debian): status Unknown Fix Released
2017-04-15 04:30:56 Nish Aravamudan cacti (Ubuntu Yakkety): status New In Progress
2017-04-15 04:30:59 Nish Aravamudan cacti (Ubuntu Xenial): status New In Progress
2017-04-15 04:31:01 Nish Aravamudan cacti (Ubuntu Zesty): status Confirmed In Progress
2017-04-15 04:31:07 Nish Aravamudan cacti (Ubuntu Xenial): assignee Nish Aravamudan (nacc)
2017-04-15 04:31:09 Nish Aravamudan cacti (Ubuntu Yakkety): assignee Nish Aravamudan (nacc)
2017-04-15 04:31:11 Nish Aravamudan cacti (Ubuntu Zesty): assignee Nish Aravamudan (nacc)
2017-04-17 16:52:09 Nish Aravamudan nominated for series Ubuntu Aa-series
2017-04-17 16:52:09 Nish Aravamudan bug task added cacti (Ubuntu Aa-series)
2017-04-17 16:52:24 Nish Aravamudan cacti (Ubuntu Aa-series): status New In Progress
2017-04-17 16:52:27 Nish Aravamudan cacti (Ubuntu Aa-series): assignee Nish Aravamudan (nacc)
2017-04-17 18:01:04 Nish Aravamudan description poller.php calls split in two places, which fails with PHP 7. This seems to only actually cause problems if poller.php is configured to poll the snmp data sources more than once per time poller.php is called by cron (which typically happens if 10 second or 30 second polling intervals are requested), but it appears to me that these error messages may appear in the logs even when cacti is configured to only poll once per time it is called by cron. It appears that using explode instead of split is the fix. PHP Fatal error: Uncaught Error: Call to undefined function split() in /usr/share/cacti/site/poller.php:454 Stack trace: #0 {main} thrown in /usr/share/cacti/site/poller.php on line 454 PHP Fatal error: Uncaught Error: Call to undefined function split() in /usr/share/cacti/site/poller.php:454 Stack trace: #0 {main} thrown in /usr/share/cacti/site/poller.php on line 454 Description: Ubuntu 16.04.1 LTS Release: 16.04 cacti: Installed: 0.8.8f+ds1-4ubuntu4.16.04.1 Candidate: 0.8.8f+ds1-4ubuntu4.16.04.1 Version table: *** 0.8.8f+ds1-4ubuntu4.16.04.1 500 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe amd64 Packages 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe i386 Packages 100 /var/lib/dpkg/status 0.8.8f+ds1-4ubuntu4 500 500 http://us.archive.ubuntu.com/ubuntu xenial/universe amd64 Packages 500 http://us.archive.ubuntu.com/ubuntu xenial/universe i386 Packages [Impact] * If the administrator configures cacti to poll data at a higher frequency than the cron job that runs the poller, a fatal error is emitted. * As the highest cron frequency is once per minute, one will have to use this feature if higher resolution is required. [Test Case] * On the one hand, this is a syntactical (non-php7.0 compliant) code change, so the test case feels less necessary. * On the other hand, one can configure cacti to poll at a higher than once-per-minute frequency, and the poller will crash with the "undefined function split()". [Regression Potential] * Presuming an administrator does not use a higher than one-minute polling frequency, there is no regression potential, as they are unaffected by this codepath. * If the administrator does use a higher polling frequency, they may have already hit this bug and manually changed the source on their system. Ideally, they will have changed it in the same way upstream has, which is the backported fix in this bug -- and so when the update is installed, there should be no change. * If the administrator left cacti in the broken state because of this bug, then it will be fixed by this change and there again, is no regression potential, because the feature was broken before. --- poller.php calls split in two places, which fails with PHP 7. This seems to only actually cause problems if poller.php is configured to poll the snmp data sources more than once per time poller.php is called by cron (which typically happens if 10 second or 30 second polling intervals are requested), but it appears to me that these error messages may appear in the logs even when cacti is configured to only poll once per time it is called by cron. It appears that using explode instead of split is the fix. PHP Fatal error: Uncaught Error: Call to undefined function split() in /usr/share/cacti/site/poller.php:454 Stack trace: #0 {main}   thrown in /usr/share/cacti/site/poller.php on line 454 PHP Fatal error: Uncaught Error: Call to undefined function split() in /usr/share/cacti/site/poller.php:454 Stack trace: #0 {main}   thrown in /usr/share/cacti/site/poller.php on line 454 Description: Ubuntu 16.04.1 LTS Release: 16.04 cacti:   Installed: 0.8.8f+ds1-4ubuntu4.16.04.1   Candidate: 0.8.8f+ds1-4ubuntu4.16.04.1   Version table:  *** 0.8.8f+ds1-4ubuntu4.16.04.1 500         500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe amd64 Packages         500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe i386 Packages         100 /var/lib/dpkg/status      0.8.8f+ds1-4ubuntu4 500         500 http://us.archive.ubuntu.com/ubuntu xenial/universe amd64 Packages         500 http://us.archive.ubuntu.com/ubuntu xenial/universe i386 Packages
2017-04-18 18:27:04 Adam Conrad cacti (Ubuntu Zesty): status In Progress Fix Committed
2017-04-18 18:27:07 Adam Conrad bug added subscriber Ubuntu Stable Release Updates Team
2017-04-18 18:27:10 Adam Conrad bug added subscriber SRU Verification
2017-04-18 18:27:17 Adam Conrad tags verification-needed
2017-04-18 19:14:27 Adam Conrad cacti (Ubuntu Yakkety): status In Progress Fix Committed
2017-04-18 19:15:17 Adam Conrad cacti (Ubuntu Xenial): status In Progress Fix Committed
2017-04-22 09:28:24 Launchpad Janitor cacti (Ubuntu Artful): status In Progress Fix Released
2017-05-07 20:27:50 Mathew Hodson cacti (Ubuntu Xenial): importance Undecided Medium
2017-05-07 20:27:55 Mathew Hodson cacti (Ubuntu Zesty): importance Undecided Medium
2017-05-07 20:27:56 Mathew Hodson cacti (Ubuntu Yakkety): importance Undecided Medium
2017-05-07 20:27:59 Mathew Hodson cacti (Ubuntu Artful): importance Undecided Medium
2017-09-26 19:29:47 Ubuntu Foundations Team Bug Bot tags verification-needed removal-candidate verification-needed
2018-02-20 09:22:22 Łukasz Zemczak cacti (Ubuntu Xenial): status Fix Committed Won't Fix
2018-02-20 09:22:30 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2018-02-20 09:22:31 Łukasz Zemczak tags removal-candidate verification-needed removal-candidate