Please merge ca-certificates-java 20180516 (main) from Debian unstable (main)

Bug #1771815 reported by Tiago Stürmer Daitx on 2018-05-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ca-certificates-java (Ubuntu)
High
Unassigned
Bionic
Undecided
Unassigned
javatools (Debian)
Fix Released
Unknown

Bug Description

[Original Merge Description]
There's a new ca-certificates-java package in debian unstable versioned 20180516 which conflicts with Ubuntu's delta in cosmic, version 20180413ubuntu1 [1], and requires a merge.

The following changes should be kept:
1) debian/control: Bump javahelper build dependency.
2) debian/rules: Replace javac arguments '-source 1.7 -target 1.7' with '--release 7'
as, per JEP-247, it also takes care of setting the right -bootclasspath argument.

We can only propose both 1) and 2) to Debian after Debian merges 895230 [2].

References:
[1] https://merges.ubuntu.com/main.html?query=ca-certificates-java
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895230

[Impact]
This merge brings fixes for:
1. debian/jks-keystore.hook.in and debian/postinst.in so the PATH is only updated when a valid JVM is found - previously an invalid path was set, which had no side effect.
2. the same fix carried by by bug 1769013, which removed an uneccessary jvm config file
3. the fix from bug 1771363, which converted keystores in PKCS12 format to JKS

[Test Case]
Same test cases as described in bug 1771363 and bug 1769013.

Additionally to that one can check that the jks-keystore hook and the postinst script from ca-certificates-java no longer causes an invalid PATH and JAVA_HOME to be set - this had no side effect, as those were set to an invalid value the java binary was search in the remaining PATH.

[Regression Potential]
Besides the regressions discussed in bug 1771363 and bug 1769013 no other regression is expected.

Not setting PATH/JAVA_HOME or setting them to an invalid value will have the same effect in the 'java' calls for both the jks-keystore hook and the postinst script: an existing java binary in the remaining PATH is called.

Tiago Stürmer Daitx (tdaitx) wrote :

Debdiff from Debian version 20180516.

tags: added: cosmic upgrade-software-version
Tiago Stürmer Daitx (tdaitx) wrote :

Debdiff from Ubuntu version 20180413ubuntu1.

tags: added: patch
Julian Andres Klode (juliank) wrote :

Looking at it.

Changed in ca-certificates-java (Ubuntu):
importance: Undecided → High
status: New → Triaged
status: Triaged → In Progress
Changed in ca-certificates-java (Ubuntu):
status: In Progress → Fix Committed
Changed in javatools (Debian):
status: Unknown → New
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ca-certificates-java - 20180516ubuntu1

---------------
ca-certificates-java (20180516ubuntu1) cosmic; urgency=low

  * Merge from Debian unstable (LP: #1771815). Remaining changes:
    - debian/control: Bump javahelper build dependency.
    - debian/rules:
      + Explicitly depend on openjdk-11-jre-headless, needed to configure.
      + Replace javac arguments '-source 1.7 -target 1.7' with '--release 7'
        as, per JEP-247, it also takes care of setting the right -bootclasspath
        argument.

ca-certificates-java (20180516) unstable; urgency=medium

  * Team upload.

  [ Tiago Stürmer Daitx ]
  * debian/jks-keystore.hook.in: don't create a jvm-*.cfg file, a default file
    with the right configuration is already supplied by the openjdk packages.
  * debian/jks-keystore.hook.in, debian/postinst.in: Only export JAVA_HOME
    and update PATH if a known jvm was found.
  * debian/postinst.in: Detect PKCS12 cacert keystore generated by
    previous ca-certificates-java and convert them to JKS. (Closes: #898678)
    (LP: #1771363)

  [ Matthias Klose ]
  * debian/rules: Explicitly depend on openjdk-11-jre-headless, needed to
    configure.

  [ Emmanuel Bourg ]
  * Use salsa.debian.org Vcs-* URLs

 -- Tiago Stürmer Daitx <email address hidden> Thu, 17 May 2018 13:03:29 +0000

Changed in ca-certificates-java (Ubuntu):
status: Fix Committed → Fix Released
Changed in javatools (Debian):
status: New → Fix Released
description: updated

Hello Tiago, or anyone else affected,

Accepted ca-certificates-java into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ca-certificates-java/20180516ubuntu1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ca-certificates-java (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
tags: added: verification-done-bionic
removed: verification-needed verification-needed-bionic
Tiago Stürmer Daitx (tdaitx) wrote :

Using the test case I confirm that the PATH and JAVA_HOME are now working as expected and no longer set to invalid values.

The test cases in bug 1771363 and bug 1769013 are also working correctly.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ca-certificates-java - 20180516ubuntu1~18.04.1

---------------
ca-certificates-java (20180516ubuntu1~18.04.1) bionic; urgency=medium

  * Backport from Cosmic. (LP: #1770553)

ca-certificates-java (20180516ubuntu1) cosmic; urgency=low

  * Merge from Debian unstable (LP: #1771815). Remaining changes:
    - debian/control: Bump javahelper build dependency.
    - debian/rules:
      + Explicitly depend on openjdk-11-jre-headless, needed to configure.
      + Replace javac arguments '-source 1.7 -target 1.7' with '--release 7'
        as, per JEP-247, it also takes care of setting the right -bootclasspath
        argument.

ca-certificates-java (20180516) unstable; urgency=medium

  * Team upload.

  [ Tiago Stürmer Daitx ]
  * debian/jks-keystore.hook.in: don't create a jvm-*.cfg file, a default file
    with the right configuration is already supplied by the openjdk packages.
  * debian/jks-keystore.hook.in, debian/postinst.in: Only export JAVA_HOME
    and update PATH if a known jvm was found.
  * debian/postinst.in: Detect PKCS12 cacert keystore generated by
    previous ca-certificates-java and convert them to JKS. (Closes: #898678)
    (LP: #1771363)

  [ Matthias Klose ]
  * debian/rules: Explicitly depend on openjdk-11-jre-headless, needed to
    configure.

  [ Emmanuel Bourg ]
  * Use salsa.debian.org Vcs-* URLs

ca-certificates-java (20180413ubuntu1) cosmic; urgency=medium

  * Merge from debian unstable. Remaining changes: (LP: #1769013,
    LP: #1739631)
    + debian/control: Bump javahelper build dependency.
    + debian/rules:
      - Explicitly depend on openjdk-11-jre-headless, needed to configure.
      - Replace javac arguments '-source 1.7 -target 1.7' with '--release 7'
        as, per JEP-247, it also takes care of setting the right -bootclasspath
        argument.
  * debian/jks-keystore.hook.in: don't create a jvm-*.cfg file, a default file
    with the right configuration is already supplied by the openjdk packages.

ca-certificates-java (20180413) unstable; urgency=medium

  * Team upload.
  * Always generate a JKS keystore instead of using the default format
    (Closes: #894979)
  * Look for Java 10 and Java 11 when detecting the JRE
  * Removed Damien Raude-Morvan from the uploaders (Closes: #889412)
  * Standards-Version updated to 4.1.4
  * Switch to debhelper level 11

 -- Tiago Stürmer Daitx <email address hidden> Thu, 17 May 2018 14:10:59 +0000

Changed in ca-certificates-java (Ubuntu Bionic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for ca-certificates-java has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.