Warnings during build
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
c3p0 (Ubuntu) |
Fix Released
|
Low
|
James Page |
Bug Description
Hi
There is a large number of warnings during the gcj-based build of c3p0 (NB: I'm quite surprized that it's not compatible with openjdk though as I used c3p0 with Sun's JDK in the past and would have thought it's easier to use openjdk than gcj here).
I think the very high number of warnings deserves some work, upstream and/or in the packaging (I think using the proper source compat level would help with a bunch).
[javadoc] WARNING: Cannot locate class java.lang.Object referenced in class com.mchange.
[javadoc] WARNING: Error while loading class Connection
[javadoc] WARNING: Error while loading class SQLException
[javadoc] WARNING: Error while loading class Method
=> a bit worrying; looks like that part is not started properly, or build-deps are missing
[javac] 1. WARNING in /build/
[javac] public final static Iterator EMPTY_ITERATOR = new Iterator()
[javac] ^^^^^^^^
[javac] Iterator is a raw type. References to generic type Iterator<E> should be parameterized
=> you might want to use an older source compat level or use a parametrized iterator
[javac] 2. WARNING in /build/
[javac] nerator.java (at line 71)
[javac] protected void generateExtraSe
[javac]
[javac] ^^^^^^^^^^^^^^
[javac] The type IndentedWriter is deprecated
=>self refs to depreacted types
[javac] 119. WARNING in /build/
[javac] (at line 222)
[javac] { instance(
[javac] ^^^^^^^
[javac] The static method getLogger() from the type MLog should be accessed in a static way
=> certainly typos
[javac] 132. WARNING in /build/
[javac] boolean rethrow = false;
[javac] ^^^^^^^
[javac] The local variable rethrow is never read
=> certainly a bug
Thanks,
Related branches
- Ubuntu branches: Pending requested
-
Diff: 247 lines (+168/-12)7 files modifieddebian/ant.properties (+12/-7)
debian/changelog (+8/-0)
debian/control (+5/-3)
debian/patches/build.patch (+66/-0)
debian/patches/series (+2/-0)
debian/patches/testing.patch (+73/-0)
debian/rules (+2/-2)
Changed in c3p0 (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in c3p0 (Ubuntu): | |
assignee: | nobody → James Page (james-page) |
status: | Triaged → In Progress |
Changed in c3p0 (Ubuntu): | |
importance: | Medium → Low |
Updates based on some initial analysis of this package:
1) The version of c3p0 (which is the latest released version) is not compatible with Java 1.6 (which openjdk implements) hence it is compiled against gcj which implements Java 1.5.
2) gcj is by default alot more verbose with its warning messages than openjdk (which gives a general warning about deprecated API unless explicitly turned on).
3) The javadoc issues appear to be related to the use of gcj rather than openjdk (which gives a different set of errors).
I agree that it feels like this needs to be resolved by the upstream project; however the original c3p0 project appears to be relatively inactive so we may not get a fix.