bzr verify-signature fails when acceptable_keys is defined
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Vincent Ladeuil | ||
bzr (Ubuntu) |
Fix Released
|
High
|
Dimitri John Ledkov | ||
Saucy |
Won't Fix
|
High
|
Unassigned | ||
Trusty |
Fix Released
|
High
|
Dimitri John Ledkov |
Bug Description
Please keep this description header, needed for Ubuntu SRU to Trusty.
Please see https:/
Impact:
Bzr crashes when verifying non-ascii characters in signatures, in
verbose mode.
Testcase:
bzr branch lp:~xnox/+junk/test-signatures
cd test-signatures
gpg --import key.asc
bzr config "acceptable_
bzr verify-signatures
Original Report:
Hi,
I updated my ~/.bazaar/
acceptable_keys = *@canonical.com
It seems that the option causes 'bzr verify-signatures' to now fail as follows:
$ bzr verify-signatures -v
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return the_callable(*args, **kwargs)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
return self._operation
File "/usr/lib/
self.cleanups, self.func, *args, **kwargs)
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
gpg_
File "/usr/lib/
patterns = key_patterns.
AttributeError: 'list' object has no attribute 'split'
bzr 2.6.0 on python 2.7.5 (Linux-
Ubuntu-
arguments: ['/usr/bin/bzr', 'verify-
plugins: bash_completion
grep[2.6.0], launchpad[2.6.0], netrc_credentia
news_
encoding: 'utf-8', fsenc: 'UTF-8', lang: 'en_AU.UTF-8'
*** Bazaar has encountered an internal error. This probably indicates a
bug in Bazaar. You can help us fix it by filing a bug report at
https:/
including this traceback and a description of the problem.
$ apt-cache policy bzr
bzr:
Installed: 2.6.0-3ubuntu1
Candidate: 2.6.0-3ubuntu1
Version table:
*** 2.6.0-3ubuntu1 0
500 http://
100 /var/lib/
Regards,
Haw
ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: bzr 2.6.0-3ubuntu1
ProcVersionSign
Uname: Linux 3.11.0-13-generic x86_64
ApportVersion: 2.12.5-0ubuntu2.1
Architecture: amd64
Date: Sun Nov 10 17:53:03 2013
MarkForUpload: True
PackageArchitec
SourcePackage: bzr
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
- Richard Wilbur: Approve
- Bazaar Codereview Subscribers: Pending requested
-
Diff: 89 lines (+19/-16)4 files modifiedbzrlib/commit_signature_commands.py (+3/-3)
bzrlib/gpg.py (+4/-13)
bzrlib/tests/test_gpg.py (+9/-0)
doc/en/release-notes/bzr-2.7.txt (+3/-0)
Changed in bzr: | |
milestone: | none → 2.7b1 |
status: | In Progress → Fix Released |
Changed in bzr (Ubuntu Saucy): | |
status: | Triaged → Won't Fix |
Changed in bzr (Ubuntu): | |
assignee: | nobody → Dimitri John Ledkov (xnox) |
Changed in bzr (Ubuntu Trusty): | |
assignee: | nobody → Dimitri John Ledkov (xnox) |
description: | updated |
description: | updated |
description: | updated |
Changed in bzr (Ubuntu Trusty): | |
status: | Triaged → In Progress |
Changed in bzr (Ubuntu): | |
milestone: | trusty-updates → none |
Reproduced.
It seems that setting 'acceptable_keys' in bazaar.conf is not supported. At least the simple test I'm adding confirms this.
So the workaround is to not set it in bazaar.conf but use the command-line option :-/