Feature request: allow themable/mono icon for bzr-notify

Bug #663530 reported by zpletan on 2010-10-19
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Andrew Starr-Bochicchio
bzr-gtk (Ubuntu)
Jelmer Vernooij

Bug Description

Binary package hint: bzr-gtk

Using a monochrome icon theme, such as ubuntu-mono or elementaryicons, bzr-notify's panel notifications don't fit in. It would be nice for bzr-notify (and perhaps other apps in gtk-bzr, but I don't use those as much) to allow for icon theming, and specifically, for bzr-notify to load a -panel suffixed icon.

Related branches

zpletan (zpletan) on 2010-10-19
description: updated

 status triaged
 importance wishlist

That would indeed be very neat.

Changed in bzr-gtk (Ubuntu):
status: New → Triaged

This is very trivial code wise, but there might be some design questions. The attached branch works for me. It installs a bzr-panel.png to /usr/share/pixmaps/ and uses it for the app-indicator. I temporarily used a desaturated bzr icon, but I suppose that it should actually be up to the theme, with us just installing a normal one as a fallback. Should the gtk.status icon use this as well?

zpletan (zpletan) wrote :

(The Lucid version doesn't appear to have AppIndicator support. I assume you are using code from Maverick/Natty/trunk?)

I would use the same image for both AppIndicator and GtkStatusIcon, unless there is some compelling reason not to do so.

I'd also install the image in /usr/share/icons/hicolor/$SOMETHING rather than in /usr/share/pixmaps - I understand that that's better protocol.

Thanks for your prompt attention to this issue/feature!

I'm working with trunk, but it uses an AppIndicator in Maverick as well. This is actually something that's been annoying me as well. Your bug report just gave me a push.

I think you're right on both counts. I set the AppIndicator and GtkStatusIcon to use the same icon. I went with a normal bzr logo as an svg which is installed to /usr/share/icons/hicolor/scalable/apps

zpletan (zpletan) wrote :

Lookin' nice! Thanks!

Changed in bzr-gtk:
status: New → Triaged
importance: Undecided → Wishlist
Jelmer Vernooij (jelmer) on 2011-02-18
Changed in bzr-gtk:
status: Triaged → Fix Committed
milestone: none → 0.100.0
Jelmer Vernooij (jelmer) on 2011-03-02
Changed in bzr-gtk:
status: Fix Committed → Fix Released
Changed in bzr-gtk (Ubuntu):
status: Triaged → Fix Released
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer) on 2011-03-02
Changed in bzr-gtk:
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers