traceback when fastimport file is incomplete

Bug #937972 reported by Fila Kolodny
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Fast Import
Fix Released
Low
Jelmer Vernooij
bzr-fastimport (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

If you attempt to fast-import with a truncated fi file it crashes

ProblemType: Crash
DistroRelease: Ubuntu 12.04
Package: bzr 2.5.0~beta5-3ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-15.24-generic 3.2.5
Uname: Linux 3.2.0-15-generic x86_64
NonfreeKernelModules: fglrx
ApportVersion: 1.92-0ubuntu1
Architecture: amd64
BzrDebugFlags: set()
BzrVersion: 2.5b5
CommandLine: ['/usr/bin/bzr', 'fast-import', '--trees', '--autopack=10000', 'src.fi', 'src']
CrashDb: bzr
Date: Mon Feb 20 17:34:25 2012
ExecutablePath: /usr/bin/bzr
FileSystemEncoding: UTF-8
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Alpha amd64 (20111129.1)
InterpreterPath: /usr/bin/python2.7
Locale: en_US.UTF-8
PackageArchitecture: all
Platform: Linux-3.2.0-15-generic-x86_64-with-Ubuntu-12.04-precise
ProcCmdline: /usr/bin/python /usr/bin/bzr fast-import --trees --autopack=10000 src.fi src
ProcEnviron:
 TERM=xterm
 SHELL=/bin/bash
 PATH=(custom, user)
 LANG=en_US.UTF-8
PythonVersion: 2.7.2
SourcePackage: bzr
Title: bzr crashed with MissingBytes in abort(): line 9335443: Unexpected EOF - expected 22726 bytes, found 22294
UpgradeStatus: Upgraded to precise on 2012-02-09 (12 days ago)
UserEncoding: utf-8
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

Revision history for this message
Fila Kolodny (fila) wrote :
visibility: private → public
tags: removed: need-duplicate-check
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Your fastimport file is incomplete.

bzr-fastimport is printing a traceback while it should just be printing an error message.

affects: bzr (Ubuntu) → bzr-fastimport (Ubuntu)
Changed in bzr-fastimport (Ubuntu):
importance: Undecided → Low
status: New → Triaged
summary: - bzr crashed with MissingBytes in abort(): line 9335443: Unexpected EOF -
- expected 22726 bytes, found 22294
+ traceback when fastimport file is incomplete
Jelmer Vernooij (jelmer)
Changed in bzr-fastimport:
status: New → Triaged
importance: Undecided → Low
Jelmer Vernooij (jelmer)
Changed in bzr-fastimport:
status: Triaged → Fix Committed
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 0.14.0
Jelmer Vernooij (jelmer)
Changed in bzr-fastimport:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr-fastimport - 0.13.0-3

---------------
bzr-fastimport (0.13.0-3) unstable; urgency=low

  * QA upload.

  [ Jelmer Vernooij ]
  * Add XS-Testsuite: autopkgtest header. Closes: #692658

  [ Zygmunt Krynicki ]
  * debian/patches/dont-use-get_ancestry.diff: Don't use deprecated
    and removed get_ancestry() method (LP: #1084749).

  [ Andrew Starr-Bochicchio ]
  * debian/patches/improve_error_message.diff: Backport upstream
    commit to print sane error when a fastimport file is incomplete
    (LP: #937972).
  * debian/control: Bump Standards-Version to 3.9.4, no changes needed.
  * debian/tests/control:
   - Add python-subunit test dependency.
   - Drop undefined "no-build-needed" feature.

 -- Andrew Starr-Bochicchio <email address hidden> Sun, 24 Nov 2013 18:01:20 -0500

Changed in bzr-fastimport (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.