byobu ftbfs in eoan

[Matthias Klose]

seen in a test rebuild
https://launchpadlibrarian.net/441262694/buildlog_ubuntu-eoan-amd64.byobu_5.129-0ubuntu1_BUILDING.txt.gz

make[1]: Entering directory '/<<PKGBUILDDIR>>'
# Check python syntax
pep8 --verbose --repeat --ignore W191,E501 usr/lib/byobu/include/config.py usr/lib/byobu/include/select-session.py
checking usr/lib/byobu/include/config.py
usr/lib/byobu/include/config.py:38:2: E117 over-indented
usr/lib/byobu/include/config.py:43:2: E117 over-indented
usr/lib/byobu/include/config.py:46:2: E117 over-indented
usr/lib/byobu/include/config.py:60:2: E117 over-indented
usr/lib/byobu/include/config.py:62:2: E117 over-indented
usr/lib/byobu/include/config.py:64:2: E117 over-indented
usr/lib/byobu/include/config.py:77:2: E117 over-indented (comment)
usr/lib/byobu/include/config.py:78:2: E117 over-indented
usr/lib/byobu/include/config.py:79:3: E117 over-indented
usr/lib/byobu/include/config.py:85:3: E117 over-indented
usr/lib/byobu/include/config.py:90:2: E117 over-indented
usr/lib/byobu/include/config.py:91:3: E117 over-indented
usr/lib/byobu/include/config.py:92:4: E117 over-indented (comment)
usr/lib/byobu/include/config.py:93:4: E117 over-indented (comment)
usr/lib/byobu/include/config.py:94:4: E117 over-indented
usr/lib/byobu/include/config.py:98:4: E117 over-indented
usr/lib/byobu/include/config.py:100:3: E117 over-indented
usr/lib/byobu/include/config.py:104:2: E117 over-indented (comment)
usr/lib/byobu/include/config.py:105:2: E117 over-indented
usr/lib/byobu/include/config.py:108:3: E117 over-indented (comment)
usr/lib/byobu/include/config.py:109:3: E117 over-indented
usr/lib/byobu/include/config.py:110:4: E117 over-indented
usr/lib/byobu/include/config.py:114:4: E117 over-indented
usr/lib/byobu/include/config.py:116:3: E117 over-indented (comment)
usr/lib/byobu/include/config.py:117:3: E117 over-indented
usr/lib/byobu/include/config.py:118:4: E117 over-indented
usr/lib/byobu/include/config.py:120:4: E117 over-indented
usr/lib/byobu/include/config.py:126:2: E117 over-indented
usr/lib/byobu/include/config.py:127:3: E117 over-indented
usr/lib/byobu/include/config.py:129:3: E117 over-indented
usr/lib/byobu/include/config.py:140:3: E117 over-indented
usr/lib/byobu/include/config.py:142:3: E117 over-indented
usr/lib/byobu/include/config.py:146:2: E117 over-indented
usr/lib/byobu/include/config.py:155:2: E117 over-indented
usr/lib/byobu/include/config.py:169:2: E117 over-indented
usr/lib/byobu/include/config.py:173:3: E117 over-indented
usr/lib/byobu/include/config.py:174:4: E117 over-indented
usr/lib/byobu/include/config.py:175:5: E117 over-indented
usr/lib/byobu/include/config.py:177:5: E117 over-indented
usr/lib/byobu/include/config.py:179:5: E117 over-indented
usr/lib/byobu/include/config.py:181:5: E117 over-indented
usr/lib/byobu/include/config.py:183:5: E117 over-indented
usr/lib/byobu/include/config.py:184:6: E117 over-indented
usr/lib/byobu/include/config.py:187:6: E117 over-indented
usr/lib/byobu/include/config.py:191:3: E117 over-indented
usr/lib/byobu/include/config.py:197:2: E117 over-indented
usr/lib/byobu/include/config.py:202:3: E117 over-indented
usr/lib/byobu/include/config.py:203:4: E117 over-indented
usr/lib/byobu/include/config.py:205:4: E117 over-indented
usr/lib/byobu/include/config.py:207:4: E117 over-indented
usr/lib/byobu/include/config.py:212:2: E117 over-indented
usr/lib/byobu/include/config.py:215:3: E117 over-indented
usr/lib/byobu/include/config.py:217:3: E117 over-indented
usr/lib/byobu/include/config.py:218:4: E117 over-indented
usr/lib/byobu/include/config.py:219:5: E117 over-indented
usr/lib/byobu/include/config.py:221:5: E117 over-indented
usr/lib/byobu/include/config.py:225:5: E117 over-indented
usr/lib/byobu/include/config.py:227:5: E117 over-indented
usr/lib/byobu/include/config.py:229:5: E117 over-indented
usr/lib/byobu/include/config.py:230:6: E117 over-indented
usr/lib/byobu/include/config.py:233:6: E117 over-indented
usr/lib/byobu/include/config.py:238:2: E117 over-indented
usr/lib/byobu/include/config.py:243:3: E117 over-indented
usr/lib/byobu/include/config.py:244:4: E117 over-indented
usr/lib/byobu/include/config.py:252:3: E117 over-indented
usr/lib/byobu/include/config.py:254:4: E117 over-indented
usr/lib/byobu/include/config.py:255:5: E117 over-indented
usr/lib/byobu/include/config.py:263:2: E117 over-indented
usr/lib/byobu/include/config.py:265:3: E117 over-indented
usr/lib/byobu/include/config.py:266:4: E117 over-indented
usr/lib/byobu/include/config.py:270:3: E117 over-indented
usr/lib/byobu/include/config.py:271:4: E117 over-indented
usr/lib/byobu/include/config.py:277:2: E117 over-indented
usr/lib/byobu/include/config.py:279:3: E117 over-indented
usr/lib/byobu/include/config.py:281:3: E117 over-indented
usr/lib/byobu/include/config.py:288:2: E117 over-indented
usr/lib/byobu/include/config.py:290:3: E117 over-indented
usr/lib/byobu/include/config.py:292:4: E117 over-indented
usr/lib/byobu/include/config.py:293:5: E117 over-indented
usr/lib/byobu/include/config.py:294:6: E117 over-indented
usr/lib/byobu/include/config.py:296:4: E117 over-indented
usr/lib/byobu/include/config.py:298:3: E117 over-indented
usr/lib/byobu/include/config.py:300:4: E117 over-indented
usr/lib/byobu/include/config.py:301:5: E117 over-indented
usr/lib/byobu/include/config.py:302:6: E117 over-indented
usr/lib/byobu/include/config.py:304:4: E117 over-indented
usr/lib/byobu/include/config.py:306:3: E117 over-indented
usr/lib/byobu/include/config.py:309:3: E117 over-indented
usr/lib/byobu/include/config.py:314:2: E117 over-indented
usr/lib/byobu/include/config.py:315:3: E117 over-indented (comment)
usr/lib/byobu/include/config.py:316:3: E117 over-indented
usr/lib/byobu/include/config.py:322:2: E117 over-indented
usr/lib/byobu/include/config.py:332:3: E117 over-indented
usr/lib/byobu/include/config.py:334:4: E117 over-indented
usr/lib/byobu/include/config.py:336:5: E117 over-indented
usr/lib/byobu/include/config.py:339:5: E117 over-indented
usr/lib/byobu/include/config.py:342:5: E117 over-indented
usr/lib/byobu/include/config.py:345:5: E117 over-indented (comment)
usr/lib/byobu/include/config.py:346:5: E117 over-indented
usr/lib/byobu/include/config.py:348:4: E117 over-indented
usr/lib/byobu/include/config.py:352:3: E117 over-indented
usr/lib/byobu/include/config.py:355:4: E117 over-indented
usr/lib/byobu/include/config.py:360:2: E117 over-indented
usr/lib/byobu/include/config.py:361:3: E117 over-indented
usr/lib/byobu/include/config.py:363:3: E117 over-indented
usr/lib/byobu/include/config.py:364:4: E117 over-indented
usr/lib/byobu/include/config.py:365:5: E117 over-indented
usr/lib/byobu/include/config.py:367:3: E117 over-indented
usr/lib/byobu/include/config.py:369:3: E117 over-indented
usr/lib/byobu/include/config.py:374:2: E117 over-indented
usr/lib/byobu/include/config.py:382:3: E117 over-indented
usr/lib/byobu/include/config.py:384:4: E117 over-indented
usr/lib/byobu/include/config.py:386:4: E117 over-indented
usr/lib/byobu/include/config.py:388:4: E117 over-indented
usr/lib/byobu/include/config.py:390:4: E117 over-indented
usr/lib/byobu/include/config.py:397:2: E117 over-indented
checking usr/lib/byobu/include/select-session.py
usr/lib/byobu/include/select-session.py:28:2: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:29:2: E117 over-indented
usr/lib/byobu/include/select-session.py:31:2: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:32:2: E117 over-indented
usr/lib/byobu/include/select-session.py:49:2: E117 over-indented
usr/lib/byobu/include/select-session.py:53:3: E117 over-indented
usr/lib/byobu/include/select-session.py:54:4: E117 over-indented
usr/lib/byobu/include/select-session.py:56:4: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:57:4: E117 over-indented
usr/lib/byobu/include/select-session.py:58:5: E117 over-indented
usr/lib/byobu/include/select-session.py:60:5: E117 over-indented
usr/lib/byobu/include/select-session.py:62:4: E117 over-indented
usr/lib/byobu/include/select-session.py:64:4: E117 over-indented
usr/lib/byobu/include/select-session.py:66:4: E117 over-indented
usr/lib/byobu/include/select-session.py:67:5: E117 over-indented
usr/lib/byobu/include/select-session.py:70:6: E117 over-indented
usr/lib/byobu/include/select-session.py:75:3: E117 over-indented
usr/lib/byobu/include/select-session.py:77:4: E117 over-indented
usr/lib/byobu/include/select-session.py:79:4: E117 over-indented
usr/lib/byobu/include/select-session.py:81:4: E117 over-indented
usr/lib/byobu/include/select-session.py:82:5: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:83:5: E117 over-indented
usr/lib/byobu/include/select-session.py:84:6: E117 over-indented
usr/lib/byobu/include/select-session.py:91:2: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:92:2: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:93:2: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:94:2: E117 over-indented
usr/lib/byobu/include/select-session.py:95:3: E117 over-indented
usr/lib/byobu/include/select-session.py:97:4: E117 over-indented
usr/lib/byobu/include/select-session.py:99:4: E117 over-indented
usr/lib/byobu/include/select-session.py:101:4: E117 over-indented
usr/lib/byobu/include/select-session.py:109:4: E117 over-indented
usr/lib/byobu/include/select-session.py:114:4: E117 over-indented
usr/lib/byobu/include/select-session.py:118:2: E117 over-indented
usr/lib/byobu/include/select-session.py:120:3: E117 over-indented
usr/lib/byobu/include/select-session.py:122:4: E117 over-indented
usr/lib/byobu/include/select-session.py:123:5: E117 over-indented
usr/lib/byobu/include/select-session.py:125:5: E117 over-indented
usr/lib/byobu/include/select-session.py:130:2: E117 over-indented
usr/lib/byobu/include/select-session.py:135:3: E117 over-indented
usr/lib/byobu/include/select-session.py:137:3: E117 over-indented
usr/lib/byobu/include/select-session.py:144:2: E117 over-indented
usr/lib/byobu/include/select-session.py:150:2: E117 over-indented
usr/lib/byobu/include/select-session.py:153:3: E117 over-indented
usr/lib/byobu/include/select-session.py:155:4: E117 over-indented
usr/lib/byobu/include/select-session.py:158:4: E117 over-indented
usr/lib/byobu/include/select-session.py:159:5: E117 over-indented
usr/lib/byobu/include/select-session.py:161:5: E117 over-indented
usr/lib/byobu/include/select-session.py:163:5: E117 over-indented
usr/lib/byobu/include/select-session.py:166:5: E117 over-indented
usr/lib/byobu/include/select-session.py:168:5: E117 over-indented
usr/lib/byobu/include/select-session.py:170:5: E117 over-indented
usr/lib/byobu/include/select-session.py:172:5: E117 over-indented
usr/lib/byobu/include/select-session.py:176:4: E117 over-indented
usr/lib/byobu/include/select-session.py:179:4: E117 over-indented
usr/lib/byobu/include/select-session.py:180:5: E117 over-indented
usr/lib/byobu/include/select-session.py:186:2: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:187:2: E117 over-indented
usr/lib/byobu/include/select-session.py:190:2: E117 over-indented
usr/lib/byobu/include/select-session.py:191:3: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:192:3: E117 over-indented
usr/lib/byobu/include/select-session.py:193:4: E117 over-indented
usr/lib/byobu/include/select-session.py:195:4: E117 over-indented
usr/lib/byobu/include/select-session.py:197:3: E117 over-indented
usr/lib/byobu/include/select-session.py:199:3: E117 over-indented (comment)
usr/lib/byobu/include/select-session.py:200:3: E117 over-indented
usr/lib/byobu/include/select-session.py:204:2: E117 over-indented
usr/lib/byobu/include/select-session.py:206:2: E117 over-indented
make[1]: *** [debian/rules:7: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:3: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 20190909-1105

Finished
--------

E: Build failure (dpkg-buildpackage died)

+------------------------------------------------------------------------------+
| Cleanup |
+------------------------------------------------------------------------------+

Purging /<<BUILDDIR>>
Not removing build depends: as requested

+------------------------------------------------------------------------------+
| Summary |
+------------------------------------------------------------------------------+

Build Architecture: amd64
Build-Space: 3464
Build-Time: 3
Distribution: eoan
Fail-Stage: build
Host Architecture: amd64
Install-Time: 21
Job: byobu_5.129-0ubuntu1.dsc
Machine Architecture: amd64
Package: byobu
Package-Time: 24
Source-Version: 5.129-0ubuntu1
Space: 3464
Status: attempted
Version: 5.129-0ubuntu1
--------------------------------------------------------------------------------
Finished at 20190909-1105
Build needed 00:00:24, 3464k disc space
RUN: /usr/share/launchpad-buildd/bin/in-target scan-for-processes --backend=chroot --series=eoan --arch=amd64 PACKAGEBUILD-17536278
Scanning for processes to kill in build PACKAGEBUILD-17536278

[Mitsuya Shibata (cosmos-door)]

I send Merge Request to fix ftbfs.

https://code.launchpad.net/~cosmos-door/byobu/lp1843729/+merge/373372

Could you review it?

[Andreas Hasenack (ahasenack)]

@cosmos-door, thanks for that merge request against upstream. We are just a few days away from Final Freeze, though. Would you perhaps be able to make a merge proposal against the packaging, with a quilt patch? That would be the ubuntu/devel branch, if you clone the repository according to the instructions in https://code.launchpad.net/ubuntu/+source/byobu

[Mitsuya Shibata (cosmos-door)]

@ahasenack

Send merge request for package and set you as reviewer. Coudld you review it?
https://code.launchpad.net/~cosmos-door/ubuntu/+source/byobu/+git/byobu/+merge/373861

[Paride Legovini (paride)]

The patch looks good for upstream inclusion, but if this has to be fixed in the packaging branch wouldn't skipping pep8's newly introduced E117 be more appropriate? Skip to be kept until the proper fix lands upstream.

[Mitsuya Shibata (cosmos-door)]

Hi, @legovini

> Skip to be kept until the proper fix lands upstream.

I want to ask about this in detail.

A. Use quilt

  1. we can just drop patch by dep3 tag, when the proper fix lands upstream.
  2. we can run pep8 (all) until the proper fix lands upstream.
  3. we needs to merge in new upstream release until the proper fix lands upstream.
  4. the source of package is more different than the original code.

B. Not use quilt

  1. we needs to revert debian/rules by our memory, when the proper fix upstream.
  2. we can't run pep8 (only E117) until the proper fix lands upstream.
  3. we can merge more simply in new upstream release.
  4. the source of package has no difference with the original code.

In my opinion, I think 1. is more useful for the future by A-1.

But you worry about A-4/B-4? If so, I'm going to try to drop this differences by skip pep8/E117.

[Mitsuya Shibata (cosmos-door)]

Hi, @legovini

I applied your suggestion. Could you review it?

https://code.launchpad.net/~cosmos-door/ubuntu/+source/byobu/+git/byobu/+merge/373861

[Dustin Kirkland  (kirkland)]

Hi there, Byobu maintainer here.

Nack, on the tab-to-whitespace changes. I'll have pep8 ignore E117.

[Andreas Hasenack (ahasenack)]

Hi Dustin,

can you nack the MP please?

[Paride Legovini (paride)]

@Dustin,

Just in case you missed it, there are two MPs from Mitsuya: [1] is the one you want to nack, [2] adds a pep8 ignore for E117 instead.

Paride

[1] https://code.launchpad.net/~cosmos-door/byobu/lp1843729/+merge/373372
[2] https://code.launchpad.net/~cosmos-door/ubuntu/+source/byobu/+git/byobu/+merge/373861

[Launchpad Janitor (janitor)]

This bug was fixed in the package byobu - 5.130-0ubuntu2

---------------
byobu (5.130-0ubuntu2) focal; urgency=medium

  * d/docs: README is now named README.md upstream

 -- Bryce Harrington <email address hidden> Wed, 04 Dec 2019 14:24:40 -0800