budgie-wallstreet applet custom folder with whitespace
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
budgie-extras (Ubuntu) |
Fix Released
|
Low
|
Jacob Vlijm | ||
Jammy |
Fix Released
|
Low
|
Sam Lane | ||
Kinetic |
Fix Released
|
Low
|
fossfreedom | ||
Lunar |
Fix Released
|
Low
|
Jacob Vlijm |
Bug Description
[ Impact ]
* Wallstreet is an app designed to switch desktop wallpapers at a user defined interval. When a custom path to the wallpapers is selected, if there is a space in the path, Wallstreet will fail to find the selected images. As a result, no desktop wallpaper will be displayed at all.
* This creates an issue, as it is common for users to create paths with spaces. Therefore, they may be completely unaware that a space in a folder will cause this failure, especially since selecting the folder will give no indication otherwise. Since the app will no longer correctly find these images, it will appear that the app is broken or not running with no obviousreason why.
* When the custom path is selected, the white space is saved as %20, which is not correctly translated back when Wallstreet attempts to change the image. The method used to read the user selected folder path has been updated to correctly allow paths with white spaces.
[ Test Plan ]
* To Reproduce:
- create a folder with a space in it, such as "~/Pictures/Desktop Backgrounds" and save desired desktop wallpapers to this folder.
- Enusre Wallstreet is installed
- Run Wallstreet Control from the menu
- Uncheck "Use Default Wallpapers"
- Click "Browse" and select the folder with the space
- Check "Run Wallstreet"
- Note how the desktop wallpaper disappears (in my instance, replaced with a solid blue background)
- at the interval selected, still no wallpaper will load
* After applying the fix, follow the same steps listed above.
- Wallpapers correctly are displayed.
- Wallpapers change at the correct interval
[ Where problems could occur ]
In instances where a user has already selected a path containing a space, they may to re-select the desired folder.
---
I have a folder of background images that I want to rotate through via wallstreet.
For historical reasons, that lives in a directory that gets automatically synced across multiple of my machines and the folder name has a white space in it: ~/Pictures/
I can obviously fix this on my end by using a folder without a white space in it (and I have confirmed it works fine then), but I noticed a curious behaviour of the file/folder picker in the wallstreet control tool.
When I navigate to the folder, it gets selected and stored as: /home/kai/
wallstreet-
Access to the dir this way in a shell similarly fails:
$ ls /home/kai/
The correct way to access the directory would be
$ ls /home/kai/
Ideally the folder picker from wallstreet would create this notation for a folder with a white space in its name instead.
ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: budgie-wallstreet 1.4.0-1ubuntu2
ProcVersionSign
Uname: Linux 5.13.0-7619-generic x86_64
ApportVersion: 2.20.11-0ubuntu82
Architecture: amd64
CasperMD5CheckR
CurrentDesktop: Budgie:GNOME
Date: Sun May 1 19:37:48 2022
SourcePackage: budgie-extras
UpgradeStatus: Upgraded to jammy on 2022-04-30 (1 days ago)
Changed in budgie-extras (Ubuntu): | |
assignee: | nobody → Jacob Vlijm (vlijm) |
status: | New → Fix Committed |
Changed in budgie-extras (Ubuntu): | |
status: | Fix Committed → In Progress |
Changed in budgie-extras (Ubuntu): | |
status: | In Progress → Confirmed |
Changed in budgie-extras (Ubuntu Lunar): | |
status: | Fix Committed → Fix Released |
Changed in budgie-extras (Ubuntu Kinetic): | |
status: | Confirmed → Fix Released |
assignee: | nobody → fossfreedom (fossfreedom) |
Changed in budgie-extras (Ubuntu Jammy): | |
assignee: | nobody → Sam Lane (samlane00) |
description: | updated |
description: | updated |
Changed in budgie-extras (Ubuntu Jammy): | |
status: | Confirmed → In Progress |
tags: |
added: verification-done removed: verification-needed |
Changed in budgie-extras (Ubuntu): | |
status: | Fix Committed → Fix Released |
Resolved by commits https:/ /github. com/UbuntuBudgi e/budgie- extras/ commit/ 0bb31a713c2b6dd 46010cef0379ca8 500c3929c4 and https:/ /github. com/UbuntuBudgi e/budgie- extras/ commit/ 6f5f6d01657db93 9a61f2ec8a36805 631ccac29e
Suitable for SRU when we have a similar "affects" both kinetic and jammy budgie-extras bug