Activity log for bug #1872197

Date Who What changed Old value New value Message
2020-04-11 14:34:25 Coeur Noir bug added bug
2020-04-11 14:44:18 fossfreedom budgie-extras (Ubuntu): status New In Progress
2020-04-11 14:44:24 fossfreedom budgie-extras (Ubuntu): importance Undecided High
2020-04-11 14:44:29 fossfreedom budgie-extras (Ubuntu): assignee fossfreedom (fossfreedom)
2020-04-11 14:44:45 fossfreedom nominated for series Ubuntu Focal
2020-04-11 14:44:45 fossfreedom bug task added budgie-extras (Ubuntu Focal)
2020-04-11 14:44:45 fossfreedom nominated for series Ubuntu Eoan
2020-04-11 14:44:45 fossfreedom bug task added budgie-extras (Ubuntu Eoan)
2020-04-11 14:44:56 fossfreedom budgie-extras (Ubuntu Eoan): status New In Progress
2020-04-11 14:45:00 fossfreedom budgie-extras (Ubuntu Eoan): importance Undecided High
2020-04-11 14:45:04 fossfreedom budgie-extras (Ubuntu Eoan): assignee fossfreedom (fossfreedom)
2020-04-12 20:22:40 Launchpad Janitor budgie-extras (Ubuntu Focal): status In Progress Fix Released
2020-04-13 13:31:28 Ubuntu budgie description See https://discourse.ubuntubudgie.org/t/trash-applet-when-emptying-follow-links/3330 for reference. hi, confirmation needed. I suspect trash applet to delete not only symlink but also source file or folder to that link. create a symlink to a folder containing many things. Put it in trash. Use trash-applet to empty trash → original folder and its content are deleted. Create another symlink. Put it in trash. Use Nemo to empty trash → only link is deleted, and not original source. Does anyone confirm ? If so, that sounds like a bug as I don’t expect source to be deleted when deleting a link. ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: budgie-trash-applet 0.10.1-0ubuntu3 ProcVersionSignature: Ubuntu 5.3.0-46.38-generic 5.3.18 Uname: Linux 5.3.0-46-generic x86_64 ApportVersion: 2.20.11-0ubuntu8.8 Architecture: amd64 CurrentDesktop: Budgie:GNOME Date: Sat Apr 11 16:30:47 2020 InstallationDate: Installed on 2020-03-22 (19 days ago) InstallationMedia: Ubuntu-Budgie 19.10 "Eoan Ermine" - Release amd64 (20191017) SourcePackage: budgie-extras UpgradeStatus: No upgrade log present (probably fresh install) (SRU In preparation) [Impact] * Budgie Trash Applet is an optional applet a user can add to their desktop. * The applet has a feature to empty the current local drive trash can. * Where users have folders located on additional hard-drives some people access those folders via a symbolic link. If the user deletes the symbolic link to a folder located on another drive/partition, the trash-can appears full i.e. ready to be emptied. Emptying the trash can will delete the symbolic link - but more importantly will delete everything that the symbolic link was pointing to. * This upload ensures that the trash-can empty code respects the "do not follow symbolic link" GLIB File request so that it only processes the symbolic link. [Test Case] * Requests a symbolic link to a folder located on another hard-drive or partition. * In that folder include test files. * Delete the symbolic link * Choose the applet empty trash can option * Examine if the symbolic link has been removed - yes is success * Examine the folder and its contents that the symbolic link was originally pointing to - the folder and its contents are NOT deleted. This denotes success [Regression Potential] * There are multiple ways symbolic links can be used - nested within folders pointing to various other places. There is a regression potential that not all symbolic link use cases have been caught. * However saying that - the basic use-case outlined here has been tested by the OP via a test PPA on 19.10. This is an SRU to formalise what has already been tested and proven to work. * For budgie, emptying the trash-can via Nemo works as an alternative solution - the trash-can is an optional feature that can be removed if causing additional detrimental issues. * Testers MUST have good backups of their system to ensure if any regressions can be mitigated through restores. [Other Info] * N/A ----- Original description See https://discourse.ubuntubudgie.org/t/trash-applet-when-emptying-follow-links/3330 for reference. hi, confirmation needed. I suspect trash applet to delete not only symlink but also source file or folder to that link. create a symlink to a folder containing many things. Put it in trash. Use trash-applet to empty trash → original folder and its content are deleted. Create another symlink. Put it in trash. Use Nemo to empty trash → only link is deleted, and not original source. Does anyone confirm ? If so, that sounds like a bug as I don’t expect source to be deleted when deleting a link. ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: budgie-trash-applet 0.10.1-0ubuntu3 ProcVersionSignature: Ubuntu 5.3.0-46.38-generic 5.3.18 Uname: Linux 5.3.0-46-generic x86_64 ApportVersion: 2.20.11-0ubuntu8.8 Architecture: amd64 CurrentDesktop: Budgie:GNOME Date: Sat Apr 11 16:30:47 2020 InstallationDate: Installed on 2020-03-22 (19 days ago) InstallationMedia: Ubuntu-Budgie 19.10 "Eoan Ermine" - Release amd64 (20191017) SourcePackage: budgie-extras UpgradeStatus: No upgrade log present (probably fresh install)
2020-04-13 13:41:42 fossfreedom attachment added trashcan.debdiff https://bugs.launchpad.net/ubuntu/+source/budgie-extras/+bug/1872197/+attachment/5353282/+files/trashcan.debdiff
2020-04-13 13:44:28 fossfreedom description (SRU In preparation) [Impact] * Budgie Trash Applet is an optional applet a user can add to their desktop. * The applet has a feature to empty the current local drive trash can. * Where users have folders located on additional hard-drives some people access those folders via a symbolic link. If the user deletes the symbolic link to a folder located on another drive/partition, the trash-can appears full i.e. ready to be emptied. Emptying the trash can will delete the symbolic link - but more importantly will delete everything that the symbolic link was pointing to. * This upload ensures that the trash-can empty code respects the "do not follow symbolic link" GLIB File request so that it only processes the symbolic link. [Test Case] * Requests a symbolic link to a folder located on another hard-drive or partition. * In that folder include test files. * Delete the symbolic link * Choose the applet empty trash can option * Examine if the symbolic link has been removed - yes is success * Examine the folder and its contents that the symbolic link was originally pointing to - the folder and its contents are NOT deleted. This denotes success [Regression Potential] * There are multiple ways symbolic links can be used - nested within folders pointing to various other places. There is a regression potential that not all symbolic link use cases have been caught. * However saying that - the basic use-case outlined here has been tested by the OP via a test PPA on 19.10. This is an SRU to formalise what has already been tested and proven to work. * For budgie, emptying the trash-can via Nemo works as an alternative solution - the trash-can is an optional feature that can be removed if causing additional detrimental issues. * Testers MUST have good backups of their system to ensure if any regressions can be mitigated through restores. [Other Info] * N/A ----- Original description See https://discourse.ubuntubudgie.org/t/trash-applet-when-emptying-follow-links/3330 for reference. hi, confirmation needed. I suspect trash applet to delete not only symlink but also source file or folder to that link. create a symlink to a folder containing many things. Put it in trash. Use trash-applet to empty trash → original folder and its content are deleted. Create another symlink. Put it in trash. Use Nemo to empty trash → only link is deleted, and not original source. Does anyone confirm ? If so, that sounds like a bug as I don’t expect source to be deleted when deleting a link. ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: budgie-trash-applet 0.10.1-0ubuntu3 ProcVersionSignature: Ubuntu 5.3.0-46.38-generic 5.3.18 Uname: Linux 5.3.0-46-generic x86_64 ApportVersion: 2.20.11-0ubuntu8.8 Architecture: amd64 CurrentDesktop: Budgie:GNOME Date: Sat Apr 11 16:30:47 2020 InstallationDate: Installed on 2020-03-22 (19 days ago) InstallationMedia: Ubuntu-Budgie 19.10 "Eoan Ermine" - Release amd64 (20191017) SourcePackage: budgie-extras UpgradeStatus: No upgrade log present (probably fresh install) [Impact]  * Budgie Trash Applet is an optional applet a user can add to their desktop.  * The applet has a feature to empty the current local drive trash can.  * Where users have folders located on additional hard-drives some people    access those folders via a symbolic link.    If the user deletes the symbolic link to a folder located on another    drive/partition, the trash-can appears full i.e. ready to be emptied.    Emptying the trash can will delete the symbolic link - but more importantly will delete everything that the symbolic link was pointing to.  * This upload ensures that the trash-can empty code respects the "do not follow symbolic link" GLIB File request so that it only processes the symbolic link. * There is no impact on other desktop interfaces - this applet only works on the budgie-desktop [Test Case]  * Requests a symbolic link to a folder located on another hard-drive or partition.  * In that folder include test files.  * Delete the symbolic link  * Choose the applet empty trash can option  * Examine if the symbolic link has been removed - yes is success  * Examine the folder and its contents that the symbolic link was originally pointing to - the folder and its contents are NOT deleted. This denotes success [Regression Potential]  * There are multiple ways symbolic links can be used - nested within folders pointing to various other places. There is a regression potential that not all symbolic link use cases have been caught.  * However saying that - the basic use-case outlined here has been tested by the OP via a test PPA on 19.10. This is an SRU to formalise what has already been tested and proven to work.  * For budgie, emptying the trash-can via Nemo works as an alternative solution - the trash-can is an optional feature that can be removed if causing additional detrimental issues.  * Testers MUST have good backups of their system to ensure if any regressions can be mitigated through restores. * There is no regression potential for other desktop interfaces - the applet is only applicable to budgie. * It is an optional feature to the desktop and thus users who do not use the applet will not be exposed to any potential regression in this area. [Other Info]  * N/A ----- Original description See https://discourse.ubuntubudgie.org/t/trash-applet-when-emptying-follow-links/3330 for reference. hi, confirmation needed. I suspect trash applet to delete not only symlink but also source file or folder to that link. create a symlink to a folder containing many things. Put it in trash. Use trash-applet to empty trash → original folder and its content are deleted. Create another symlink. Put it in trash. Use Nemo to empty trash → only link is deleted, and not original source. Does anyone confirm ? If so, that sounds like a bug as I don’t expect source to be deleted when deleting a link. ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: budgie-trash-applet 0.10.1-0ubuntu3 ProcVersionSignature: Ubuntu 5.3.0-46.38-generic 5.3.18 Uname: Linux 5.3.0-46-generic x86_64 ApportVersion: 2.20.11-0ubuntu8.8 Architecture: amd64 CurrentDesktop: Budgie:GNOME Date: Sat Apr 11 16:30:47 2020 InstallationDate: Installed on 2020-03-22 (19 days ago) InstallationMedia: Ubuntu-Budgie 19.10 "Eoan Ermine" - Release amd64 (20191017) SourcePackage: budgie-extras UpgradeStatus: No upgrade log present (probably fresh install)
2020-04-13 23:04:19 Adolfo Jayme Barrientos nominated for series Ubuntu Bionic
2020-04-13 23:04:19 Adolfo Jayme Barrientos bug task added budgie-extras (Ubuntu Bionic)
2020-04-14 07:57:15 fossfreedom budgie-extras (Ubuntu Bionic): status New Invalid
2020-04-14 21:50:57 Brian Murray budgie-extras (Ubuntu Eoan): status In Progress Fix Committed
2020-04-14 21:51:02 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2020-04-14 21:51:05 Brian Murray bug added subscriber SRU Verification
2020-04-14 21:51:10 Brian Murray tags amd64 apport-bug eoan amd64 apport-bug eoan verification-needed verification-needed-eoan
2020-04-16 22:28:32 fossfreedom tags amd64 apport-bug eoan verification-needed verification-needed-eoan amd64 apport-bug eoan verification-done verification-done-eoan
2020-04-20 22:03:11 Mathew Hodson bug task deleted budgie-extras (Ubuntu Bionic)
2020-04-27 12:32:10 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2020-04-27 12:42:13 Launchpad Janitor budgie-extras (Ubuntu Eoan): status Fix Committed Fix Released