Fix alignment in the "Mode" section of WorkspaceOverview applet

Bug #1773785 reported by Jacob Vlijm on 2018-05-28
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
budgie-extras (Ubuntu)
Status tracked in Cosmic
Bionic
Low
fossfreedom
Cosmic
Low
fossfreedom

Bug Description

[EDIT] Master SRU fix covered by (LP: #1771606)

Budgie Extras is a set of python based applets that are either preinstalled or are available to be individually installed. They are exclusive only to budgie desktop users and cannot be installed or run on any other desktop environment.

A number of issues have been raised since the 18.04 release. As part of ongoing 18.04 support the Ubuntu Budgie Team proposes to wrap up fixes on a very targeted basis. In this series of SRU's we have wrapped up DR's that have been classified as LOW by the UB dev team. In addition the scope of the change has been assessed to limit the potential of regression. This is to ensure each SRU request is strictly limited in scope with the risk(s) being easily determinable.

[Impact]

 The Workspace Overview applet shows a dropdown menu. One of its menu options is "Mode" that contains sub-menu items. The padding of this changes depending upon which theme is currently in use. For the default theme Pocillo - there is a relatively large space between the edge of the menu item to the text string. This visually looks strange. The submenuitem should be fixed spacing via a tab-character rather than based on spaces i.e. a space character sizing changes depending on the theme being chosen.

 The impact is for Ubuntu Budgie only and anyone running the budgie desktop together with the Showtime applet.

[Test Case]

 1. Using Budgie Settings, check that on a panel the Workspace Overview applet has been added - please note, the Workspace Overview applet is installed through the package "budgie-workspace-overview-applet"
 2. Open the mode submenu - observe the indentation between the edge of the submenu and the menu strings.
 3. Choose a different theme from Budgie Settings
 4. Repeat 2 - the indentation should be the same between themes.

[Regression Potential]

 * None. This is a visual issue only and has no impact on capability.

 * Ubuntu Team has independently verified that the fix works.

[Other Info]

 None

EDIT:

Original description

The Mode submenu alignment is not correct on some themes.

Jacob Vlijm (vlijm) on 2018-05-28
description: updated
fossfreedom (fossfreedom) wrote :

fix in v0.5.0 upload to cosmic

description: updated
Changed in budgie-extras (Ubuntu):
importance: Undecided → Low
assignee: nobody → fossfreedom (fossfreedom)
Changed in budgie-extras (Ubuntu Cosmic):
status: New → Fix Released
Changed in budgie-extras (Ubuntu Bionic):
importance: Undecided → Low
assignee: nobody → fossfreedom (fossfreedom)
description: updated
summary: - Fix alignment in the "Mode" section of WorspaceOverview applet
+ Fix alignment in the "Mode" section of WorkspaceOverview applet
description: updated
tags: added: bionic
fossfreedom (fossfreedom) wrote :
fossfreedom (fossfreedom) wrote :

wsoverview.patch is the patch used to resolve this part of the SRU

Hello Jacob, or anyone else affected,

Accepted budgie-extras into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-extras/0.4.4-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in budgie-extras (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Jacob Vlijm (vlijm) wrote :

Tested 0.4.4-0ubuntu1.1, works fine.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Jacob Vlijm (vlijm) on 2018-07-09
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package budgie-extras - 0.4.4-0ubuntu1.1

---------------
budgie-extras (0.4.4-0ubuntu1.1) bionic; urgency=medium

  * Bug-fix release
    - Fix budgie panel hang when USB inserted (LP: #1771606)
      dropby.patch
    - Fix hotcorner activation issues with HiDPI (LP: #1773770)
      hotcorners.patch
    - Fix sensitivity of custom directory text field in quicknote
      quicknote.patch (LP: #1773771)
    - Fix display of 12hr midnight time (LP: #1773773)
      showtime.patch
    - alignment of active/inactive items inconsistent (LP: #1773785)
      wsoverview.patch
    - fix occasional display issues with previews (LP: #1779766)
      wpreviews.patch

 -- David Mohammed <email address hidden> Wed, 04 Jul 2018 20:17:16 +0100

Changed in budgie-extras (Ubuntu Bionic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for budgie-extras has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers