Fix display of 12hr midnight time on ShowTime applet

[Jacob Vlijm]

[EDIT] Master SRU fix covered by (LP: #1771606)

Budgie Extras is a set of python based applets that are either preinstalled or are available to be individually installed. They are exclusive only to budgie desktop users and cannot be installed or run on any other desktop environment.

A number of issues have been raised since the 18.04 release. As part of ongoing 18.04 support the Ubuntu Budgie Team proposes to wrap up fixes on a very targeted basis. In this series of SRU's we have wrapped up DR's that have been classified as LOW by the UB dev team. In addition the scope of the change has been assessed to limit the potential of regression. This is to ensure each SRU request is strictly limited in scope with the risk(s) being easily determinable.

[Impact]

 The Showtime applet can display its time in 12hr format. When the time is between midnight and one am, the time displayed is incorrectly shown in a mixed up 24hour format - not in the usual 12.xx AM format.

 The impact is for Ubuntu Budgie only and anyone running the budgie desktop together with the Showtime applet.

[Test Case]

 1. Using Budgie Settings, check that on a panel the Desktop Showtime applet has been added - please note, the Showtime applet is installed through the package "budgie-showtime-applet"
 2. Manually change the time to be between midnight and one am.
 3. Tick the 12hr format checkbox
 4. The desktop time shown change to 12.xx AM (will take approx 1 minute)
 5. Untick the 12hr format checkbox
 5. The desktop time shown changes to 00:XX format
 6. Repeat steps 2 to 5 but for other times during the day. The 12 hr format should be correctly shown.

[Regression Potential]

 * None.

 * Ubuntu Team has independently verified that the fix works.

[Other Info]

 None

EDIT:

Original description

When 12hr display is enabled, the display of the clock
 is incorrect from midnight to 1am.

[fossfreedom (fossfreedom)]

Fixed in v0.5.0 that was uploaded in cosmic

[fossfreedom (fossfreedom)]

showtime.patch is the patch used to resolve this part of the SRU

[Łukasz Zemczak (sil2100)]

Hello Jacob, or anyone else affected,

Accepted budgie-extras into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-extras/0.4.4-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jacob Vlijm (vlijm)]

Tested 0.4.4-0ubuntu1.1, works fine.

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-extras - 0.4.4-0ubuntu1.1

---------------
budgie-extras (0.4.4-0ubuntu1.1) bionic; urgency=medium

  * Bug-fix release
    - Fix budgie panel hang when USB inserted (LP: #1771606)
      dropby.patch
    - Fix hotcorner activation issues with HiDPI (LP: #1773770)
      hotcorners.patch
    - Fix sensitivity of custom directory text field in quicknote
      quicknote.patch (LP: #1773771)
    - Fix display of 12hr midnight time (LP: #1773773)
      showtime.patch
    - alignment of active/inactive items inconsistent (LP: #1773785)
      wsoverview.patch
    - fix occasional display issues with previews (LP: #1779766)
      wpreviews.patch

 -- David Mohammed <email address hidden> Wed, 04 Jul 2018 20:17:16 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for budgie-extras has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.