Comment 0 for bug 1739808

Revision history for this message
adrenochrome (adrenochrome) wrote :

in file usr/lib/cups/filter/brlpdwrapperMFC5840CN line 67 & 346
the resolution 1200x600 is wrong, it doesnt exists

(line 63-78)
    Resolution=Fast0 "-reso 300 -md PLAIN -doc GRAPH" \
    Resolution=Normal0 "-reso 600 -md PLAIN -doc GRAPH" \
    Resolution=EnhNormal0 "-reso 750 -md PLAIN -doc GRAPH" \
    Resolution=Fine0 "-reso 1200 -md PLAIN -doc GRAPH" \
    Resolution=Fine1 "-reso 1200x600 -md INKJET -doc GRAPH" \
    Resolution=Photo1 "-reso 1200 -md INKJET -doc PHOTO" \
    Resolution=Fine2 "-reso 1200 -md GLOSSY -doc GRAPH" \
    Resolution=Photo2 "-reso 1200 -md GLOSSY -doc PHOTO" \
    Resolution=Highest2 "-reso 1200x6000 -md GLOSSY -doc PHOTO" \
    Resolution=Normal3 "-reso 600 -md TRANS" \
    Resolution=EnhNormal3 "-reso 750 -md TRANS" \
    Resolution=Fine3 "-reso 1200 -md TRANS" \
    Resolution=Fast4 "-reso 300 -md SLOWDRY" \
    Resolution=Normal4 "-reso 600 -md SLOWDRY" \
    Resolution=EnhNormal4 "-reso 750 -md SLOWDRY" \
    Resolution=Fine4 "-reso 1200 -md SLOWDRY" \
(line 342-357)
                Fast0 "-reso 300 -md PLAIN -doc GRAPH" \
                Normal0 "-reso 600 -md PLAIN -doc GRAPH" \
                EnhNormal0 "-reso 750 -md PLAIN -doc GRAPH" \
                Fine0 "-reso 1200 -md PLAIN -doc GRAPH" \
                Fine1 "-reso 1200x600 -md INKJET -doc GRAPH" \
                Photo1 "-reso 1200 -md INKJET -doc PHOTO" \
                Fine2 "-reso 1200 -md GLOSSY -doc GRAPH" \
                Photo2 "-reso 1200 -md GLOSSY -doc PHOTO" \
                Highest2 "-reso 1200x6000 -md GLOSSY -doc PHOTO" \
                Normal3 "-reso 600 -md TRANS" \
                EnhNormal3 "-reso 750 -md TRANS" \
                Fine3 "-reso 1200 -md TRANS" \
                Fast4 "-reso 300 -md SLOWDRY" \
                Normal4 "-reso 600 -md SLOWDRY" \
                EnhNormal4 "-reso 750 -md SLOWDRY" \
                Fine4 "-reso 1200 -md SLOWDRY" \

http://support.brother.com/g/s/id/linux/en/instruction_prn4.html
links to
http://support.brother.com/g/s/id/linux/pdf/option_lprink3.pdf
which reports resolutions 1200x6000 and 1200x2400

it can be confirmed with usr/bin/brprintconfij2 from brother-lpr-drivers

strings brprintconfij2 | grep "1200x"
brprintconfij2:1200x2400
brprintconfij2:1200x6000
brprintconfij2:PaperType={A4_B,Letter_B,A6_B,Photo_B,IndexCard_B,PhotoL_B,Photo2L_B,Hagaki_B}*RResolution={300,600,750,1200,1200x2400}

so, as this resolution dont exists (its probably a remain from the debian already fixed 1200x600->1200x6000 from original brother files) the defintion at line 88 should be suppressed
    Resolution=1200x600 "-reso 1200x600" \

moreover

according to mfc5840cn manual http://download.brother.com/welcome/doc000240/BH3_UkEngSoft_D.pdf
page 16-17
the following resolutions are available
fast normal 600x300 (-reso 300)
normal 600x600 (-reso 600)
enhanced normal 750x750 (-reso 750)
fine 1200x1200 (-reso 1200)
photo 1200x2400 (-reso 1200x2400)
highest 1200x6000 (-reso 1200x6000)

and for injet paper "fine and photo" are available, so strings
                Fine1 "-reso 1200x600 -md INKJET -doc GRAPH"
should be changed 2x to
                Fine1 "-reso 1200 -md INKJET -doc GRAPH"
and
                Photo1 "-reso 1200 -md INKJET -doc PHOTO"
should be changed 2x to
                Photo1 "-reso 1200x2400 -md INKJET -doc PHOTO"

for glossy "fine, photo and highest" are available, so
                Photo2 "-reso 1200 -md GLOSSY -doc PHOTO"
should be changed 2x to
                Photo2 "-reso 1200x2400 -md GLOSSY -doc PHOTO"

i attached the fixed file to this bugreport

line 289 - 292 is probably wrong too
  Normal "-reso 300"
  Fine "-reso 600"
  S\.Fine "-reso 600"
  Photo "-reso 600"
but i dont think they are used, they are probably overrided by the next DefaultResolution with the same label @ 342-357

and finally, resolution descriptions in the ppd file should be edited to reflect the changes