[sru] backport 0.5 release to bionic

Bug #1798014 reported by Mario Limonciello on 2018-10-16
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bolt (Ubuntu)
Undecided
Unassigned
Bionic
High
Mario Limonciello

Bug Description

[Impact]
 * The bolt 0.4 release introduced support for Thunderbolt force power, but it has been reported that this conflicts with the fwupd force power support. This is a regression as a result of 0.4 being backported to bionic.
 * Bolt 0.5 will work together with other applications that support the bolt force power API (such as fwupd 1.0.9) to make sure that one doesn't stomp on the other's toes.

[Test Case]

 * Open up Thunderbolt GUI in gnome control center and ensure Thunderbolt devices are listed when plugged in.

[Regression Potential]
 * Regressions if manifested would cause thunderbolt security levels to not function proplery.

[Other Info]

An SRU is filed for fwupd 1.0.9 which also support bolt and fwupd coordinating force power.

The update has non-bugfix/trivial changes but that component was new in bionic and is needed for new hardware (thunderbolt3) to be properly supported so we accepted that we need to roll out new versions for better hardware support, which is what we are doing.

Jeremy Bicha (jbicha) on 2018-10-16
Changed in bolt (Ubuntu):
status: New → In Progress
tags: added: bionic
Changed in bolt (Ubuntu):
status: In Progress → Fix Released
Changed in bolt (Ubuntu Bionic):
status: New → In Progress
assignee: nobody → Mario Limonciello (superm1)
Mario Limonciello (superm1) wrote :

The fwupd 1.0.9 SRU bug is here: #1791999

SRU team:
Ideally, please process these at the same time.

Mario Limonciello (superm1) wrote :

Since the backport of bolt 0.4 (with force power support that conflicted with fwupd) is what introduced the need for this SRU adjusting the importance.

Changed in bolt (Ubuntu Bionic):
importance: Undecided → Critical
Mario Limonciello (superm1) wrote :

Since backporting 0.4 lead to a regression, adding regression-update to this bug (Although it's a little confusing since this bug "resolves" that regression).

tags: added: regression-update
Sebastien Bacher (seb128) wrote :

Does it really lead to a regression-update? In https://bugs.launchpad.net/ubuntu/+source/bolt/+bug/1795864/comments/7 you wrote "this can cause problems in bionic too if on fwupd 1.0.9 or later" or currently bionic/bionic-updates have fwupd 1.0.6, so there is no regression until 1.0.9 lands (which is blocked not by verification-failed tagging of that update)

Changed in bolt (Ubuntu Bionic):
importance: Critical → High
Mario Limonciello (superm1) wrote :

I reproduced a failure in fwupd 1.0.6 as well caused by bolt 0.4. it's because bolt didn't know fwupd was performing an update and turned off thunderbolt during the update.

In 1.0.9 they work together to prevent this.

description: updated
Robie Basak (racb) wrote :

It looks like Mario and Sebastien have different competing updates in the queue. Which one do you want?

Robie Basak (racb) wrote :

Here's the diff between the two versions in the queue: http://paste.ubuntu.com/p/tKRSR5Yq7s/

Sebastien's. He took out a few of the "unnecessary" changes in doing the
backport.

On Wed, Oct 31, 2018 at 12:01 PM Robie Basak <email address hidden>
wrote:

> Here's the diff between the two versions in the queue:
> http://paste.ubuntu.com/p/tKRSR5Yq7s/
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1798014
>
> Title:
> [sru] backport 0.5 release to bionic
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/bolt/+bug/1798014/+subscriptions
>

--
Mario Limonciello
<email address hidden>

Robie Basak (racb) wrote :

Thanks.

Reviewing Sebastien's, I don't see the use of -Ddb-path updated, but upstream states that it is deprecated in https://gitlab.freedesktop.org/bolt/bolt/merge_requests/113/diffs. Deprecation rather than removal might be OK, but the upstream diff suggests to me that -Ddb-path is now ignored entirely. Is this a regression?

I'm EOD now so I'm going to stop here, but hopefully if that is an issue we'll have saved some time in a round trip there.

Robie Basak (racb) wrote :

Upstream release notes including notes for packagers are at: https://gitlab.freedesktop.org/bolt/bolt/tags - it seems that there are a number of things to consider and might be especially important for an SRU backport.

Sebastien Bacher (seb128) wrote :

@Robie, right, sorry I ment to drop that option and even listed that as a change in the changelog
"+ - drop use of the -Ddb-path option which is deprecated now"

I've built the new version locally and in a ppa and verified that the path is still the same so that option isn't needed/doesn't need replacing. I'm going to do another upload on monday to really drop the mention in the debian/rules but technically since it's ignoring the current version in the queue could as well be approved.

Let me know if that's good enough for you or if you have other questions about the update

Sebastien Bacher (seb128) wrote :

@Robie, I've reuploaded without the -Ddb-path use, could you have another look?

Hello Mario, or anyone else affected,

Accepted bolt into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/bolt/0.5-0ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in bolt (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Mario Limonciello (superm1) wrote :

I've tested the SRU on bionic and authorized a device successfully.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers