Can you add the btvirt executable to bluez-tests?

Bug #1932022 reported by Niek van der Maas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bluez (Ubuntu)
Wishlist
Daniel van Vugt

Bug Description

See the Debian package: https://packages.debian.org/buster/i386/bluez-test-tools/filelist

The Ubuntu package contains the same tools, except for btvirt. Would it be possible to add this? The buildlog shows that the btvirt executable is already built, but just not put into the *.deb package.

Additions to be done to debian/bluez-tests.install:

emulator/b1ee usr/bin
emulator/btvirt usr/bin
emulator/hfp usr/bin

Having the btvirt tool available will make testing on CI systems a lot easier.

References:
https://github.com/hadess/bluez/blob/master/Makefile.tools#L76-L82
https://answers.launchpad.net/ubuntu/+source/bluez/+question/697542

Manfred Hampl (m-hampl)
Changed in bluez (Ubuntu):
status: New → Confirmed
tags: added: impish
Changed in bluez (Ubuntu):
importance: Undecided → Wishlist
status: Confirmed → Triaged
Changed in bluez (Ubuntu):
assignee: nobody → Daniel van Vugt (vanvugt)
status: Triaged → In Progress
Revision history for this message
Sebastien Bacher (seb128) wrote :

similar to bug #1907886 if upstream decided to include it in the noinst set they might have a reason?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

> similar to bug #1907886 if upstream decided to include it in the noinst set they might have a reason?

In bug 1907886 that consideration sounds like it was overridden by the statement: "fedora is including it in their binary though, we could probably do the same for Ubuntu".

As for this bug, 'btvirt' is being packaged by Debian already. On top of that 'btvirt' has no external dependencies (only libc).

So users are requesting 'btvirt' (hence this bug), Debian already packages it, and I see no dependency problems. I see no reason why we can't package it. That doesn't speak for the quality or correctness of the program, but I don't have any evidence that it's below that of other BlueZ binaries. Even if it was, getting it released for people to test it and report bugs seems like the most sensible approach to me.

Changed in bluez (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bluez - 5.59-0ubuntu1

---------------
bluez (5.59-0ubuntu1) impish; urgency=medium

  * New upstream release 5.59 (LP: #1933078):
    - Fix issue with string to UUID-32 conversion.
    - Fix issue with connect request if SDP search failed.
    - Fix issue with accepting invalid AVDTP capabilities.
    - Fix issue with unregister handling of AVRCP player.
  * Add new build-dep 'python3-docutils' required for rst2man.
  * Add new package 'bluez-meshd' and --enable-mesh (LP: #1929833).
    - Requires new build-dep 'libjson-c-dev'.
  * Cleanups from upstream debian:
    - Remove empty packages 'libbluetooth3-dbg' and 'bluez-dbg'.
    - Lots of benign formatting changes in debian/control to shrink the diff.
  * Add binaries 'b1ee', 'btvirt', 'hfp' to 'bluez-tests' (LP: #1932022).
  * Add binary 'avinfo' to 'bluez' (LP: #1907886).
  * Add patch Fix-reading-from-rfkill-socket.patch to resolve Bluetooth
    on/off toggle issues with newer kernel versions (LP: #1926062).

 -- Daniel van Vugt <email address hidden> Mon, 21 Jun 2021 17:02:38 +0800

Changed in bluez (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related questions